Fix count_security_scans_metric_spec occasional failures

What does this MR do and why?

Fixes failing spec by adjusting date of a created testing object outside of the time frame with a relatable range.

It used to fail sometimes since the metric time frame is counted 30..2.days.ago

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before	After

How to set up and validate locally

rspec ./ee/spec/lib/gitlab/usage/metrics/instrumentations/count_security_scans_metric_spec.rb

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #418221 (closed)

added Category:Service Ping devopsanalyze flaky-testtransient bug groupanalytics instrumentation sectionanalytics test labels

assigned to @nbelokolodov

marked this merge request as ready

changed title from Draft: Resolve "Spec failure: rspec './ee/spec/lib/gitlab/usage/metrics/instrumentations/count_security_scans_metric_spec.rb[1:2:1:7:1:1:1]' # Gitlab::Usage::Metrics::Instrumentations::CountSecurityScansMetric" to Fix count_security_scans_metric_spec occasional failures

changed the description

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

added 1 commit

• 8d57e543 - Increase date frame for CountSecurityScansMetric spec

Compare with previous version

Proper labels assigned to this merge request. Please ignore me.

@nbelokolodov - please see the following guidance and update this merge request.

	1 Error
	Please add typebug typefeature, or typemaintenance label to this merge request.

added analytics instrumentation analytics instrumentationreview pending backend labels

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
analytics instrumentation	Sebastian Rehm (@bastirehm) (UTC+2, 6 hours behind @nbelokolodov)	Maintainer review is optional for analytics instrumentation
backend	Rad Batnag (@radbatnag) (UTC+8, same timezone as @nbelokolodov)	Rémy Coutable (@rymai) (UTC+2, 6 hours behind @nbelokolodov)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added typebug label

@pskorupa could you please review this small fix? (analytics instrumentation and backend )

requested review from @pskorupa

approved this merge request

added analytics instrumentationapproved label and removed analytics instrumentationreview pending label

removed review request for @pskorupa

@pskorupa, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

• rspec predictive jobs
• jest predictive jobs
• merging a merge request.

added pipeline:mr-approved label

@nbelokolodov Some end-to-end (E2E) tests have been selected based on the stage label on this MR.

Please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure the tests in follow-up-e2e:package-and-test-ee pipeline are passing before this MR is merged.

If you would like to run all e2e tests, please apply the pipeline:run-all-e2e label and trigger a new pipeline. This will run all tests in e2e:package-and-test pipeline.

For the list of known failures please refer to the latest pipeline triage issue.

Once done, please apply the emoji on this comment.

For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.

requested review from @.luke