MR pipeline widget: cleanup
What does this MR do and why?
MR pipeline widget cleanup.
CI Widget text squashed when sidebars are expanded (#414566 - closed) • Unassigned • Backlog
Cleans up the MR pipeline widget and adds multiple mobile improvements.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Go to an MR with pipelines enabled (e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/3)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #417912 (closed)
Merge request reports
Activity
changed milestone to %16.3
added UX UX Paper Cuts frontend groupux paper cuts maintenanceusability merge request widget sectiondev severity4 typemaintenance + 1 deleted label
assigned to @seggenberger
- A deleted user
added backend label
3 Warnings ⚠ This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.⚠ This merge request changed files with disabled eslint rules. Please consider fixing them. ⚠ This merge request contains lines with QA selectors. Please ensure e2e:package-and-test
job is run.Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline.vue
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline.vue'
QA Selectors
The following changed lines in this MR contain QA selectors:
- file
app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline.vue
: -
-
data-qa-selector="pipeline_link"
-
-
-
data-qa-selector="pipeline_link"
-
Please ensure
e2e:package-and-test
job is run and the tests are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Tan Le (
@tle_gitlab
) (UTC+10, 8 hours ahead of@seggenberger
)Natalia Tepluhina (
@ntepluhina
) (UTC+2, same timezone as@seggenberger
)test for spec/features/*
Aaron Huntsman (
@ahuntsman
) (UTC-5, 7 hours behind@seggenberger
)Maintainer review is optional for test for spec/features/*
UX Camellia X. Yang (
@cam.x
) (UTC+0, 2 hours behind@seggenberger
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerEdited by Ghost User- Resolved by Alex Fracazo
Hey @mnearents @afracazo @annabeldunstone
I'd love to get your feedback on this cleanup of the MR pipeline widget. Currently text is very cramped so I tried to re-arrange the content a bit for better readability (& mobile view).
TY in advance!
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 587b35b8 and 421b8388
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.15 MB 4.15 MB - 0.0 % mainChunk 3.01 MB 3.01 MB - 0.0 %
Note: We do not have exact data for 587b35b8. So we have used data from: 4bcedcc1.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerEdited by Ghost UserAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
❗ test report for 421b8388expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 13 | 0 | 1 | 12 | 14 | ❗ | | Create | 27 | 0 | 1 | 20 | 28 | ❗ | | Govern | 21 | 0 | 0 | 15 | 21 | ❗ | | Plan | 51 | 0 | 0 | 44 | 51 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Verify | 8 | 0 | 0 | 8 | 8 | ❗ | | Data Stores | 22 | 0 | 0 | 15 | 22 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 146 | 0 | 4 | 114 | 150 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
✅ test report for 421b8388expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 4 | 0 | 24 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded 187 commits
-
ffdc4740...3ef86b76 - 186 commits from branch
master
- e63acc0d - MR pipeline widget: cleanup
-
ffdc4740...3ef86b76 - 186 commits from branch
requested review from @annabeldunstone, @mnearents, and @afracazo
removed review request for @annabeldunstone
👋 @annabeldunstone
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label