Fixes container registry image list sorting UI inconsistency
What does this MR do and why?
- Updates the apollo cache policy for images list query
- Removed explicit calls to fetchMore by updating pageParams instead
- Removes deprecated updateQuery method
This is part of series of MRs for the registry pages !126261 (merged), !126651 (merged)
Screenshots or screen recordings
Before | After |
---|---|
Screen_Recording_2023-07-17_at_4.45.59_pm | Screen_Recording_2023-07-17_at_4.43.40_pm |
How to set up and validate locally
- Setup & enable Container Registry https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/registry.md
- Follow steps in https://gitlab.com/gitlab-org/ci-cd/package-stage/package/-/wikis/Packages-Tips-&-Tricks#how-to-add-images-with-tags-quickly-to-the-registry
- To see pagination, run the following in the terminal
$ ./publish.sh <project-path> 2 25 127.0.0.1:5000 # creates 25 images with 2 tags each
- Visit the container registry list page for the project
- Switching the sort order on the UI should always reset pagination (i.e. send us back to the 1st page)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #409771 (closed)
Edited by Rahul Chanila
Merge request reports
Activity
Please register or sign in to reply