Update Confirm Danger Modal
What does this MR do and why?
This MR updates the phrase text of the Confirm Danger Modal. An example of modal use is when initiating a Group Transfer. To ensure the user understands their action, a confirmation window is presented requesting the user enter an associated phrase (in this case, the namespace to be transferred). As previously discussed when similar wording is used, most end-users are not familiar with the term 'modal', so this may cause confusion. The user is also presented with a Cancel button and a X, which is commonly associated with cancelling an action and choosing to not proceed.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Ensure local instance has at least two top-level groups (namespaces)
- In one group as an Owner, go to Settings → General → Advanced → Transfer Group
- Choose a different group under Select parent group, then press Transfer group.
- Review that the modal text shows the changes from this commit.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @benjaminking
added Support Team Contributions label
- A deleted user
added frontend label
1 Warning This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend James Rushford (
@jrushford
) (UTC+2)Miguel Rincon (
@mrincon
) (UTC+2)test for spec/features/*
Gregorius Marco (
@marcogreg
) (UTC+8)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@benjaminking - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 0c6c9bf7 and 714344aa
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.18 MB 4.18 MB - 0.0 % mainChunk 3.09 MB 3.09 MB - 0.0 %
Note: We do not have exact data for 0c6c9bf7. So we have used data from: a0f22154.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost UserAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 714344aaexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 6 | 2 | 1 | 6 | 9 | ❌ | | Plan | 4 | 0 | 0 | 4 | 4 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 3 | 4 | ❗ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 19 | 2 | 2 | 13 | 23 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 714344aaexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 1 | 9 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded maintenancerefactor typemaintenance labels
changed milestone to %16.2
- Resolved by Olena Horal-Koretska
Hi @ankit.panchal do you mind being my Roulette Reviewer for this MR? I haven't been able to confirm which group should be responsible for this for the proper labels, so if you have an idea that'd be awesome. Thank you!
requested review from @ankit.panchal
added UX label
@ankit.panchal
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @ohoral
removed review request for @ankit.panchal
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
enabled an automatic merge when the pipeline for 47fe38ee succeeds
mentioned in commit 63554dc1
mentioned in issue gitlab-com/support/support-team-meta#5281 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue gitlab-com/support/support-team-meta#5297 (closed)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2281 (merged)
mentioned in issue gitlab-com/www-gitlab-com#32488 (closed)
added releasedpublished label and removed releasedcandidate label