Skip to content
Snippets Groups Projects

Fix more Rspec/DescribedClass violations

What does this MR do and why?

Fix more Rspec/DescribedClass violations

Fixed it by running rubocop with the autocorrect option

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 3 Warnings
    :warning:

    For the following files, a review from the Data team and Analytics Instrumentation team is recommended
    Please check the analytics instrumentation Service Ping guide or the Snowplow guide.

    For MR review guidelines, see the Service Ping review guidelines or the Snowplow review guidelines.

    • spec/lib/gitlab/usage/metrics/aggregates/sources/redis_hll_spec.rb
    :warning: This merge request is quite big (559 lines changed), please consider splitting it into multiple merge requests.
    :warning: This merge request does not refer to an existing milestone.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    analytics instrumentation Piotr Skorupa current availability (@pskorupa) (UTC+2, 7.5 hours behind @dskim_gitlab) Maintainer review is optional for analytics instrumentation
    backend Aman Luthra current availability (@aluthra2) (UTC+5.5, 4.0 hours behind @dskim_gitlab) Rémy Coutable current availability (@rymai) (UTC+2, 7.5 hours behind @dskim_gitlab)
    ~"Verify" Reviewer review is optional for ~"Verify" Drew Cimino current availability (@drew) (UTC+0, 9.5 hours behind @dskim_gitlab)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
  • Sincheol (David) Kim added 547 commits

    added 547 commits

    Compare with previous version

  • requested review from @shinya.maeda

  • Sincheol (David) Kim requested review from @allison.browne and removed review request for @shinya.maeda

    requested review from @allison.browne and removed review request for @shinya.maeda

  • Allison Browne approved this merge request

    approved this merge request

  • :wave: @allison.browne, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Allison Browne resolved all threads

    resolved all threads

  • Allison Browne enabled an automatic merge when the pipeline for dba78360 succeeds

    enabled an automatic merge when the pipeline for dba78360 succeeds

  • merged

  • Allison Browne mentioned in commit 8d3d0e79

    mentioned in commit 8d3d0e79

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading