Fix more Rspec/DescribedClass violations
What does this MR do and why?
Fix more Rspec/DescribedClass violations
Fixed it by running rubocop with the autocorrect option
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added backend groupcode review maintenancerefactor labels
assigned to @dskim_gitlab
added typemaintenance label
added devopscreate sectiondev labels
- A deleted user
- Resolved by Allison Browne
3 Warnings For the following files, a review from the Data team and Analytics Instrumentation team is recommended
Please check the analytics instrumentation Service Ping guide or the Snowplow guide.For MR review guidelines, see the Service Ping review guidelines or the Snowplow review guidelines.
spec/lib/gitlab/usage/metrics/aggregates/sources/redis_hll_spec.rb
This merge request is quite big (559 lines changed), please consider splitting it into multiple merge requests. This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer analytics instrumentation Piotr Skorupa (
@pskorupa
) (UTC+2, 7.5 hours behind@dskim_gitlab
)Maintainer review is optional for analytics instrumentation backend Aman Luthra (
@aluthra2
) (UTC+5.5, 4.0 hours behind@dskim_gitlab
)Rémy Coutable (
@rymai
) (UTC+2, 7.5 hours behind@dskim_gitlab
)~"Verify" Reviewer review is optional for ~"Verify" Drew Cimino (
@drew
) (UTC+0, 9.5 hours behind@dskim_gitlab
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded 547 commits
-
ac430334...cea5ce3f - 546 commits from branch
master
- e86c2abe - Fix more Rspec/DescribedClass violations
-
ac430334...cea5ce3f - 546 commits from branch
- Resolved by Allison Browne
@shinya.maeda Would you be able review this MR please? I've just rubocop with
-A
option and only committed the straight forward ones that doesn't break any specks.
requested review from @shinya.maeda
requested review from @allison.browne and removed review request for @shinya.maeda
@allison.browne
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for dba78360 succeeds
mentioned in commit 8d3d0e79
added workflowstaging-canary label