Atwho styling update
What does this MR do and why?
More Atwho styling adjustments to better match the one from the new Rich text editor:
- Height of list items
- Put Emoji upfront
- Dropdown list max-height
Follow-up to Update atwho styling to match new dropdown styles (!124729 - merged)
Screenshots or screen recordings
| Before | After | Richtext |
|---|---|---|
 |
 |
 |
 |
 |
 |
 |
 |
 |
 |
 |
 |
 |
 |
 |
 |
 |
 |
 |
 |
 |
How to set up and validate locally
- Check the editor (e.g. http://gdk.test:3000/flightjs/Flight/-/issues/new)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.2
added UX UX Paper Cuts frontend groupux paper cuts maintenanceusability markdown sectiondev severity4 typemaintenance + 1 deleted label
assigned to @seggenberger
1 Warning 
This merge request changed files with disabled eslint rules. Please consider fixing them. Disabled eslint rules
The following files have disabled
eslintrules. Please consider fixing them:spec/frontend/gfm_auto_complete_spec.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'spec/frontend/gfm_auto_complete_spec.js'Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Alex Pennells (
@apennells) (UTC-4, 6 hours behind@seggenberger)Ezekiel Kigbo (
@ekigbo) (UTC+10, 8 hours ahead of@seggenberger)Application Security Reviewer review is optional for Application Security Costel Maxim (
@cmaxim) (UTC+3, 1 hour ahead of@seggenberger)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by Ghost User
Resolved by Phil Hughes- Last reply by Sascha Eggenberger
requested review from @annabeldunstone and @arfedoro
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c4811615 and cd94e9db
Entrypoint / Name Size before Size after Diff Diff in percent average 4.14 MB 4.14 MB - 0.0 % mainChunk 3 MB 3 MB - 0.0 %
Note: We do not have exact data for c4811615. So we have used data from: 5fca9672.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-reviewjob
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Allure report
allure-report-publishergenerated test report!e2e-test-on-gdk:
expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Create | 8 | 0 | 1 | 5 | 9 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 4 | 0 | 0 | 4 | 4 | ❗ | | Monitor | 4 | 0 | 0 | 4 | 4 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 13 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+e2e-review-qa:
expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 1 | 9 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+Edited by Ghost Userremoved review request for @annabeldunstone
@arfedoro, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
Resolved by Brett WalkerJust out of curiosity, is there an issue open to make the dropdown identical between the two editors?
- Last reply by Brett Walker
requested review from @annabeldunstone
removed review request for @annabeldunstone
added 211 commits
-
3e848f85...b047402d - 210 commits from branch
master - 0a362e50 - Atwho styling update
-
3e848f85...b047402d - 210 commits from branch
