Skip to content

Remove `approval_rules` feature flag and remove obsolete approvals implementation

Mark Chao requested to merge 10685-remove-feature-flag into master

There is a CE port https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28979

What does this MR do?

The new approval rule system is stable now, we want to remove the legacy approver implementation code.

Functionality-wise the new system is a superset of the old implementation, so it is safe to remove.

Remove approval_rules feature flag and remove obsolete approvals implementation

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Closes #10685 (closed)

Edited by Mark Chao

Merge request reports