Skip to content

Show Not Found page if admin/group integration does not exist

Peter Leitzen requested to merge pl-edit-integrations-404 into master

What does this MR do and why?

Show Not Found page if admin/group integration does not exist

Now, return 404 Not Found if an integration for admin or group does not exist when:

  • Editing
  • Updating
  • Testing

Previously, we failed with 500 Internal Server Error in those cases.

Closes #413139 (closed).

Screenshots or screen recordings

Before After
http://localhost:3000/admin/application_settings/integrations/foo/edit Screenshot_from_2023-05-26_13-42-12 Screenshot_from_2023-05-26_13-51-28
http://localhost:3000/groups/gitlab-org/-/settings/integrations/foo/edit Screenshot_from_2023-05-26_13-42-02 Screenshot_from_2023-05-26_13-51-22

How to set up and validate locally

  1. Go to http://localhost:3000/admin/application_settings/integrations/foo/edit
  2. Go to http://localhost:3000/groups/gitlab-org/-/settings/integrations/foo/edit

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports