Show Not Found page if admin/group integration does not exist
What does this MR do and why?
Show Not Found page if admin/group integration does not exist
Now, return 404 Not Found
if an integration for admin or group does
not exist when:
- Editing
- Updating
- Testing
Previously, we failed with 500 Internal Server Error
in those cases.
Closes #413139 (closed).
Screenshots or screen recordings
Before | After | |
---|---|---|
http://localhost:3000/admin/application_settings/integrations/foo/edit | ||
http://localhost:3000/groups/gitlab-org/-/settings/integrations/foo/edit |
How to set up and validate locally
- Go to http://localhost:3000/admin/application_settings/integrations/foo/edit
- Go to http://localhost:3000/groups/gitlab-org/-/settings/integrations/foo/edit
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Peter Leitzen