Editing non-existent admin/group integrations results in 500 Internal Server Error
https://sentry.gitlab.net/gitlab/gitlabcom/issues/4105098/?referrer=gitlab_plugin
NoMethodError: undefined method `type' for nil:NilClass
app/controllers/groups/settings/integrations_controller.rb:19:in `edit'
@default_integration = Integration.default_integration(integration.type, group)
app/controllers/application_controller.rb:500:in `set_current_admin'
return yield unless Gitlab::CurrentSettings.admin_mode
lib/gitlab/session.rb:11:in `with_session'
yield
app/controllers/application_controller.rb:491:in `set_session_storage'
Gitlab::Session.with_session(session, &block)
lib/gitlab/i18n.rb:107:in `with_locale'
yield
...
(157 additional frame(s) were not displayed)
Reproduction
Group
- To https://gitlab.com/groups/GROUP_NAME/-/settings/integrations/foo/edit
- See
500 Internal Server
💥
Admin
- To https://gitlab.com/admin/application_settings/integrations/foo/edit
- See
500 Internal Server
💥
Refs
First spotted in spec failures
Edited by Peter Leitzen