Skip to content
Snippets Groups Projects

Geo: Add DesignManagementRegistry to RegistrableType

What does this MR do and why?

This MR:

  • Adds DesignManagementRegistry to the RegistrableType class to allow this registry to resync/reverify via GraphQL.
  • Updates the Geo issue_templates for Geo blob and repository replication to reflect this step.
  • Introduces a minor refactor to the integration test for GeoRegistriesMutation to test every replicable against the GraphQL API.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #412737 (closed)

Edited by Javiera Tapia

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Javiera Tapia changed milestone to %16.1

    changed milestone to %16.1

  • assigned to @jtapiab

  • removed twfinished label

  • Javiera Tapia added 2 commits

    added 2 commits

    • 9ce0bc40 - Add DesignManagementRegistry to registrable_type.rb
    • 3ee2f5fd - Add resync/reverify mandatory steps to Geo templates

    Compare with previous version

  • removed frontend label

  • Javiera Tapia marked this merge request as ready

    marked this merge request as ready

  • Javiera Tapia changed title from Draft: Resolve "Geo: Add DesignManagementRegistry to RegistrableType" to Geo: Add DesignManagementRegistry to RegistrableType

    changed title from Draft: Resolve "Geo: Add DesignManagementRegistry to RegistrableType" to Geo: Add DesignManagementRegistry to RegistrableType

  • A deleted user added documentation label

    added documentation label

  • 1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Madelein van Niekerk current availability (@maddievn) (UTC+2, 6 hours ahead of @jtapiab) Stan Hu current availability (@stanhu) (UTC-7, 3 hours behind @jtapiab)
    frontend Artur Fedorov current availability (@arfedoro) (UTC+2, 6 hours ahead of @jtapiab) Ezekiel Kigbo current availability (@ekigbo) (UTC+10, 14 hours ahead of @jtapiab)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
  • Javiera Tapia marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for ba0d27c0

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 21     | 0      | 2       | 1     | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-review-qa: :exclamation: test report for ba0d27c0

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Govern           | 2      | 0      | 0       | 1     | 2     | ❗     |
    | Plan             | 3      | 0      | 1       | 2     | 4     | ❗     |
    | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 20     | 0      | 3       | 4     | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :exclamation: test report for ba0d27c0

    expand test summary
    +--------------------------------------------------------------+
    |                        suites summary                        |
    +---------+--------+--------+---------+-------+-------+--------+
    |         | passed | failed | skipped | flaky | total | result |
    +---------+--------+--------+---------+-------+-------+--------+
    | Systems | 19     | 0      | 0       | 8     | 19    | ❗     |
    +---------+--------+--------+---------+-------+-------+--------+
    | Total   | 19     | 0      | 0       | 8     | 19    | ❗     |
    +---------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test-old-nav: :white_check_mark: test report for ba0d27c0

    expand test summary
    +--------------------------------------------------------------+
    |                        suites summary                        |
    +---------+--------+--------+---------+-------+-------+--------+
    |         | passed | failed | skipped | flaky | total | result |
    +---------+--------+--------+---------+-------+-------+--------+
    | Systems | 19     | 0      | 0       | 0     | 19    | ✅     |
    +---------+--------+--------+---------+-------+-------+--------+
    | Total   | 19     | 0      | 0       | 0     | 19    | ✅     |
    +---------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test-ce: :white_check_mark: test report for ba0d27c0

    expand test summary
    +--------------------------------------------------------------+
    |                        suites summary                        |
    +---------+--------+--------+---------+-------+-------+--------+
    |         | passed | failed | skipped | flaky | total | result |
    +---------+--------+--------+---------+-------+-------+--------+
    | Systems | 2      | 0      | 0       | 0     | 2     | ✅     |
    +---------+--------+--------+---------+-------+-------+--------+
    | Total   | 2      | 0      | 0       | 0     | 2     | ✅     |
    +---------+--------+--------+---------+-------+-------+--------+
    Edited by Ghost User
  • Javiera Tapia added 2 commits

    added 2 commits

    • eb0224b0 - Add DesignManagementRegistry to registrable_type.rb
    • c40c9df2 - Add resync/reverify mandatory steps to Geo templates

    Compare with previous version

  • Javiera Tapia mentioned in commit 57a97131

    mentioned in commit 57a97131

  • Javiera Tapia added 1 commit

    added 1 commit

    • 57a97131 - Add DesignManagementRegistry to registrable_type.rb

    Compare with previous version

  • A deleted user added frontend label

    added frontend label

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 54677ffa and ba0d27c0

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.13 MB 4.13 MB - 0.0 %
    mainChunk 2.97 MB 2.97 MB - 0.0 %

    Note: We do not have exact data for 54677ffa. So we have used data from: e3165f87.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading