Geo: Add DesignManagementRegistry to RegistrableType
What does this MR do and why?
This MR:
- Adds
DesignManagementRegistry
to theRegistrableType
class to allow this registry to resync/reverify via GraphQL. - Updates the Geo
issue_templates
for Geo blob and repository replication to reflect this step. - Introduces a minor refactor to the integration test for
GeoRegistriesMutation
to test every replicable against the GraphQL API.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #412737 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @jtapiab
removed twfinished label
removed Technical Writing label
removed documentation label
removed Geo Administration label
removed frontend label
- A deleted user
added documentation label
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/graphql/reference/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Madelein van Niekerk (
@maddievn
) (UTC+2, 6 hours ahead of@jtapiab
)Stan Hu (
@stanhu
) (UTC-7, 3 hours behind@jtapiab
)frontend Artur Fedorov (
@arfedoro
) (UTC+2, 6 hours ahead of@jtapiab
)Ezekiel Kigbo (
@ekigbo
) (UTC+10, 14 hours ahead of@jtapiab
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for ba0d27c0expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for ba0d27c0expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 1 | 2 | ❗ | | Plan | 3 | 0 | 1 | 2 | 4 | ❗ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 4 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for ba0d27c0expand test summary
+--------------------------------------------------------------+ | suites summary | +---------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +---------+--------+--------+---------+-------+-------+--------+ | Systems | 19 | 0 | 0 | 8 | 19 | ❗ | +---------+--------+--------+---------+-------+-------+--------+ | Total | 19 | 0 | 0 | 8 | 19 | ❗ | +---------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test-old-nav:
test report for ba0d27c0expand test summary
+--------------------------------------------------------------+ | suites summary | +---------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +---------+--------+--------+---------+-------+-------+--------+ | Systems | 19 | 0 | 0 | 0 | 19 | ✅ | +---------+--------+--------+---------+-------+-------+--------+ | Total | 19 | 0 | 0 | 0 | 19 | ✅ | +---------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test-ce:
test report for ba0d27c0expand test summary
+--------------------------------------------------------------+ | suites summary | +---------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +---------+--------+--------+---------+-------+-------+--------+ | Systems | 2 | 0 | 0 | 0 | 2 | ✅ | +---------+--------+--------+---------+-------+-------+--------+ | Total | 2 | 0 | 0 | 0 | 2 | ✅ | +---------+--------+--------+---------+-------+-------+--------+
mentioned in commit 57a97131
added 1 commit
- 57a97131 - Add DesignManagementRegistry to registrable_type.rb
- A deleted user
added frontend label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 54677ffa and ba0d27c0
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.13 MB 4.13 MB - 0.0 % mainChunk 2.97 MB 2.97 MB - 0.0 %
Note: We do not have exact data for 54677ffa. So we have used data from: e3165f87.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in commit 5077ad43
mentioned in commit 0c5ad216
requested review from @axil
- Resolved by Javiera Tapia
@axil
Could you review this small doc change atdoc/api/graphql/reference/index.md
?
requested review from @vsizov
added workflowin review label and removed workflowin dev label
@axil
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
Hi
@axil
,GitLab Bot has added the Technical Writing label because a Technical Writer has approved or merged this MR.
This message was generated automatically. You're welcome to improve it.
added Technical Writing label
removed review request for @axil
- Resolved by Michael Kozono
I restarted CI because I see too many failures that don't seem related.
mentioned in commit ba0d27c0
added 336 commits
-
0c5ad216...c126a9e4 - 334 commits from branch
master
- 8d98ddbb - Add resync/reverify mandatory steps to Geo templates
- ba0d27c0 - Add DesignManagementRegistry to registrable_type.rb
-
0c5ad216...c126a9e4 - 334 commits from branch
requested review from @mkozono
- Resolved by Michael Kozono
- Resolved by Javiera Tapia
- Resolved by Michael Kozono
- Resolved by Michael Kozono
For transparency, I know Danger asks for frontend review but I don't think one is needed to block this.
cc @zcuddy in case I am wrong
enabled an automatic merge when the pipeline for 3875bb97 succeeds
mentioned in commit c3052838
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #412737 (closed)
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue #414370 (closed)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
mentioned in merge request !125468 (merged)