Change work item add note permission to `createNote`
What does this MR do and why?
The MR uses a different permission createNote
than updateWorkItem
to check if the user has a permission to create note in work items.
Can only be merged in 16.2 due to multiversion compatibility , since the backend MR is merged in 16.1
Details here in this thread
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Make sure you are logged in as a guest user to a project or you can impersonate any user who is not a part of a project
To impersonate a user
- Go to admin area
- Go to users
- Click on any user who has access to no group/project or create a new one ( which will automatically not be invited to any project/group)
- impersonate the user
- Visit any work item -> task/objective/key result
- See that you are able to write a comment to any work item
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #412340 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @deepika.guliani
requested review from @ramistry
- Resolved by Deepika Guliani
@ramistry Can you please review this MR ?
mentioned in issue #412340 (closed)
- A deleted user
added frontend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Ross Byrne (
@robyrne
) (UTC+1, 4.5 hours behind@deepika.guliani
)Jannik Lehmann (
@jannik_lehmann
) (UTC+2, 3.5 hours behind@deepika.guliani
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 247a52d5 and 9235b144
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.12 MB 4.12 MB - 0.0 % mainChunk 3 MB 3 MB - 0.0 %
Note: We do not have exact data for 247a52d5. So we have used data from: 7af05491.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 9235b144expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-gdk:
test report for 9235b144expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 4 | 0 | 0 | 3 | 4 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 8 | 0 | 1 | 6 | 9 | ❗ | | Monitor | 4 | 0 | 0 | 4 | 4 | ❗ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 14 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 9235b144expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 318 | 0 | 3 | 0 | 321 | ✅ | | Release | 24 | 0 | 0 | 0 | 24 | ✅ | | Verify | 196 | 0 | 20 | 4 | 216 | ❗ | | Configure | 1 | 0 | 12 | 0 | 13 | ✅ | | Data Stores | 151 | 0 | 3 | 0 | 154 | ✅ | | Package | 233 | 0 | 46 | 198 | 279 | ❗ | | Create | 686 | 2 | 112 | 5 | 800 | ❌ | | Manage | 175 | 17 | 14 | 26 | 206 | ❌ | | Govern | 196 | 1 | 8 | 4 | 205 | ❌ | | Fulfillment | 10 | 0 | 100 | 0 | 110 | ✅ | | Secure | 8 | 0 | 36 | 0 | 44 | ✅ | | Analytics | 9 | 0 | 0 | 0 | 9 | ✅ | | Monitor | 44 | 0 | 9 | 0 | 53 | ✅ | | Systems | 2 | 0 | 0 | 0 | 2 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | ModelOps | 0 | 0 | 4 | 0 | 4 | ➖ | | Framework sanity | 0 | 0 | 6 | 0 | 6 | ➖ | | Growth | 0 | 0 | 8 | 0 | 8 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2055 | 20 | 382 | 237 | 2457 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
removed review request for @ramistry
added 215 commits
-
0e576d82...77303b21 - 214 commits from branch
master
- fa2a9a46 - Change work item add note permission to `readWorkItem`
-
0e576d82...77303b21 - 214 commits from branch
added 1 commit
- 2f84a7c4 - Change work item add note permission to `createNote`
requested review from @ramistry
@ramistry
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @ramistry
requested review from @fguibert
changed milestone to %16.2
added 2657 commits
-
2f84a7c4...3ae8bf3a - 2656 commits from branch
master
- 5ad4fb3e - Change work item add note permission to `createNote`
-
2f84a7c4...3ae8bf3a - 2656 commits from branch
added 1700 commits
-
5ad4fb3e...4e8c9c91 - 1699 commits from branch
master
- 9235b144 - Change work item add note permission to `createNote`
-
5ad4fb3e...4e8c9c91 - 1699 commits from branch
@deepika.guliani Some end-to-end (E2E) tests have been selected based on the stage label on this MR. If not run already, please run thee2e:package-and-test-ee
job in theqa
stage and review the results before merging this MR. (E2E tests are not run automatically on some MRs due to runner resource constraints.)If you would like to run all e2e tests, please apply the pipeline:run-all-e2e label and restart the pipeline.
Once done, please apply the
emoji on this comment.For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.
added pipeline:run-all-e2e label
requested review from @cngo
enabled an automatic merge when the pipeline for 3821bb76 succeeds
mentioned in commit 58c15284
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)