Change work item add note permission to `createNote`
Merged
requested to merge 412340-guest-project-members-are-not-allowed-to-create-notes-on-work-items-2 into master
What does this MR do and why?
The MR uses a different permission createNote
than updateWorkItem
to check if the user has a permission to create note in work items.
Can only be merged in 16.2 due to multiversion compatibility , since the backend MR is merged in 16.1
Details here in this thread
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Make sure you are logged in as a guest user to a project or you can impersonate any user who is not a part of a project
To impersonate a user
- Go to admin area
- Go to users
- Click on any user who has access to no group/project or create a new one ( which will automatically not be invited to any project/group)
- impersonate the user
- Visit any work item -> task/objective/key result
- See that you are able to write a comment to any work item
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #412340 (closed)
Edited by Deepika Guliani
Merge request reports
Activity
Please register or sign in to reply