Remove the auto_merge_labels_mr_widget feature flag
What does this MR do and why?
Remove the auto_merge_labels_mr_widget feature flag
This changes the Merge button text depending on the merge strategy to "Set to auto-merge"
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.1
assigned to @jivanvl
changed milestone to %16.0
- A deleted user
added backend documentation labels
2 Warnings This merge request is quite big (752 lines changed), please consider splitting it into multiple merge requests. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Smriti Garg (
@sgarg_gitlab
) (UTC+5.5, 11.5 hours ahead of@jivanvl
)Roy Zwambag (
@rzwambag
) (UTC+2, 8 hours ahead of@jivanvl
)frontend Sharmad Nachnolkar (
@snachnolkar
) (UTC+5.5, 11.5 hours ahead of@jivanvl
)Andrew Fontaine (
@afontaine
) (UTC-4, 2 hours ahead of@jivanvl
)test for spec/features/*
Smriti Garg (
@sgarg_gitlab
) (UTC+5.5, 11.5 hours ahead of@jivanvl
)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 51 commits
-
6bd79263...08247f8c - 50 commits from branch
master
- d0ab10b8 - Remove the auto_merge_labels_mr_widget feature flag
-
6bd79263...08247f8c - 50 commits from branch
added featureenhancement label
added feature flagexists label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@9a871db7
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 1c475f59 and 80b4a341
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.13 MB 4.13 MB - 0.0 % mainChunk 2.99 MB 2.99 MB - 0.0 %
Note: We do not have exact data for 1c475f59. So we have used data from: 10864ffa.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 80b4a341expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 4 | 4 | ❗ | | Create | 8 | 0 | 1 | 6 | 9 | ❗ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 4 | 0 | 0 | 3 | 4 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 14 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 80b4a341expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 30 | 0 | 3 | 1 | 33 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 80b4a341expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 151 | 0 | 19 | 2 | 170 | ❗ | | Verify | 245 | 0 | 25 | 5 | 270 | ❗ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 422 | 0 | 46 | 7 | 468 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- 6b54b3ec - Remove the auto_merge_labels_mr_widget feature flag
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@03d48ae8
changed milestone to %16.1
added missed:16.0 label
mentioned in issue #359057 (closed)
added 741 commits
-
6b54b3ec...205250e4 - 740 commits from branch
master
- 5314a733 - Remove the auto_merge_labels_mr_widget feature flag
-
6b54b3ec...205250e4 - 740 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@d53a5e88
added 4408 commits
-
5314a733...48feef0e - 4407 commits from branch
master
- 40c22f75 - Remove the auto_merge_labels_mr_widget feature flag
-
5314a733...48feef0e - 4407 commits from branch
added sectionci label and removed sectionops label
@jivanvl Some end-to-end (E2E) tests have been selected based on the stage label on this MR. If not run already, please run thee2e:package-and-test-ee
job in theqa
stage and review the results before merging this MR. (E2E tests are not run automatically on some MRs due to runner resource constraints.)If you would like to run all e2e tests, please apply the pipeline:run-all-e2e label and restart the pipeline.
Once done, please apply the
emoji on this comment.For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@d4f5247c
changed milestone to %16.2
- Resolved by Paul Gascou-Vaillancourt
- Resolved by Paul Gascou-Vaillancourt
- Resolved by Tiffany Rea
@treagitlab Can you please take a look at this feature flag removal tests? Thanks!
@f_caplette, Can you please take a look at this feature flag removal? Feel free to send this to another maintainer since I couldn't find any reviewers available
requested review from @treagitlab and @f_caplette
@f_caplette
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @f_caplette
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@fa00bc5f
- Resolved by Tiffany Rea
added 413 commits
-
40c22f75...64d26ed9 - 411 commits from branch
master
- 598a61f0 - Remove the auto_merge_labels_mr_widget feature flag
- 80b4a341 - Change data-qa-selector to use data-testid instead
-
40c22f75...64d26ed9 - 411 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@8ff925f7
- Resolved by Paul Gascou-Vaillancourt
@pgascouvaillancourt, Can you please do the maintainer review on this MR? Thanks!
requested review from @pgascouvaillancourt
enabled an automatic merge when the pipeline for c11a17ef succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c11a17ef
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@22a85b78
mentioned in commit a7640d30
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2281 (merged)