Remove puma worker killer

What does this MR do and why?

Removes puma-worker-killer

We are using backward-compatible Watchdog by default for several releases. This is just a cleanup

Please note that we have are initializing PumaWorkerKiller in puma.rb templates used by omnibus and CNG, So I created 2 separate MR to clean this first:

• omnibus-gitlab!6845 (merged)
• gitlab-org/build/CNG!1380 (merged)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #379199 (closed)

changed milestone to %16.0

added cloud connectoractive devopsdata stores groupcloud connector maintenanceremoval sectioncore platform typemaintenance workflowready for development labels

assigned to @nmilojevic1

added 1 commit

• 556f64e6 - Remove puma worker killer

Compare with previous version

added backend label

	1 Error
🚫	The merge request title must not end with a period. For more information, take a look at our Commit message guidelines.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Minahil Nichols (@minahilnichols) (UTC-4, 6 hours behind @nmilojevic1)	Jan Provaznik (@jprovaznik) (UTC+2, same timezone as @nmilojevic1)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Rubygems

This merge request adds, or changes a Rubygems dependency. Please review the Gemfile guidelines.

If needed, you can retry the 🔁 danger-review job that generated this comment.

Generated by 🚫 Danger

added 49 commits

• 556f64e6...ed34bda9 - 47 commits from branch master
• 4b8b654f - Remove puma worker killer
• e10dc7c6 - Fix Gemfile.lock

Compare with previous version

added 1 commit

• cad8dc0d - Update Gemfile.checksum

Compare with previous version

added 1 commit

• d656dd56 - Remove puma-worker-killer

Compare with previous version

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Alex Buijs (@alexbuijs) (UTC+2, same timezone as @nmilojevic1)	Patrick Bajao (@patrickbajao) (UTC+8, 6 hours ahead of @nmilojevic1)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Rubygems

This merge request adds, or changes a Rubygems dependency. Please review the Gemfile guidelines.

If needed, you can retry the 🔁 danger-review job that generated this comment.

Generated by 🚫 Danger

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: ✅ test report for 8ef0e7b5

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
| Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
| Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
| Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 21     | 0      | 2       | 0     | 23    | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-review-qa: ✅ test report for 8ef0e7b5

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Plan             | 50     | 0      | 1       | 0     | 51    | ✅     |
| Govern           | 24     | 0      | 0       | 0     | 24    | ✅     |
| Manage           | 8      | 0      | 3       | 0     | 11    | ✅     |
| Create           | 27     | 0      | 1       | 0     | 28    | ✅     |
| Verify           | 10     | 0      | 0       | 0     | 10    | ✅     |
| Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 154    | 0      | 7       | 0     | 161   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: ❌ test report for 8ef0e7b5

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Plan             | 310    | 0      | 2       | 0     | 312   | ✅     |
| Package          | 144    | 0      | 38      | 0     | 182   | ✅     |
| Create           | 542    | 4      | 90      | 0     | 636   | ❌     |
| Data Stores      | 150    | 1      | 3       | 0     | 154   | ❌     |
| Govern           | 189    | 0      | 0       | 0     | 189   | ✅     |
| Fulfillment      | 10     | 0      | 100     | 0     | 110   | ✅     |
| Configure        | 1      | 0      | 12      | 0     | 13    | ✅     |
| Verify           | 212    | 0      | 16      | 0     | 228   | ✅     |
| Framework sanity | 0      | 0      | 6       | 0     | 6     | ➖     |
| Manage           | 191    | 0      | 10      | 0     | 201   | ✅     |
| Release          | 24     | 0      | 0       | 0     | 24    | ✅     |
| Monitor          | 44     | 0      | 9       | 0     | 53    | ✅     |
| Systems          | 2      | 0      | 0       | 0     | 2     | ✅     |
| Analytics        | 9      | 0      | 0       | 0     | 9     | ✅     |
| ModelOps         | 0      | 0      | 4       | 0     | 4     | ➖     |
| Secure           | 8      | 0      | 36      | 0     | 44    | ✅     |
| GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
| Growth           | 0      | 0      | 8       | 0     | 8     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 1838   | 5      | 335     | 0     | 2178  | ❌     |
+------------------+--------+--------+---------+-------+-------+--------+

@minahilnichols can you please do the initial review?

changed the description

requested review from @minahilnichols

added 1 commit

• 8ef0e7b5 - Remove puma worker killer

Compare with previous version

changed title from Remove puma worker killer. to Remove puma worker killer

requested review from @cablett

approved this merge request

👋 @minahilnichols, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

• rspec predictive jobs
• jest predictive jobs
• merging a merge request.

added pipeline:mr-approved label