Remove puma_worker_killer

What does this MR do?

In gitlab#379199 (closed), we are removing legacy implementation for PumaWorkerKiller, which is now replaced with the Watchdog.

This MR is removing `PumaWorkerKiller' initialization from our puma configuration template

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

• MR title and description are up to date, accurate, and descriptive.
• MR targeting the appropriate branch.
• Latest Merge Result pipeline is green.
• When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

• The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
• If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
• If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
• If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

• Test plan indicating conditions for success has been posted and passes.
• Documentation created/updated.
• Tests added.
• Integration tests added to GitLab QA.
• Equivalent MR/issue for the GitLab Chart opened.
• Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

changed milestone to %16.0

added devopssystems groupcloud connector maintenanceremoval sectioncore platform typemaintenance labels

assigned to @nmilojevic1

added devopsdata stores label and removed devopssystems label

	2 Warnings
	The merge request title must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	670b7439: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.

	2 Messages
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
	Please add the workflowready for review label once you think the MR is ready to for an initial review. Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO. If you don't receive a response, please mention @gitlab-org/distribution, or one of our Project Maintainers

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

marked the checklist item MR title and description are up to date, accurate, and descriptive. as completed

marked the checklist item MR targeting the appropriate branch. as completed

marked the checklist item Latest Merge Result pipeline is green. as completed

marked the checklist item When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow. as completed

added workflowready for review label

marked the checklist item The manual Trigger:ee-package jobs have a green pipeline running against latest commit. as completed

requested review from @pursultani

added workflowin review label and removed workflowready for review label

This looks fine.

The only problem is that we do expose puma['per_worker_max_memory_mb'] configuration option for PWK which must be deprecated given it doesn't do anything. Please check development to how to remove and deprecate an option:

• https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/6abcc78b3990bdeecd1d5e7ff2261780709aafeb/doc/development/add-remove-configuration-options.md#deprecate-the-option
• https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/6abcc78b3990bdeecd1d5e7ff2261780709aafeb/doc/development/adding-deprecation-messages.md

There is also per_worker_max_memory_mb property in puma_config Chef resource that should be removed.

(if you do a search with per_worker_max_memory_mb you can highlight other items that needs to be deleted).

resolved all threads

approved this merge request

LGTM. Approving and passing to @balasankarc for maintainer review.

requested review from @balasankarc

approved this merge request

merged

mentioned in commit a9c14f6c

added workflowstaging-canary label and removed workflowin review label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

mentioned in merge request gitlab!118645 (merged)

added releasedcandidate label

mentioned in merge request !6891 (merged)

added releasedpublished label and removed releasedcandidate label