Skip to content
Snippets Groups Projects

GH-style Jira DVCS endpoints return 404 by default

All threads resolved!

What does this MR do and why?

This MR makes all endpoints involved in the deprecated "GitHub-style" method of integrating with the Jira DVCS now return 404 by default.

The endpoints in API::v3::GitHub have been deprecated since 15.1.

Due to uncertainty about the impact of a full removal in 16.0, all endpoints return 404 by default but we allow customers to toggle a flag to reverse this breaking change.

See #362168 (comment 1347692683).

In future, we will make the breaking change irreversible #408148 (closed).

We can make a breaking change to /api/v3 endpoints - even though normal api/v4 endpoints cannot be removed in %16.0 - as the v3 endpoints are only used by Jira and are not part of our public API.

Documentation has already removed references to the GitHub Enterprise-style of the DVCS integration in !117581 (merged).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #362168 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Contributor
    1 Warning
    :warning: This MR changes code in ee/, but its Changelog commit is missing the EE: true trailer. Consider adding it to your Changelog commits.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Sylvester Chin current availability (@schin1) (UTC+8, 4 hours behind @.luke) Heinrich Lee Yu current availability (@engwan) (UTC+8, 4 hours behind @.luke)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Luke Duncalfe added 1 commit

    added 1 commit

    • 60e61e19 - GH-style Jira DVCS endpoints return 404 by default

    Compare with previous version

  • Luke Duncalfe
  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-package-and-test: :exclamation: test report for ed817ac7

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Verify           | 108    | 0      | 8       | 90    | 116   | ❗     |
    | Manage           | 66     | 0      | 6       | 30    | 72    | ❗     |
    | Monitor          | 20     | 0      | 0       | 20    | 20    | ❗     |
    | Create           | 292    | 0      | 42      | 60    | 334   | ❗     |
    | Plan             | 120    | 0      | 0       | 64    | 120   | ❗     |
    | Data Stores      | 68     | 0      | 0       | 22    | 68    | ❗     |
    | Govern           | 92     | 0      | 0       | 92    | 92    | ❗     |
    | Package          | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Analytics        | 4      | 0      | 0       | 4     | 4     | ❗     |
    | Secure           | 14     | 0      | 10      | 14    | 24    | ❗     |
    | Configure        | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Fulfillment      | 4      | 0      | 44      | 0     | 48    | ✅     |
    | Release          | 12     | 0      | 0       | 8     | 12    | ❗     |
    | Growth           | 0      | 0      | 4       | 0     | 4     | ➖     |
    | ModelOps         | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Framework sanity | 0      | 0      | 2       | 0     | 2     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 800    | 0      | 130     | 404   | 930   | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Luke Duncalfe added 1 commit

    added 1 commit

    • 73b46b6c - GH-style Jira DVCS endpoints return 404 by default

    Compare with previous version

  • Luke Duncalfe added 1 commit

    added 1 commit

    • 6fbf8b16 - GH-style Jira DVCS endpoints return 404 by default

    Compare with previous version

  • Luke Duncalfe requested review from @Andysoiron

    requested review from @Andysoiron

  • mentioned in issue #408148 (closed)

  • Luke Duncalfe added 1 commit

    added 1 commit

    • ed817ac7 - GH-style Jira DVCS endpoints return 404 by default

    Compare with previous version

  • Luke Duncalfe
  • Andy Schoenen removed review request for @Andysoiron

    removed review request for @Andysoiron

  • Luke Duncalfe added 1 commit

    added 1 commit

    • 4ff8bd19 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Contributor
    1 Warning
    :warning: This MR changes code in ee/, but its Changelog commit is missing the EE: true trailer. Consider adding it to your Changelog commits.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Tianwen Chen current availability (@tianwenchen) (UTC+10, 2 hours behind @.luke) Heinrich Lee Yu current availability (@engwan) (UTC+8, 4 hours behind @.luke)
    ~"group::integrations" (backend) No engineer is available for automated assignment, please reach out to the #g_manage_integrations Slack channel or mention @gitlab-org/manage/integrations for assistance. Maintainer review is optional for ~"group::integrations" (backend)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Luke Duncalfe requested review from @Andysoiron

    requested review from @Andysoiron

  • Luke Duncalfe added 1912 commits

    added 1912 commits

    Compare with previous version

  • Andy Schoenen approved this merge request

    approved this merge request

  • :wave: @Andysoiron, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Andy Schoenen requested review from @engwan

    requested review from @engwan

  • Heinrich Lee Yu approved this merge request

    approved this merge request

  • Heinrich Lee Yu resolved all threads

    resolved all threads

  • Heinrich Lee Yu enabled an automatic merge when the pipeline for 212fe5f6 succeeds

    enabled an automatic merge when the pipeline for 212fe5f6 succeeds

  • Heinrich Lee Yu mentioned in commit 4337ebfe

    mentioned in commit 4337ebfe

  • added workflowstaging label and removed workflowcanary label

  • Luke Duncalfe mentioned in merge request !119575 (merged)

    mentioned in merge request !119575 (merged)

  • Luke Duncalfe mentioned in commit f314647d

    mentioned in commit f314647d

  • Luke Duncalfe mentioned in commit 83a6c268

    mentioned in commit 83a6c268

  • Luke Duncalfe mentioned in commit d920dcaf

    mentioned in commit d920dcaf

  • mentioned in merge request !119889 (merged)

  • Ashraf Khamis mentioned in merge request !119947 (merged)

    mentioned in merge request !119947 (merged)

  • Luke Duncalfe mentioned in commit a7ea014b

    mentioned in commit a7ea014b

  • Luke Duncalfe mentioned in merge request !120051 (merged)

    mentioned in merge request !120051 (merged)

  • mentioned in issue #396424 (closed)

  • Please register or sign in to reply
    Loading