GH-style Jira DVCS endpoints return 404 by default
What does this MR do and why?
This MR makes all endpoints involved in the deprecated "GitHub-style" method of integrating with the Jira DVCS now return 404 by default.
The endpoints in API::v3::GitHub have been deprecated since 15.1.
Due to uncertainty about the impact of a full removal in 16.0, all
endpoints return 404 by default but we allow customers to toggle a
flag to reverse this breaking change.
See #362168 (comment 1347692683).
In future, we will make the breaking change irreversible #408148 (closed).
We can make a breaking change to /api/v3 endpoints - even though normal api/v4 endpoints cannot be removed in %16.0 - as the v3 endpoints are only used by Jira and are not part of our public API.
Documentation has already removed references to the GitHub Enterprise-style of the DVCS integration in !117581 (merged).
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #362168 (closed)
Merge request reports
Activity
changed milestone to %16.0
assigned to @.luke
Resolved by Heinrich Lee Yu@.luke thanks for adding the breaking change label!
This merge request introduces breaking changes. Learn more about breaking changes.
It's important to identify how the breaking change was introduced. To estimate the impact, try to assess the following:
- Are there existing users depending on this feature?
- Are self-managed customers affected?
- To verify and quantify usage, use Grafana or Kibana.
- If you're not sure about how to query the data, contact the infrastructure team on their Slack channel, #infrastructure-lounge
- Was sufficient time given to communicate the change?
- Changes in the permissions, the API schema, and the API response might affect existing 3rd party integrations.
- Reach out to the Support team or Technical Account Managers and ask about the possible impact of this change.
This message was generated automatically. You're welcome to improve it.
- Are there existing users depending on this feature?
- Last reply by Luke Duncalfe
removed Technical Writing milestonep1 labels
removed documentation label
- A deleted user
added backend feature flag labels
1 Warning ⚠ This MR changes code in ee/, but its Changelog commit is missing theEE: truetrailer. Consider adding it to your Changelog commits.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sylvester Chin (
@schin1) (UTC+8, 4 hours behind@.luke)Heinrich Lee Yu (
@engwan) (UTC+8, 4 hours behind@.luke)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-reviewjob that generated this comment.Generated by
🚫 DangerEdited by Ghost Useradded 1 commit
- 60e61e19 - GH-style Jira DVCS endpoints return 404 by default
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@cbe6d115
Allure report
allure-report-publishergenerated test report!e2e-package-and-test:
❗ test report for ed817ac7expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 108 | 0 | 8 | 90 | 116 | ❗ | | Manage | 66 | 0 | 6 | 30 | 72 | ❗ | | Monitor | 20 | 0 | 0 | 20 | 20 | ❗ | | Create | 292 | 0 | 42 | 60 | 334 | ❗ | | Plan | 120 | 0 | 0 | 64 | 120 | ❗ | | Data Stores | 68 | 0 | 0 | 22 | 68 | ❗ | | Govern | 92 | 0 | 0 | 92 | 92 | ❗ | | Package | 0 | 0 | 6 | 0 | 6 | ➖ | | Analytics | 4 | 0 | 0 | 4 | 4 | ❗ | | Secure | 14 | 0 | 10 | 14 | 24 | ❗ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Fulfillment | 4 | 0 | 44 | 0 | 48 | ✅ | | Release | 12 | 0 | 0 | 8 | 12 | ❗ | | Growth | 0 | 0 | 4 | 0 | 4 | ➖ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 800 | 0 | 130 | 404 | 930 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+Edited by Ghost Useradded 1 commit
- 73b46b6c - GH-style Jira DVCS endpoints return 404 by default
added 1 commit
- 6fbf8b16 - GH-style Jira DVCS endpoints return 404 by default
- Resolved by Heinrich Lee Yu
Hi, @Andysoiron! I was hoping you could give this MR its first backend review because you have a lot of context behind this change.
In terms of the plan you outlined here #362168 (comment 1347692683), I think this is
3.. Would2.be a separate change to reject requests fromatlassian.netfrom inside ofOauth::JiraDvcs::AuthorizationsController?Thank you!
- Last reply by Heinrich Lee Yu
requested review from @Andysoiron
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c7eaec24
mentioned in issue #408148 (closed)
added 1 commit
- ed817ac7 - GH-style Jira DVCS endpoints return 404 by default
