Skip to content

Add skeleton loader to admin jobs vue

Andreas Deicha requested to merge gitlab-community/gitlab:skeletonloader_admin_jobs_vue into master

What does this MR do and why?

This is one step to refactor the jobs view for admins from haml to vue. We need to add a skeleton loader while jobs are loading.

This MR adds a skeleton loader to admin_job.table.app.vue view/component.

I have oriented myself towards the implementation in job_table_app.vue

Parent issue

FF

relevant issues for context are: #22626 (closed), #329224, and #262679 (closed).

🛠 with ❤ at Siemens

Screenshots or screen recordings

image

How to set up and validate locally

  • Make sure to enable FF Feature.enable(:admin_jobs_vue)
  • curl https://gitlab.com/TrueKalix/gitlab/-/raw/tempo/sekeltonloader_jobs.patch | git apply (makes graphql resolver sleep 20sec)
  • Go to Admin > CI/CD > Jobs

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Andreas Deicha

Merge request reports