Skip to content

Draft: Remove azure specific omniauth, omniauth_openid_connect is maintained and can do all the things

Roger Meier requested to merge gitlab-community/gitlab:refactor/remove-azure-oauth2 into master

What does this MR do and why?

A while ago we combined the power and the fork https://gitlab.com/gitlab-org/ruby/gems/gitlab-omniauth-openid-connect including all the features became part of omniauth_openid_connect gem, see also https://github.com/omniauth/omniauth_openid_connect/issues/101 , this works smooth for AzureAD and is properly maintained, thats why I suggest to completely remove the unmaintained omniauth gems and use omniauth_openid_connect only, I suggested that here: gitlab-org/ruby/gems/gitlab-omniauth-openid-connect#5 (comment 1263279527)

I know this is a bit radical but it improves security and maintainability. However, worth to consider for %16.0

Relates to: Remove azure specific vendored omniauth-azure-o... (#407398 - closed)

🛠 with ❤ at Siemens

Screenshots or screen recordings

not available

How to set up and validate locally

  1. Configure https://docs.gitlab.com/ee/integration/azure.html
  2. It will not work
  3. Configure https://docs.gitlab.com/ee/administration/auth/oidc.html#configure-microsoft-azure
  4. It will work

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Adil Farrukh

Merge request reports