Skip to content

Add columns to jobs table

Andreas Deicha requested to merge gitlab-community/gitlab:add_admin_cells_jobs_table into master

What does this MR do and why?

This is one step to refactor the jobs view for admins from haml to vue. This was already done for the jobs view of a certain project. My goal is to reuse as much as I can to minimize effort. Therefore I am using the same vue componente jobs_table.vue. The componente contains everything I need to reflect the current haml implementation besides two columns which are missing.

This MR adds column Project and Runner and a boolean admin to distinguish between the views Project > CI/CD > Jobs and Admin > CI/CD > Jobs.

Parent issue

FF

relevant issues for context are: #22626 (closed), #329224, and #262679 (closed).

🛠 with ❤ at Siemens

Screenshots or screen recordings

image

How to set up and validate locally

  • Make sure to enable FF Feature.enable(:admin_jobs_vue)
  • Go to Admin > CI/CD > Jobs
  • Compare it to Project > CI/CD > Jobs
  • Run test

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Andreas Deicha

Merge request reports