Add "reviewed but not approved" state in merge request sidebar

What does this MR do and why?

• Aligns all checkmarks and re-review buttons
• Adds explicit state "This has been reviewed but not approved yet"
• Removes success checkmark (appears when you click re-request review)

Screenshots or screen recordings

Before	After

How to set up and validate locally

Find an MR, or impersonate users to get to the following approval states:

• Approve
• Approve with review (submit an actual review and approve)
• Review without approval
• Assigned reviewer without approval or review

#394879 (closed)

changed milestone to %15.11

added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels

assigned to @annabeldunstone

Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.

This message was generated automatically. You're welcome to improve it.

marked this merge request as draft

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Deepika Guliani (@deepika.guliani) (UTC+5.5, 5.5 hours ahead of @annabeldunstone)	Anna Vovchenko (@anna_vovchenko) (UTC+3, 3 hours ahead of @annabeldunstone)
UX	Katie Macoy (@katiemacoy) (UTC+12, 12 hours ahead of @annabeldunstone)	Maintainer review is optional for UX

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the 🔁 danger-review job that generated this comment.

Generated by 🚫 Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 187b4032 and f08873ea

✨ Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.62 MB	3.62 MB	-	0.0 %
mainChunk	2.08 MB	2.08 MB	-	0.0 %

---

Note: We do not have exact data for 187b4032. So we have used data from: 802f83d8.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

---

Read more about how this report works.

Generated by 🚫 Danger

added 1 commit

• 7816f519 - Add reviewed but not approved state in MR sidebar

Compare with previous version

marked this merge request as ready

changed title from Draft: Move re-request review button to left of approval icon to Add "reviewed but not approved" state in merge request sidebar

changed the description

/cc @phikai @afracazo @mnearents for awareness

changed the description

added 1 commit

• 3bcb3f70 - Add reviewed but not approved state in MR sidebar

Compare with previous version

Allure report

allure-report-publisher generated test report!

e2e-review-qa: ✅ test report for f08873ea

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Govern           | 26     | 0      | 0       | 0     | 26    | ✅     |
| Manage           | 8      | 0      | 3       | 0     | 11    | ✅     |
| Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
| Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
| Plan             | 49     | 0      | 1       | 0     | 50    | ✅     |
| Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
| Verify           | 10     | 0      | 0       | 0     | 10    | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 156    | 0      | 7       | 0     | 163   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

added 1 commit

• 4bbe2495 - Add reviewed but not approved state in MR sidebar

Compare with previous version