Add "reviewed but not approved" state in merge request sidebar
What does this MR do and why?
- Aligns all checkmarks and re-review buttons
- Adds explicit state "This has been reviewed but not approved yet"
- Removes
success
checkmark (appears when you clickre-request review
)
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
How to set up and validate locally
Find an MR, or impersonate users to get to the following approval states:
- Approve
- Approve with review (submit an actual review and approve)
- Review without approval
- Assigned reviewer without approval or review
Merge request reports
Activity
changed milestone to %15.11
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Deepika Guliani (
@deepika.guliani
) (UTC+5.5, 5.5 hours ahead of@annabeldunstone
)Anna Vovchenko (
@anna_vovchenko
) (UTC+3, 3 hours ahead of@annabeldunstone
)UX Katie Macoy (
@katiemacoy
) (UTC+12, 12 hours ahead of@annabeldunstone
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 187b4032 and f08873ea
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.62 MB 3.62 MB - 0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 %
Note: We do not have exact data for 187b4032. So we have used data from: 802f83d8.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- 7816f519 - Add reviewed but not approved state in MR sidebar
- Resolved by Annabel Dunstone Gray
/cc @phikai @afracazo @mnearents for awareness
- Resolved by Amy Qualls
added 1 commit
- 3bcb3f70 - Add reviewed but not approved state in MR sidebar
- Resolved by Annabel Dunstone Gray
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for f08873eaexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 26 | 0 | 0 | 0 | 26 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 156 | 0 | 7 | 0 | 163 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- 4bbe2495 - Add reviewed but not approved state in MR sidebar
- Resolved by Annabel Dunstone Gray
@seggenberger Can you please review UX
@thomasrandolph As you're familiar with this area, could you please take a look at the specs I've likely made a mess of?
requested review from @seggenberger and @thomasrandolph
- Resolved by Annabel Dunstone Gray
removed review request for @seggenberger
requested review from @aqualls
added Technical Writing label
added UI text label
added Unplanned devopscreate groupcode review labels
added sectiondev label
added 262 commits
-
4bbe2495...30839bea - 261 commits from branch
master
- 548ae1a3 - Add reviewed but not approved state in MR sidebar
-
4bbe2495...30839bea - 261 commits from branch
requested review from @seggenberger
mentioned in issue #387070 (closed)
@aqualls
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
added tw-weight3 twfinished labels
removed review request for @aqualls
requested review from @aqualls
removed review request for @aqualls
added 106 commits
-
548ae1a3...a7f76f47 - 105 commits from branch
master
- c6d92820 - Add reviewed but not approved state in MR sidebar
-
548ae1a3...a7f76f47 - 105 commits from branch
removed review request for @thomasrandolph
requested review from @peterhegman
- Resolved by Annabel Dunstone Gray
- Resolved by Annabel Dunstone Gray
- Resolved by Peter Hegman
@annabeldunstone nice work on this, looks very solid! Just two minor comments for your consideration.
removed review request for @peterhegman
added 1 commit
- f08873ea - Add reviewed but not approved state in MR sidebar
requested review from @peterhegman
removed review request for @peterhegman
removed review request for @seggenberger
requested review from @peterhegman
enabled an automatic merge when the pipeline for b80ed5ec succeeds
mentioned in commit 3ba92be4
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in merge request !117228 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2061 (merged)