Update gitlab-mail_room to v0.0.23
What does this MR do and why?
This version is already used by GitLab Omnibus (omnibus-gitlab!6758 (merged)) and Cloud Native GitLab (gitlab-org/build/CNG!1335 (merged)), but we had to avoid updating this dependency in GitLab Rails due to the need to depend on an updated net-imap gem (https://docs.gitlab.com/ee/development/emails.html#rationale). Now that we've updated to Ruby 3.0.5, we can safely bump this version. This version bump is also needed for Ruby 3.1 compatibility.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @stanhu
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
changed milestone to %15.11
added maintenancedependency typemaintenance labels
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Rutger Wessels (
@rutgerwessels
) (UTC+2, 9 hours ahead of@stanhu
)Kassio Borges (
@kassio
) (UTC+1, 8 hours ahead of@stanhu
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Rubygems
This merge request adds, or changes a Rubygems dependency. Please review the Gemfile guidelines.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @tyleramos
@stanhu LGTM! Thanks for the update!
@tyleramos
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
@mkozono Do you mind running the maintainer review for this MR? Thanks!
requested review from @mkozono and removed review request for @tyleramos
Allure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for dc99dbdaexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 312 | 0 | 0 | 117 | 312 | ❗ | | Create | 828 | 1 | 42 | 350 | 871 | ❌ | | Govern | 235 | 0 | 0 | 234 | 235 | ❗ | | Fulfillment | 12 | 0 | 110 | 2 | 122 | ❗ | | Verify | 270 | 0 | 20 | 265 | 290 | ❗ | | Manage | 198 | 1 | 37 | 100 | 236 | ❌ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | | Data Stores | 185 | 0 | 3 | 60 | 188 | ❗ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | Release | 30 | 0 | 0 | 25 | 30 | ❗ | | Analytics | 11 | 0 | 0 | 10 | 11 | ❗ | | Monitor | 62 | 0 | 1 | 58 | 63 | ❗ | | Package | 126 | 0 | 59 | 126 | 185 | ❗ | | Systems | 19 | 0 | 0 | 0 | 19 | ✅ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | Secure | 20 | 0 | 40 | 20 | 60 | ❗ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Framework sanity | 0 | 0 | 7 | 0 | 7 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2311 | 2 | 350 | 1367 | 2663 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
Sounds safe due to usage in Omnibus GitLab and the GitLab chart. For transparency, I did not review the diff but here it is in case someone is interested.
I'm retrying the failure since it looked unrelated. Setting MWPS.
@stanhu Thank you!
enabled an automatic merge when the pipeline for d5d1045c succeeds
@mkozono, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit cc12e260
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in commit omnibus-gitlab@1adeb58b
mentioned in merge request omnibus-gitlab!6804 (merged)
mentioned in commit omnibus-gitlab@06ada767
mentioned in commit gitlab-org/charts/gitlab@389d7c7e
mentioned in merge request gitlab-org/charts/gitlab!3075 (merged)
mentioned in commit omnibus-gitlab@549d28b7
mentioned in commit release-tools@ba05382d
mentioned in merge request release-tools!2287 (merged)
mentioned in commit release-tools@fd17ffd5
mentioned in issue gitlab-com/gl-infra/delivery#2231 (closed)
mentioned in commit release-tools@ea288dd8
mentioned in commit gitlab-org/charts/gitlab@44277c82
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2061 (merged)
mentioned in commit gitlab-org/charts/gitlab@ec946052
mentioned in commit rgarcia65201/gitlab@31c59cf2
mentioned in commit 318ec0f1
mentioned in merge request !124906 (merged)
mentioned in commit 75df273b
mentioned in merge request !125126 (merged)