Draft: Fields to AbuseReports
What does this MR do and why?
Adds fields to the abuse_reports
table to facilitate wider automation and uses.
See https://gitlab.com/gitlab-org/modelops/anti-abuse/team-tasks/-/issues/222 for more details.
Screenshots or screen recordings
main: == 20230214212644 AddFieldsToAbuseReports: reverting ==========================
main: -- change_table(:abuse_reports)
main: -> 0.0085s
main: == 20230214212644 AddFieldsToAbuseReports: reverted (0.0122s) =================
main: == 20230214212644 AddFieldsToAbuseReports: migrating ==========================
main: -- transaction_open?()
main: -> 0.0000s
main: -- add_column(:abuse_reports, :resolved_by_id, :int, {:null=>true})
main: -> 0.0104s
main: -- add_column(:abuse_reports, :assignee_id, :int, {:null=>true})
main: -> 0.0019s
main: -- add_column(:abuse_reports, :updated_by_id, :int, {:null=>true})
main: -> 0.0013s
main: -- add_column(:abuse_reports, :last_edited_by_id, :int, {:null=>true})
main: -> 0.0006s
main: -- add_column(:abuse_reports, :last_edited_at, :datetime_with_timezone, {:null=>true})
main: -> 0.0009s
main: -- add_column(:abuse_reports, :mitigation_steps, :text, {:null=>true})
main: -> 0.0011s
main: -- add_column(:abuse_reports, :evidence, :jsonb, {:null=>true})
main: -> 0.0027s
main: -- transaction_open?()
main: -> 0.0000s
main: -- transaction_open?()
main: -> 0.0000s
main: -- execute("ALTER TABLE abuse_reports\nADD CONSTRAINT check_f3c0947a2d\nCHECK ( char_length(mitigation_steps) <= 1000 )\nNOT VALID;\n")
main: -> 0.0011s
main: -- execute("SET statement_timeout TO 0")
main: -> 0.0003s
main: -- execute("ALTER TABLE abuse_reports VALIDATE CONSTRAINT check_f3c0947a2d;")
main: -> 0.0010s
main: -- execute("RESET statement_timeout")
main: -> 0.0003s
main: == 20230214212644 AddFieldsToAbuseReports: migrated (0.2025s) =================
How to set up and validate locally
N/A
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @eurie
- A deleted user
added database databasereview pending documentation labels
4 Warnings 9e0b096b: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. Please add a merge request subtype to this merge request. Please add a merge request type to this merge request. 2 Messages This merge request adds or changes files that require a review from the Database team. This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
-
Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
-
Prepare your MR for database review according to the docs.
-
Assign and mention the database reviewer suggested by Reviewer Roulette.
-
Kick off the
db:gitlabcom-database-testing
manual job. This job can also be used before requesting review to test your migrations against production data.
The following files require a review from the Database team:
db/migrate/20230214212644_add_fields_to_abuse_reports.rb
db/schema_migrations/20230214212644
db/structure.sql
Documentation review
The following files require a review from a technical writer:
-
db/docs/merge_requests_compliance_violations.yml
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer database Jon Jenkins (
@jon_jenkins
) (UTC-5, 1 hour behind@eurie
)Diogo Frazão (
@dfrazao-gitlab
) (UTC+1, 5 hours ahead of@eurie
)~"migration" No reviewer available No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
@eurie - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
mentioned in commit 51f81cb9
mentioned in commit 559e5a81
added 129 commits
-
51f81cb9...0ef9acce - 127 commits from branch
master
- 9e0b096b - create the `down` method
- 559e5a81 - Add text limit and fix `#down`
-
51f81cb9...0ef9acce - 127 commits from branch
added typemaintenance label
mentioned in commit 04460da9
mentioned in commit 005d88b9
mentioned in commit 3a5b399d
mentioned in commit e13f7295
mentioned in commit 91753ef5
mentioned in commit c0399ee0
mentioned in commit 77ce8c34
mentioned in commit 2e6fdb2d
mentioned in commit c2d94cdb
mentioned in commit be06647f
mentioned in commit d8faed81
mentioned in commit 6278fa98
mentioned in commit 1a3cf1fc
mentioned in commit 5f5b9445
mentioned in commit 3ec54d11
mentioned in commit 8a68d070
mentioned in commit a2c69dd5
mentioned in commit 81e5c2f2
mentioned in commit 585a5bf4
mentioned in commit f4f04b42
mentioned in commit 7d7e83ba
mentioned in commit 896f56db
mentioned in commit 4076a5e1
mentioned in commit 06bc71f3
mentioned in commit 835be88c
mentioned in commit 48727e02
mentioned in commit 834b62e4
mentioned in commit a8011209
mentioned in commit 5a2b0ba8
mentioned in commit 689d52d5
mentioned in commit d77ef9a3
mentioned in commit e762bf89
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)