danger-review
Passed Started
by
@eurie

Ethan Urie
1Running with gitlab-runner 15.9.0~beta.115.g598a7c91 (598a7c91)2 on green-4.shared-gitlab-org.runners-manager.gitlab.com/default x5QiHUKw, system ID: s_b9637080a79e3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-12:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-12:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:7f1201d984e75e00a4781ca08435ba45d009c12d464efab5a41486f774957910 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-12:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-12@sha256:d7f52531b48e46835f1a8e8aef868d0caa3fadd2dd28de85cb88b57305c0e85c ...11Running on runner-x5qihukw-project-278964-concurrent-0 via runner-x5qihukw-shared-gitlab-org-1678813679-deccde58...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 149149, done. 18remote: Counting objects: 100% (149149/149149), done. 19remote: Compressing objects: 100% (93537/93537), done. 20remote: Total 149149 (delta 68523), reused 105823 (delta 50026), pack-reused 0 21Receiving objects: 100% (149149/149149), 124.25 MiB | 29.76 MiB/s, done.22Resolving deltas: 100% (68523/68523), done.24 * [new ref] refs/pipelines/806232981 -> refs/pipelines/80623298125Checking out 6e1986f9 as detached HEAD (ref is refs/merge-requests/114518/merge)...26Skipping Git submodules setup27$ git remote set-url origin "${CI_REPOSITORY_URL}"29Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...30cache.zip is up to date 31Successfully extracted cache32Checking cache for node-modules-bullseye-test-16...33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 34Successfully extracted cache36Using docker image sha256:7f1201d984e75e00a4781ca08435ba45d009c12d464efab5a41486f774957910 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-12:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-12@sha256:d7f52531b48e46835f1a8e8aef868d0caa3fadd2dd28de85cb88b57305c0e85c ...37$ source scripts/utils.sh38$ bundle_install_script "--with danger"682$ yarn_install_script692$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command693$ bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"694Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb695Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb696Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb697Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb698Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb699Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb700Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb701Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb702Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb703Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb704Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture705Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates706Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/changelog707Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/changes_size708Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config709Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates710Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/commit_messages711Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/commits_counter712Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files713Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success714Importing rule database at /builds/gitlab-org/gitlab/danger/database715Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam716Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation717Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies718Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint719Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag720Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly721Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/metadata722Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas723Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline724Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier725Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence726Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector727Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette728Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems729Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args730Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues731Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels732Importing rule specs at /builds/gitlab-org/gitlab/danger/specs733Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch734Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/subtype_label735Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/type_label736Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css737Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation738Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/z_add_labels739Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata740Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/z_retry_link741Results:742Warnings:743- [ ] 9e0b096b2d906c0fcffa0f1ebcf78050949f3dcc: The commit subject must start with a capital letter. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).744- [ ] This merge request does not refer to an existing milestone.745- [ ] Please add a [merge request subtype](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification) to this merge request.746- [ ] Please add a [merge request type](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification) to this merge request.747Messages:748- [ ] This merge request adds or changes files that require a review from the [Database team](https://gitlab.com/groups/gl-database/-/group_members).749- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.750Markdown:751This merge request requires a database review. To make sure these752changes are reviewed, take the following steps:7531. Ensure the merge request has ~database and ~"database::review pending" labels.754 If the merge request modifies database files, Danger will do this for you.7551. Prepare your MR for database review according to the756 [docs](https://docs.gitlab.com/ee/development/database_review.html#how-to-prepare-the-merge-request-for-a-database-review).7571. Assign and mention the database reviewer suggested by Reviewer Roulette.7581. Kick off the `db:gitlabcom-database-testing` manual job. This job can also be used before759 requesting review to test your migrations against production data.760The following files require a review from the Database team:761* `db/migrate/20230214212644_add_fields_to_abuse_reports.rb`762* `db/schema_migrations/20230214212644`763* `db/structure.sql`764## Documentation review765The following files require a review from a technical writer:766* `db/docs/merge_requests_compliance_violations.yml` ([Link to current live version](db/docs/merge_requests_compliance_violations.yml))767The review does not need to block merging this merge request. See the:768- [Metadata for the `*.md` files](https://docs.gitlab.com/ee/development/documentation/#metadata) that you've changed. The first few lines of each `*.md` file identify the stage and group most closely associated with your docs change.769- The [Technical Writer assigned](https://about.gitlab.com/handbook/product/ux/technical-writing/#assignments) for that stage and group.770- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.771## Reviewer roulette772Changes that require review have been detected!773Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:774| Category | Reviewer | Maintainer |775| -------- | -------- | ---------- |776| ~"database" | [Jon Jenkins](https://gitlab.com/jon_jenkins)  (`@jon_jenkins`) (UTC-5, 1 hour behind `@eurie`) | [Diogo Frazão](https://gitlab.com/dfrazao-gitlab)  (`@dfrazao-gitlab`) (UTC+1, 5 hours ahead of `@eurie`) |777| ~"migration" | No reviewer available | No maintainer available |778To spread load more evenly across eligible reviewers, Danger has picked a candidate for each779review slot, based on their timezone. Feel free to780[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)781if you think someone else would be better-suited782or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.783To read more on how to use the reviewer roulette, please take a look at the784[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)785and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).786Please consider assigning a reviewer or maintainer who is a787[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.788Once you've decided who will review this merge request, assign them as a reviewer!789Danger does not automatically notify them for you.790**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/3933285989) that generated this comment.**791==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"' succeeded in 6 seconds.793Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy794Not uploading cache node-modules-bullseye-test-16 due to policy796Job succeeded