Skip to content

Refactor create compliance framework form to modal

Elwyn Benson requested to merge 324032-compliance-frameworks-modal-refactor into master

What does this MR do and why?

Adds new feature flag manage_compliance_frameworks_modals_refactor. Rollout issue: #389653 (closed)

When the feature flag is enabled, the Compliance Frameworks create and edit UI will now use a modal. This avoids full page loads and redirects.

The compliance frameworks data is re-fetched after successfully adding or editing, the same as how the current delete functionality works.

There will be a subsequent MR to further refactor this feature (e.g. don't re-fetch the framework when clicking Edit, since we already have the data, remove some of the prop-drilling), add tests, remove FF etc.

Screenshots or screen recordings

before (redirected to full page form) after (modal)
image image

How to set up and validate locally

  1. Visit a top level group, with owner access
  2. Click Settings -> General
  3. Scroll down and expand Compliance Frameworks
  4. Add / Edit flows now use modal instead of full page redirects
Feature.enable(:manage_compliance_frameworks_modals_refactor)
Feature.disable(:manage_compliance_frameworks_modals_refactor)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #324032 (closed)

Edited by Elwyn Benson

Merge request reports