Refactor create compliance framework form to modal

What does this MR do and why?

Adds new feature flag manage_compliance_frameworks_modals_refactor. Rollout issue: #389653 (closed)

When the feature flag is enabled, the Compliance Frameworks create and edit UI will now use a modal. This avoids full page loads and redirects.

The compliance frameworks data is re-fetched after successfully adding or editing, the same as how the current delete functionality works.

There will be a subsequent MR to further refactor this feature (e.g. don't re-fetch the framework when clicking Edit, since we already have the data, remove some of the prop-drilling), add tests, remove FF etc.

Screenshots or screen recordings

before (redirected to full page form)	after (modal)

How to set up and validate locally

1. Visit a top level group, with owner access
2. Click Settings -> General
3. Scroll down and expand Compliance Frameworks
4. Add / Edit flows now use modal instead of full page redirects

Feature.enable(:manage_compliance_frameworks_modals_refactor)
Feature.disable(:manage_compliance_frameworks_modals_refactor)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #324032 (closed)

changed milestone to %15.10

added Enterprise Edition GitLab Premium Next Up UX [deprecated] Accepting merge requests bugperformance devopsgovern documentation featureenhancement frontend groupcompliance missed:15.7 missed:15.8 sectionsec typefeature workflowin dev labels

assigned to @elwyn-gitlab

added typebug label and removed featureenhancement typefeature labels

removed bugperformance label

removed typebug label

added typefeature label

added maintenancerefactor label

added typemaintenance label and removed typefeature label

added backend feature flag labels

	5 Warnings
	This merge request is quite big (581 lines changed), please consider splitting it into multiple merge requests.
	ad2399ce: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	3a0fb5e2: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	a8aad120: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	16a7e381: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Siddharth Dungarwal (@sdungarwal) (UTC+5.5, 6.5 hours behind @elwyn-gitlab)	Alex Pooley (@alexpooley) (UTC+8, 4 hours behind @elwyn-gitlab)
frontend	Rahul Chanila (@rchanila) (UTC+10, 2 hours behind @elwyn-gitlab)	Justin Ho (@justin_ho) (UTC+7, 5 hours behind @elwyn-gitlab)
UX	Jeremy Elder (@jeldergl) (UTC-5, 17 hours behind @elwyn-gitlab)	Maintainer review is optional for UX

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@8cbfb826

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits ba495169 and d71a5141

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.62 MB	3.62 MB	-	0.0 %
mainChunk	2.08 MB	2.08 MB	-	0.0 %

---

Note: We do not have exact data for ba495169. So we have used data from: 2d5bf38e.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

Allure report

allure-report-publisher generated test report!

e2e-review-qa: test report for d71a5141

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Govern           | 26     | 0      | 0       | 0     | 26    | ✅     |
| Plan             | 49     | 0      | 1       | 0     | 50    | ✅     |
| Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
| Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
| Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
| Manage           | 8      | 0      | 3       | 0     | 11    | ✅     |
| Verify           | 10     | 0      | 0       | 0     | 10    | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 156    | 0      | 7       | 0     | 163   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for d71a5141

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 290    | 0      | 44      | 126   | 334   | ❗     |
| Verify           | 108    | 0      | 8       | 96    | 116   | ❗     |
| Package          | 0      | 0      | 6       | 0     | 6     | ➖     |
| Manage           | 58     | 0      | 12      | 36    | 70    | ❗     |
| Plan             | 120    | 0      | 0       | 60    | 120   | ❗     |
| Data Stores      | 68     | 0      | 0       | 24    | 68    | ❗     |
| Monitor          | 20     | 0      | 0       | 20    | 20    | ❗     |
| Framework sanity | 0      | 0      | 2       | 0     | 2     | ➖     |
| Fulfillment      | 4      | 0      | 44      | 0     | 48    | ✅     |
| Govern           | 92     | 0      | 0       | 92    | 92    | ❗     |
| Configure        | 0      | 0      | 6       | 0     | 6     | ➖     |
| Secure           | 8      | 0      | 16      | 8     | 24    | ❗     |
| Analytics        | 4      | 0      | 0       | 4     | 4     | ❗     |
| Release          | 12     | 0      | 0       | 10    | 12    | ❗     |
| ModelOps         | 0      | 0      | 2       | 0     | 2     | ➖     |
| Growth           | 0      | 0      | 4       | 0     | 4     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 784    | 0      | 144     | 476   | 928   | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

mentioned in commit 7b74a27b

added 1 commit

• 7b74a27b - Refactor compliance frameworks create/edit to modals

Compare with previous version

changed the description

mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@14aeaf4d

mentioned in commit f055f03c

added 1 commit

• f055f03c - Refactor compliance frameworks create/edit to modals

Compare with previous version