Skip to content
Snippets Groups Projects

Add ability to clean up stale environments

Merged Allen Cook requested to merge 19724-ui-stop-stale-environments into master
1 unresolved thread

What does this MR do and why?

Allows users to clean up stale environments that haven't been modified or deployed to since a specified date

Screenshots or screen recordings

image

How to set up and validate locally

  1. Enable the stop_stale_environments feature flag (i.e. Feature.enable(:stop_stale_environments))
  2. Navigate to the environments page for a project that has stale environments as a user with maintainer access
  3. Click "Clean up environments" to show the new modal
  4. Input a date after the stale environments you want to stop have been updated
  5. Click "clean up"
  6. Wait for stale environments to become "stopped" (should be fairly quick)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #19724 (closed)

Edited by Allen Cook

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Andrew Fontaine
  • Looking good @acook.gitlab

    general direction is solid, just some things to think about :thumbsup:

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :white_check_mark: test report for 2e7798e2

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Govern           | 28     | 0      | 5       | 0     | 33    | ✅     |
    | Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
    | Plan             | 49     | 0      | 1       | 0     | 50    | ✅     |
    | Verify           | 12     | 0      | 0       | 0     | 12    | ✅     |
    | Manage           | 33     | 0      | 3       | 0     | 36    | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 163    | 0      | 12      | 0     | 175   | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :exclamation: test report for 2e7798e2

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 120    | 0      | 0       | 0     | 120   | ✅     |
    | Create           | 292    | 0      | 40      | 20    | 332   | ❗     |
    | Analytics        | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Fulfillment      | 4      | 0      | 50      | 0     | 54    | ✅     |
    | Manage           | 132    | 0      | 6       | 4     | 138   | ❗     |
    | ModelOps         | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Configure        | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Release          | 12     | 0      | 0       | 0     | 12    | ✅     |
    | Verify           | 98     | 0      | 4       | 0     | 102   | ✅     |
    | Govern           | 84     | 0      | 2       | 0     | 86    | ✅     |
    | Framework sanity | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Monitor          | 10     | 0      | 0       | 0     | 10    | ✅     |
    | Secure           | 14     | 0      | 2       | 0     | 16    | ✅     |
    | Package          | 0      | 0      | 6       | 0     | 6     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 770    | 0      | 120     | 24    | 890   | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Allen Cook added 1 commit

    added 1 commit

    • 208a4864 - Add ability for users to stop stale environments

    Compare with previous version

  • Allen Cook deleted the 19724-api-stop-stale-environments branch. This merge request now targets the master branch

    deleted the 19724-api-stop-stale-environments branch. This merge request now targets the master branch

  • Allen Cook added 223 commits

    added 223 commits

    Compare with previous version

  • Allen Cook added 1 commit

    added 1 commit

    • e4946ddc - Add ability for users to stop stale environments

    Compare with previous version

  • Allen Cook added 1 commit

    added 1 commit

    • d1f49664 - Add ability for users to stop stale environments

    Compare with previous version

  • A deleted user added feature flag label

    added feature flag label

  • Allen Cook added 1 commit

    added 1 commit

    • 8ea35360 - Add ability for users to stop stale environments

    Compare with previous version

  • Allen Cook added 1 commit

    added 1 commit

    • 2ad62815 - Add ability for users to stop stale environments

    Compare with previous version

  • Allen Cook added 1 commit

    added 1 commit

    • a7d4ccc7 - Add ability for users to stop stale environments

    Compare with previous version

  • Allen Cook added 1 commit

    added 1 commit

    • 9d632680 - Add ability for users to stop stale environments

    Compare with previous version

  • Allen Cook resolved all threads

    resolved all threads

  • Allen Cook marked this merge request as ready

    marked this merge request as ready

  • Allen Cook changed the description

    changed the description

  • Allen Cook requested review from @cwiesner

    requested review from @cwiesner

  • Allen Cook requested review from @andrei.zubov

    requested review from @andrei.zubov

  • Allen Cook requested review from @andyvolpe

    requested review from @andyvolpe

  • Allen Cook added 1 commit

    added 1 commit

    • 7cec33dc - Add ability for users to stop stale environments

    Compare with previous version

  • Andy Volpe approved this merge request

    approved this merge request

  • :wave: @andyvolpe, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Corinna Gogolok approved this merge request

    approved this merge request

  • Corinna Gogolok removed review request for @cwiesner

    removed review request for @cwiesner

  • Corinna Gogolok requested review from @minac

    requested review from @minac

  • Mehmet Emin INAC
  • Mehmet Emin INAC removed review request for @minac

    removed review request for @minac

  • Andrei Zubov
  • Allen Cook added 1 commit

    added 1 commit

    • 2a96e402 - Add ability for users to stop stale environments

    Compare with previous version

  • Allen Cook added 1 commit

    added 1 commit

    • 1af65c7e - Add ability for users to stop stale environments

    Compare with previous version

  • Andrei Zubov approved this merge request

    approved this merge request

  • Andrei Zubov removed review request for @andrei.zubov

    removed review request for @andrei.zubov

  • Allen Cook added 1 commit

    added 1 commit

    • d7656ed9 - Add ability for users to stop stale environments

    Compare with previous version

  • Mehmet Emin INAC approved this merge request

    approved this merge request

  • Allen Cook requested review from @zcuddy

    requested review from @zcuddy

  • Allen Cook removed review request for @andyvolpe

    removed review request for @andyvolpe

  • Allen Cook requested review from @afontaine

    requested review from @afontaine

  • Allen Cook removed review request for @zcuddy

    removed review request for @zcuddy

  • Andrew Fontaine
  • Andrew Fontaine
  • Andrew Fontaine
  • Allen Cook added 1 commit

    added 1 commit

    • 1c0ecfd0 - Add specs for testing submit of cleanup request

    Compare with previous version

  • Andrew Fontaine resolved all threads

    resolved all threads

  • Andrew Fontaine approved this merge request

    approved this merge request

  • This looks great @acook.gitlab thanks for those extra tests :muscle:

  • Andrew Fontaine enabled an automatic merge when the pipeline for e85cffff succeeds

    enabled an automatic merge when the pipeline for e85cffff succeeds

  • Allen Cook aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Allen Cook added 1 commit

    added 1 commit

    • 2e7798e2 - Add specs for testing submit of cleanup request

    Compare with previous version

  • Andrew Fontaine approved this merge request

    approved this merge request

  • Andrew Fontaine enabled an automatic merge when the pipeline for ede1f60b succeeds

    enabled an automatic merge when the pipeline for ede1f60b succeeds

  • Andrew Fontaine mentioned in commit d039c657

    mentioned in commit d039c657

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading