Enable CRM by default for new groups
What does this MR do and why?
Relates to Customer Database "for Service Desk" (or otherw... (#2256)
This MR defaults the CRM group setting to enabled for all newly created groups and subgroups.
Migrations
lee@Lees-MBP gitlab % bundle exec rails db:migrate
Attention: used pure ruby version of MurmurHash3
main: == 20230108205644 ChangeGroupCrmSettingsEnabledDefault: migrating =============
main: -- change_column_default(:group_crm_settings, :enabled, {:from=>false, :to=>true})
main: -> 0.0723s
main: == 20230108205644 ChangeGroupCrmSettingsEnabledDefault: migrated (0.0783s) ====
lee@Lees-MBP gitlab % bundle exec rails db:migrate:down VERSION=20230108205644
Attention: used pure ruby version of MurmurHash3
main: == 20230108205644 ChangeGroupCrmSettingsEnabledDefault: reverting =============
main: -- change_column_default(:group_crm_settings, :enabled, {:from=>true, :to=>false})
main: -> 0.0748s
main: == 20230108205644 ChangeGroupCrmSettingsEnabledDefault: reverted (0.0794s) ====
How to set up and validate locally
https://docs.gitlab.com/ee/user/crm/
- Create a new root group
- Ensure the CRM option is enabled https://docs.gitlab.com/ee/user/crm/#enable-customer-relations-management-crm
- Ensure the customer relations > contacts and organizations left navigation menu/sidebar options appear
- Create a subgroup
- Ensure the CRM option is enabled
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #2256
Merge request reports
Activity
changed milestone to %Backlog
added CRM customer devopsplan sectiondev typefeature + 1 deleted label
assigned to @leetickett-gitlab
- A deleted user
added backend database databasereview pending labels
- A deleted user
added documentation label
changed milestone to %15.8
- Resolved by Lee Tickett
@egrieff could you take backend review please?
@euko could you take the database review please?
@msedlakjakubowski could you take documentation review please?
requested review from @euko, @egrieff, and @msedlakjakubowski
- Resolved by Lee Tickett
- Resolved by Lee Tickett
- Resolved by Lee Tickett
- Resolved by Lee Tickett
removed review request for @msedlakjakubowski
@msedlakjakubowski
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @euko
removed review request for @egrieff
added 1252 commits
-
ce55373c...fbe8ae20 - 1249 commits from branch
gitlab-org:master
- 535cd9b7 - Enable CRM by default for new groups
- 5cc04260 - Default crm_enabled when no crm_settings
- ec211305 - Fix failing specs
Toggle commit list-
ce55373c...fbe8ae20 - 1249 commits from branch
removed review request for @euko
requested review from @morefice
- Resolved by Lee Tickett
Sorry @gweaver I should have checked in with you before moving forward with this
How do you feel about us changing the behaviour to default CRM to enabled?
From what I understand it's fairly standard practice with new features to go from behind feature flag to default on. We actually added an extra step in the interim to default to off first...
Thanks
Database migrations (on the main database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20230108205644 - ChangeGroupCrmSettingsEnabledDefault Regular 2.6 s +0.00 B Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 1 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20230108205644 - ChangeGroupCrmSettingsEnabledDefault
- Type: Regular
- Duration: 2.6 s
- Database size change: +0.00 B
Calls Total Time Max Time Mean Time Rows Query 1 1.5 ms 1.5 ms 1.5 ms 0 ALTER TABLE "group_crm_settings" ALTER COLUMN "enabled"SET DEFAULT TRUE /*application:test,db_config_name:main,line:/db/migrate/20230108205644_change_group_crm_settings_enabled_default.rb:5:in `change'*/
Histogram for ChangeGroupCrmSettingsEnabledDefault
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 1 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0
Background migrations
Other migrations pending on GitLab.com
Migration Type Total runtime Result DB size change Clone Details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-1678875-9040575-main
2023-01-20T13:38:59Z 2023-01-20T12:11:30Z 2023-01-21 01:42:48 +0000 database-testing-1678875-9040575-ci
2023-01-20T13:38:59Z 2023-01-20T12:47:10Z 2023-01-21 01:42:48 +0000 Artifacts
Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic
Database migrations (on the ci database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20230108205644 - ChangeGroupCrmSettingsEnabledDefault Regular 2.3 s +0.00 B Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 1 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20230108205644 - ChangeGroupCrmSettingsEnabledDefault
- Type: Regular
- Duration: 2.3 s
- Database size change: +0.00 B
Calls Total Time Max Time Mean Time Rows Query 1 37.8 ms 37.8 ms 37.8 ms 0 ALTER TABLE "group_crm_settings" ALTER COLUMN "enabled"SET DEFAULT TRUE /*application:test,db_config_name:ci,line:/db/migrate/20230108205644_change_group_crm_settings_enabled_default.rb:5:in `change'*/
Histogram for ChangeGroupCrmSettingsEnabledDefault
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 1 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0
Background migrations
Other migrations pending on GitLab.com
Migration Type Total runtime Result DB size change Clone Details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-1678875-9040575-main
2023-01-20T13:38:59Z 2023-01-20T12:11:30Z 2023-01-21 01:42:48 +0000 database-testing-1678875-9040575-ci
2023-01-20T13:38:59Z 2023-01-20T12:47:10Z 2023-01-21 01:42:48 +0000 Artifacts
Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic
removed review request for @morefice
- A deleted user
added database-testing-automation label
requested review from @morefice
added databasereviewed label and removed databasereview pending label
mentioned in issue #388924 (closed)
removed review request for @egrieff
added workflowin dev label and removed workflowin review label
removed review request for @Alexand
changed milestone to %15.9
added missed:15.8 label
changed milestone to %15.10
added missed:15.9 label
- Resolved by Lee Tickett
mentioned in issue #2256
added groupproduct planning label and removed 1 deleted label
changed milestone to %15.11
added missed:15.10 label
mentioned in issue gitlab-org/quality/triage-reports#11937 (closed)
changed milestone to %16.0
added missed:15.11 label
mentioned in issue gitlab-org/quality/triage-reports#12096 (closed)
mentioned in issue gitlab-org/quality/triage-reports#12284 (closed)
changed milestone to %16.1
added missed:16.0 label
mentioned in issue gitlab-org/quality/triage-reports#12510 (closed)
mentioned in issue gitlab-org/quality/triage-reports#12724 (closed)
changed milestone to %16.2
added missed:16.1 label
mentioned in issue gitlab-org/quality/triage-reports#12890 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13192 (closed)
changed milestone to %16.3
added missed:16.2 label
- Resolved by Lee Tickett
@leetickett-gitlab Hey there
Do you need any help getting unblocked on this?
changed milestone to %16.4
added missed:16.3 label
mentioned in issue gitlab-org/quality/triage-reports#13787 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13997 (closed)
- Resolved by Lee Tickett
@nickbrandt are you able to help with this?
I'm not convinced combining contacts and organizations into a single screen is going to work.
The contacts screen looks like:
And organizations:
Any bright ideas?
Thanks
changed milestone to %16.5
added missed:16.4 label
changed milestone to %16.6
added missed:16.5 label
mentioned in issue gitlab-org/quality/triage-reports#14559 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14821 (closed)
added grouprespond label and removed groupproduct planning label
added sectionseg label and removed sectiondev label
changed milestone to %16.7
added missed:16.6 label
mentioned in merge request !137981 (closed)
changed milestone to %16.8
added missed:16.7 label
mentioned in issue gitlab-org/quality/triage-reports#15644 (closed)
changed milestone to %16.9
added missed:16.8 label
added 59393 commits
-
3b1a5d51...2828489e - 59390 commits from branch
gitlab-org:master
- 655d5f18 - Enable CRM by default for new groups
- 8df57c26 - Default crm_enabled when no crm_settings
- 4423cf5c - Fix failing specs
Toggle commit list-
3b1a5d51...2828489e - 59390 commits from branch
- Resolved by Lee Tickett
- Resolved by Lee Tickett
- Resolved by Lee Tickett
- Resolved by Panos Kanellidis
5 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.b76a1d62: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. b76a1d62: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. e265319a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 31199916: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/user/crm/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer backend @panoskanell
(UTC+2, 2 hours ahead of author)
@vyaklushin
(UTC+1, 1 hour ahead of author)
database @dgruzd
(UTC+1, 1 hour ahead of author)
@jon_jenkins
(UTC-6, 6 hours behind author)
test for spec/features/*
@panoskanell
(UTC+2, 2 hours ahead of author)
Maintainer review is optional for test for spec/features/*
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 42a7cdf6expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 3 | 0 | 11 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Plan | 53 | 0 | 0 | 0 | 53 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 68 | 0 | 6 | 0 | 74 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 42a7cdf6expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 244 | 0 | 13 | 0 | 257 | ✅ | | Create | 148 | 0 | 24 | 4 | 172 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 0 | 0 | 4 | 0 | 4 | ➖ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 406 | 0 | 43 | 4 | 449 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #6034022701 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.6 s < 50.13 s #6034022704 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 245.21 s < 50.13 s #6034009988 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.36 s < 50.13 s #6034010037 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 245.21 s < 50.13 s #6034009543 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 246.61 s < 50.13 s #6034010004 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 245.93 s < 50.13 s #6034010021 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 152.27 s < 50.13 s #6034009491 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.36 s < 50.13 s #6034009508 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 251.05 s < 50.13 s #6034009589 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 267.66 s < 50.13 s #6034009526 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.72 s < 50.13 s #6034009563 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 152.1 s < 50.13 s #6105882645 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 150.96 s < 50.13 s #6105882640 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 243.7 s < 50.13 s #6105821732 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.07 s < 50.13 s #6105821755 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 243.59 s < 50.13 s #6105821430 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.23 s < 50.13 s #6105821584 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.22 s < 50.13 s #6105821460 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 245.31 s < 50.13 s #6105821617 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 253.34 s < 50.13 s #6105822567 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 248.6 s < 50.13 s #6105822567 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 301.73 s < 50.13 s #6111207166 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.16 s < 50.13 s #6111207169 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 251.17 s < 50.13 s #6111155899 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.0 s < 50.13 s #6111156079 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 244.75 s < 50.13 s #6111155966 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 249.07 s < 50.13 s #6111158417 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 306.53 s < 50.13 s #6111158417 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 241.59 s < 50.13 s #6111156040 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.27 s < 50.13 s #6111158179 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 307.31 s < 50.13 s #6111158179 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 241.76 s < 50.13 s #6111156130 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 244.54 s < 50.13 s #6111157916 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 246.13 s < 50.13 s #6111157916 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 301.98 s < 50.13 s #6111156105 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.45 s < 50.13 s #6118283397 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 246.25 s < 50.13 s #6118346801 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.59 s < 50.13 s #6118283122 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 245.11 s < 50.13 s #6118346799 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 246.74 s < 50.13 s #6118283040 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.42 s < 50.13 s #6118283606 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 266.09 s < 50.13 s #6118283565 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.56 s < 50.13 s #6118283307 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.87 s < 50.13 s #6118284351 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 246.94 s < 50.13 s #6118284351 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 302.03 s < 50.13 s #6118284390 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 248.5 s < 50.13 s #6118284390 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 302.71 s < 50.13 s #6118284305 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 260.72 s < 50.13 s #6118284305 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 303.01 s < 50.13 s #6118880682 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 156.88 s < 50.13 s #6118880708 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 268.68 s < 50.13 s #6118832524 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.59 s < 50.13 s #6118832351 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.54 s < 50.13 s #6118832814 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.77 s < 50.13 s #6118833564 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 323.79 s < 50.13 s #6118833564 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 242.31 s < 50.13 s #6118833507 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 319.96 s < 50.13 s #6118833507 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 242.77 s < 50.13 s #6124320776 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 247.66 s < 50.13 s #6124320776 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.74 s < 50.13 s #6124278396 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.68 s < 50.13 s #6124278026 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.7 s < 50.13 s #6124278281 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 152.04 s < 50.13 s #6124278954 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 254.97 s < 50.13 s #6124278954 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 302.27 s < 50.13 s #6124279094 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 315.34 s < 50.13 s #6124279094 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 242.23 s < 50.13 s #6124279202 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 309.07 s < 50.13 s #6124279202 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 242.72 s < 50.13 s #6124278448 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 251.61 s < 50.13 s #6124278333 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 245.19 s < 50.13 s #6124278118 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 250.56 s < 50.13 s #6137400942 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 256.17 s < 50.13 s #6137400841 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.92 s < 50.13 s #6137342055 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 151.71 s < 50.13 s #6137342127 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 242.16 s < 50.13 s #6137341818 spec/features/explore/navbar_spec.rb#L8
"Explore" navbar behaves like verified navigation bar renders correctly 152.07 s < 50.13 s #6137343420 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 308.01 s < 50.13 s #6137343420 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 242.1 s < 50.13 s #6137341889 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 242.48 s < 50.13 s #6137341991 spec/features/dashboard/navbar_spec.rb#L10
"Your work" navbar behaves like verified navigation bar renders correctly 242.48 s < 50.13 s #6137343293 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 318.85 s < 50.13 s #6137343293 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 242.12 s < 50.13 s #6137343041 ee/spec/features/dashboard/navbar_spec.rb#L58
"Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 253.0 s < 50.13 s #6137343041 ee/spec/features/dashboard/navbar_spec.rb#L35
"Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 302.08 s < 50.13 s - A deleted user
added rspec:slow test detected label
mentioned in merge request !142984 (merged)
added 1902 commits
-
4423cf5c...9bfa93e1 - 1898 commits from branch
gitlab-org:master
- b83f2fee - Enable CRM by default for new groups
- 379bd02f - Default crm_enabled when no crm_settings
- a2ccb3b6 - Fix failing specs
- 84cc686e - Fix specs
Toggle commit list-
4423cf5c...9bfa93e1 - 1898 commits from branch
removed missed:15.10 label
removed missed:15.11 label
removed missed:15.8 label
removed missed:15.9 label
removed missed:16.0 label
removed missed:16.1 label
removed missed:16.2 label
removed missed:16.3 label
removed missed:16.4 label
removed missed:16.5 label
removed missed:16.6 label
removed missed:16.7 label
removed missed:16.8 label
added 317 commits
-
8a3458ec...ce558080 - 313 commits from branch
gitlab-org:master
- 7b6340d7 - Enable CRM by default for new groups
- 31199916 - Default crm_enabled when no crm_settings
- e265319a - Fix failing specs
- f4065b75 - Fix specs
Toggle commit list-
8a3458ec...ce558080 - 313 commits from branch
- Resolved by Lee Tickett
- Resolved by Lee Tickett
- Resolved by Lee Tickett
- Resolved by Lee Tickett
- Resolved by Lee Tickett
@panoskanell could you take the backend review here please?
@dgruzd could you take the database review please?
@panoskanell could you take the test review please?
requested review from @panoskanell and @dgruzd
- Resolved by Panos Kanellidis
- Resolved by Lee Tickett
Great work, just 2 small comments from my end for test.
backend Looks good with the 2-step process
Over to you
@leetickett-gitlabEdited by Panos Kanellidis
added 1 commit
- 9734b07f - Use crm_settings factory and favour let_it_be
requested review from @ebaque
removed review request for @panoskanell
added workflowin review label and removed workflowin dev label
requested review from @jon_jenkins and removed review request for @dgruzd
added databaseapproved label and removed databasereviewed label
- Resolved by Lee Tickett
- Resolved by Lee Tickett
requested review from @ebaque
reset approvals from @dgruzd and @jon_jenkins by pushing to the branch
enabled an automatic merge when all merge checks for 42a7cdf6 pass
@leetickett-gitlab, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
Hello @leetickett-gitlab
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
mentioned in commit afbad66a
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2763 (merged)
mentioned in epic &13595