Skip to content
Snippets Groups Projects

Enable CRM by default for new groups

Merged Lee Tickett requested to merge gitlab-community/gitlab:2256-auto-enable-crm into master
All threads resolved!

What does this MR do and why?

Relates to Customer Database "for Service Desk" (or otherw... (#2256)

This MR defaults the CRM group setting to enabled for all newly created groups and subgroups.

Migrations

lee@Lees-MBP gitlab % bundle exec rails db:migrate
Attention: used pure ruby version of MurmurHash3
main: == 20230108205644 ChangeGroupCrmSettingsEnabledDefault: migrating =============
main: -- change_column_default(:group_crm_settings, :enabled, {:from=>false, :to=>true})
main:    -> 0.0723s
main: == 20230108205644 ChangeGroupCrmSettingsEnabledDefault: migrated (0.0783s) ====

lee@Lees-MBP gitlab % bundle exec rails db:migrate:down VERSION=20230108205644
Attention: used pure ruby version of MurmurHash3
main: == 20230108205644 ChangeGroupCrmSettingsEnabledDefault: reverting =============
main: -- change_column_default(:group_crm_settings, :enabled, {:from=>true, :to=>false})
main:    -> 0.0748s
main: == 20230108205644 ChangeGroupCrmSettingsEnabledDefault: reverted (0.0794s) ====

How to set up and validate locally

https://docs.gitlab.com/ee/user/crm/

  1. Create a new root group
  2. Ensure the CRM option is enabled https://docs.gitlab.com/ee/user/crm/#enable-customer-relations-management-crm
  3. Ensure the customer relations > contacts and organizations left navigation menu/sidebar options appear
  4. Create a subgroup
  5. Ensure the CRM option is enabled

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #2256

Edited by Lee Tickett

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • euko
  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • Ghost User
  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • Marcin Sedlak-Jakubowski approved this merge request

    approved this merge request

  • removed review request for @msedlakjakubowski

  • :wave: @msedlakjakubowski, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • euko removed review request for @euko

    removed review request for @euko

  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • Marcin Sedlak-Jakubowski approved this merge request

    approved this merge request

  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • Eugenia Grieff removed review request for @egrieff

    removed review request for @egrieff

  • Lee Tickett added 1252 commits

    added 1252 commits

    Compare with previous version

  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • Lee Tickett requested review from @euko and @egrieff

    requested review from @euko and @egrieff

  • euko removed review request for @euko

    removed review request for @euko

  • Lee Tickett requested review from @morefice

    requested review from @morefice

    • Resolved by Lee Tickett

      Sorry @gweaver I should have checked in with you before moving forward with this

      How do you feel about us changing the behaviour to default CRM to enabled?

      From what I understand it's fairly standard practice with new features to go from behind feature flag to default on. We actually added an extra step in the interim to default to off first...

      Thanks :pray:

  • Database migrations (on the main database)

    Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

    Migration Type Total runtime Result DB size change
    20230108205644 - ChangeGroupCrmSettingsEnabledDefault Regular 2.6 s :white_check_mark: +0.00 B
    Runtime Histogram for all migrations
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 1
    0.1 seconds - 1 second 0
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Migration: 20230108205644 - ChangeGroupCrmSettingsEnabledDefault

    • Type: Regular
    • Duration: 2.6 s
    • Database size change: +0.00 B
    Calls Total Time Max Time Mean Time Rows Query
    1 1.5 ms 1.5 ms 1.5 ms 0
    ALTER TABLE "group_crm_settings" ALTER COLUMN "enabled"SET DEFAULT TRUE /*application:test,db_config_name:main,line:/db/migrate/20230108205644_change_group_crm_settings_enabled_default.rb:5:in `change'*/
    Histogram for ChangeGroupCrmSettingsEnabledDefault
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 1
    0.1 seconds - 1 second 0
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Background migrations


    Other migrations pending on GitLab.com
    Migration Type Total runtime Result DB size change

    Clone Details

    Clone ID Clone Created At Clone Data Timestamp Expected Removal Time
    database-testing-1678875-9040575-main 2023-01-20T13:38:59Z 2023-01-20T12:11:30Z 2023-01-21 01:42:48 +0000
    database-testing-1678875-9040575-ci 2023-01-20T13:38:59Z 2023-01-20T12:47:10Z 2023-01-21 01:42:48 +0000

    Artifacts


    Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic

    Database migrations (on the ci database)

    Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

    Migration Type Total runtime Result DB size change
    20230108205644 - ChangeGroupCrmSettingsEnabledDefault Regular 2.3 s :white_check_mark: +0.00 B
    Runtime Histogram for all migrations
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 1
    0.1 seconds - 1 second 0
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Migration: 20230108205644 - ChangeGroupCrmSettingsEnabledDefault

    • Type: Regular
    • Duration: 2.3 s
    • Database size change: +0.00 B
    Calls Total Time Max Time Mean Time Rows Query
    1 37.8 ms 37.8 ms 37.8 ms 0
    ALTER TABLE "group_crm_settings" ALTER COLUMN "enabled"SET DEFAULT TRUE /*application:test,db_config_name:ci,line:/db/migrate/20230108205644_change_group_crm_settings_enabled_default.rb:5:in `change'*/
    Histogram for ChangeGroupCrmSettingsEnabledDefault
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 1
    0.1 seconds - 1 second 0
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Background migrations


    Other migrations pending on GitLab.com
    Migration Type Total runtime Result DB size change

    Clone Details

    Clone ID Clone Created At Clone Data Timestamp Expected Removal Time
    database-testing-1678875-9040575-main 2023-01-20T13:38:59Z 2023-01-20T12:11:30Z 2023-01-21 01:42:48 +0000
    database-testing-1678875-9040575-ci 2023-01-20T13:38:59Z 2023-01-20T12:47:10Z 2023-01-21 01:42:48 +0000

    Artifacts


    Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic

  • Max Orefice removed review request for @morefice

    removed review request for @morefice

  • Lee Tickett requested review from @morefice

    requested review from @morefice

  • Max Orefice approved this merge request

    approved this merge request

  • added databasereviewed label and removed databasereview pending label

  • Max Orefice requested review from @Alexand and removed review request for @morefice

    requested review from @Alexand and removed review request for @morefice

  • mentioned in issue #388924 (closed)

  • Eugenia Grieff removed review request for @egrieff

    removed review request for @egrieff

  • added workflowin dev label and removed workflowin review label

  • João Alexandre Cunha removed review request for @Alexand

    removed review request for @Alexand

  • 🤖 GitLab Bot 🤖 changed milestone to %15.9

    changed milestone to %15.9

  • additive schema changes; no impact to data warehouse

  • 🤖 GitLab Bot 🤖 changed milestone to %15.10

    changed milestone to %15.10

  • Lee Tickett mentioned in issue #2256

    mentioned in issue #2256

  • 🤖 GitLab Bot 🤖 added groupproduct planning label and removed 1 deleted label

    added groupproduct planning label and removed 1 deleted label

  • 🤖 GitLab Bot 🤖 changed milestone to %15.11

    changed milestone to %15.11

  • 🤖 GitLab Bot 🤖 changed milestone to %16.0

    changed milestone to %16.0

  • 🤖 GitLab Bot 🤖 changed milestone to %16.1

    changed milestone to %16.1

  • 🤖 GitLab Bot 🤖 changed milestone to %16.2

    changed milestone to %16.2

  • 🤖 GitLab Bot 🤖 changed milestone to %16.3

    changed milestone to %16.3

  • 🤖 GitLab Bot 🤖 changed milestone to %16.4

    changed milestone to %16.4

  • 🤖 GitLab Bot 🤖 changed milestone to %16.5

    changed milestone to %16.5

  • 🤖 GitLab Bot 🤖 changed milestone to %16.6

    changed milestone to %16.6

  • added grouprespond label and removed groupproduct planning label

  • 🤖 GitLab Bot 🤖 added sectionseg label and removed sectiondev label

    added sectionseg label and removed sectiondev label

  • 🤖 GitLab Bot 🤖 changed milestone to %16.7

    changed milestone to %16.7

  • Lee Tickett mentioned in merge request !137981 (closed)

    mentioned in merge request !137981 (closed)

  • 🤖 GitLab Bot 🤖 changed milestone to %16.8

    changed milestone to %16.8

  • 🤖 GitLab Bot 🤖 changed milestone to %16.9

    changed milestone to %16.9

  • Lee Tickett added 59393 commits

    added 59393 commits

    Compare with previous version

  • Ghost User
  • Ghost User
  • Ghost User
  • Contributor
    5 Warnings
    :warning: This MR changes code in ee/, but its Changelog commit is missing the EE: true trailer. Consider adding it to your Changelog commits.
    :warning: b76a1d62: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
    :warning: b76a1d62: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning: e265319a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning: 31199916: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Category Reviewer Maintainer
    backend @panoskanell profile link current availability (UTC+2, 2 hours ahead of author) @vyaklushin profile link current availability (UTC+1, 1 hour ahead of author)
    database @dgruzd profile link current availability (UTC+1, 1 hour ahead of author) @jon_jenkins profile link current availability (UTC-6, 6 hours behind author)
    test for spec/features/* @panoskanell profile link current availability (UTC+2, 2 hours ahead of author) Maintainer review is optional for test for spec/features/*

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Contributor

    E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 42a7cdf6

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 8      | 0      | 3       | 0     | 11    | ✅     |
    | Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Plan        | 53     | 0      | 0       | 0     | 53    | ✅     |
    | Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Data Stores | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 68     | 0      | 6       | 0     | 74    | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :white_check_mark: test report for 42a7cdf6

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 244    | 0      | 13      | 0     | 257   | ✅     |
    | Create      | 148    | 0      | 24      | 4     | 172   | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Data Stores | 0      | 0      | 4       | 0     | 4     | ➖     |
    | Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
    | Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 406    | 0      | 43      | 4     | 449   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Contributor

    :tools: Generated by gitlab_quality-test_tooling.


    :snail: Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

    Click to expand
    Job File Name Duration Expected duration
    #6034022701 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.6 s < 50.13 s
    #6034022704 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 245.21 s < 50.13 s
    #6034009988 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.36 s < 50.13 s
    #6034010037 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 245.21 s < 50.13 s
    #6034009543 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 246.61 s < 50.13 s
    #6034010004 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 245.93 s < 50.13 s
    #6034010021 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 152.27 s < 50.13 s
    #6034009491 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.36 s < 50.13 s
    #6034009508 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 251.05 s < 50.13 s
    #6034009589 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 267.66 s < 50.13 s
    #6034009526 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.72 s < 50.13 s
    #6034009563 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 152.1 s < 50.13 s
    #6105882645 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 150.96 s < 50.13 s
    #6105882640 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 243.7 s < 50.13 s
    #6105821732 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.07 s < 50.13 s
    #6105821755 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 243.59 s < 50.13 s
    #6105821430 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.23 s < 50.13 s
    #6105821584 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.22 s < 50.13 s
    #6105821460 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 245.31 s < 50.13 s
    #6105821617 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 253.34 s < 50.13 s
    #6105822567 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 248.6 s < 50.13 s
    #6105822567 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 301.73 s < 50.13 s
    #6111207166 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.16 s < 50.13 s
    #6111207169 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 251.17 s < 50.13 s
    #6111155899 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.0 s < 50.13 s
    #6111156079 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 244.75 s < 50.13 s
    #6111155966 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 249.07 s < 50.13 s
    #6111158417 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 306.53 s < 50.13 s
    #6111158417 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 241.59 s < 50.13 s
    #6111156040 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.27 s < 50.13 s
    #6111158179 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 307.31 s < 50.13 s
    #6111158179 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 241.76 s < 50.13 s
    #6111156130 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 244.54 s < 50.13 s
    #6111157916 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 246.13 s < 50.13 s
    #6111157916 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 301.98 s < 50.13 s
    #6111156105 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.45 s < 50.13 s
    #6118283397 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 246.25 s < 50.13 s
    #6118346801 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.59 s < 50.13 s
    #6118283122 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 245.11 s < 50.13 s
    #6118346799 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 246.74 s < 50.13 s
    #6118283040 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.42 s < 50.13 s
    #6118283606 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 266.09 s < 50.13 s
    #6118283565 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.56 s < 50.13 s
    #6118283307 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.87 s < 50.13 s
    #6118284351 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 246.94 s < 50.13 s
    #6118284351 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 302.03 s < 50.13 s
    #6118284390 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 248.5 s < 50.13 s
    #6118284390 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 302.71 s < 50.13 s
    #6118284305 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 260.72 s < 50.13 s
    #6118284305 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 303.01 s < 50.13 s
    #6118880682 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 156.88 s < 50.13 s
    #6118880708 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 268.68 s < 50.13 s
    #6118832524 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.59 s < 50.13 s
    #6118832351 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.54 s < 50.13 s
    #6118832814 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.77 s < 50.13 s
    #6118833564 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 323.79 s < 50.13 s
    #6118833564 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 242.31 s < 50.13 s
    #6118833507 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 319.96 s < 50.13 s
    #6118833507 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 242.77 s < 50.13 s
    #6124320776 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 247.66 s < 50.13 s
    #6124320776 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.74 s < 50.13 s
    #6124278396 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.68 s < 50.13 s
    #6124278026 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.7 s < 50.13 s
    #6124278281 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 152.04 s < 50.13 s
    #6124278954 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 254.97 s < 50.13 s
    #6124278954 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 302.27 s < 50.13 s
    #6124279094 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 315.34 s < 50.13 s
    #6124279094 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 242.23 s < 50.13 s
    #6124279202 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 309.07 s < 50.13 s
    #6124279202 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 242.72 s < 50.13 s
    #6124278448 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 251.61 s < 50.13 s
    #6124278333 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 245.19 s < 50.13 s
    #6124278118 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 250.56 s < 50.13 s
    #6137400942 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 256.17 s < 50.13 s
    #6137400841 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.92 s < 50.13 s
    #6137342055 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 151.71 s < 50.13 s
    #6137342127 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 242.16 s < 50.13 s
    #6137341818 spec/features/explore/navbar_spec.rb#L8 "Explore" navbar behaves like verified navigation bar renders correctly 152.07 s < 50.13 s
    #6137343420 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 308.01 s < 50.13 s
    #6137343420 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 242.1 s < 50.13 s
    #6137341889 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 242.48 s < 50.13 s
    #6137341991 spec/features/dashboard/navbar_spec.rb#L10 "Your work" navbar behaves like verified navigation bar renders correctly 242.48 s < 50.13 s
    #6137343293 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 318.85 s < 50.13 s
    #6137343293 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 242.12 s < 50.13 s
    #6137343041 ee/spec/features/dashboard/navbar_spec.rb#L58 "Your work" navbar when security dashboard is available behaves like verified navigation bar renders correctly 253.0 s < 50.13 s
    #6137343041 ee/spec/features/dashboard/navbar_spec.rb#L35 "Your work" navbar when devops operations dashboard is available behaves like verified navigation bar renders correctly 302.08 s < 50.13 s
  • A deleted user added rspec:slow test detected label
  • Lee Tickett mentioned in merge request !142984 (merged)

    mentioned in merge request !142984 (merged)

  • Lee Tickett added 1902 commits

    added 1902 commits

    Compare with previous version

  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • removed missed:15.10 label

  • removed missed:15.11 label

  • removed missed:15.8 label

  • removed missed:15.9 label

  • removed missed:16.0 label

  • removed missed:16.1 label

  • removed missed:16.2 label

  • removed missed:16.3 label

  • removed missed:16.4 label

  • removed missed:16.5 label

  • removed missed:16.6 label

  • removed missed:16.7 label

  • removed missed:16.8 label

  • Lee Tickett added 317 commits

    added 317 commits

    Compare with previous version

  • Ghost User
  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • Ghost User
  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • Ghost User
  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • Lee Tickett requested review from @panoskanell and @dgruzd

    requested review from @panoskanell and @dgruzd

  • Lee Tickett added 1 commit

    added 1 commit

    • 9734b07f - Use crm_settings factory and favour let_it_be

    Compare with previous version

  • Panos Kanellidis requested review from @ebaque

    requested review from @ebaque

  • Panos Kanellidis removed review request for @panoskanell

    removed review request for @panoskanell

  • Dmitry Gruzd approved this merge request

    approved this merge request

  • added workflowin review label and removed workflowin dev label

  • Dmitry Gruzd requested review from @jon_jenkins and removed review request for @dgruzd

    requested review from @jon_jenkins and removed review request for @dgruzd

  • Jon Jenkins approved this merge request

    approved this merge request

  • added databaseapproved label and removed databasereviewed label

  • Etienne Baqué
  • Etienne Baqué
  • Lee Tickett requested review from @ebaque

    requested review from @ebaque

  • Lee Tickett added 1 commit

    added 1 commit

    • 42a7cdf6 - Apply 2 suggestion(s) to 2 file(s)

    Compare with previous version

  • Lee Tickett reset approvals from @dgruzd and @jon_jenkins by pushing to the branch

    reset approvals from @dgruzd and @jon_jenkins by pushing to the branch

  • Etienne Baqué approved this merge request

    approved this merge request

  • Jon Jenkins approved this merge request

    approved this merge request

  • Lee Tickett enabled an automatic merge when all merge checks for 42a7cdf6 pass

    enabled an automatic merge when all merge checks for 42a7cdf6 pass

  • Lee Tickett resolved all threads

    resolved all threads

  • merged

  • @leetickett-gitlab, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to auto-merge.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    This message was generated automatically. You're welcome to improve it.

  • Hello @leetickett-gitlab :wave:

    The database team is looking for ways to improve the database review process and we would love your help!

    If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

    @gitlab-org/database-team

    And someone will be by shortly!

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • Lee Tickett mentioned in commit afbad66a

    mentioned in commit afbad66a

  • added workflowstaging label and removed workflowcanary label

  • Nick Leonard mentioned in epic &13595

    mentioned in epic &13595

  • Please register or sign in to reply
    Loading