Remove the skipping of company step for users without a registration_type
Background
We found an issue in onboarding a while ago in 500 upon login due to undefined method `company... (#508393 - closed).
To immediately fix that issue we implemented a 'skip if you should not be here', i.e. not a trial via Provide a workaround for users that do not have... (!176195 - merged).
We felt users either got into this situation by coming to this route non-organically or were older accounts before we introduced user.onboarding_status_registration_type.
To fix these things we:
- Blocked the route so that only onboarding users could reach this area via Redirect users not in onboarding to root_path (!177926 - merged)
- Backfilled the remaining records via Change step_url to group creation when registra... (#510316 - closed) / Updates step_url for users that do not have reg... (!176324 - merged)
Plan
When I was looking to finally remove Provide a workaround for users that do not have... (!176195 - merged), I noticed from this postgres ai output that we seem to have no more users in this state.
However, to be certain, we should:
-
Add logging to this area in the company controller to 'double' confirm nothing needs skipping still. Log enough info so we can get details why better if they do. i.e. include the whole
user.onboarding_statusinfo like we are in https://gitlab.com/gitlab-org/gitlab/blob/1173b79ace91a64b82fd8e099528f93bf3e9c879/ee/app/controllers/registrations/welcome_controller.rb#L113-113 -> [Update - 11-7-25] MR to add logging entering review !211980 (merged) - Wait a few weeks for data on the above.
- If we are sure from the postgres ai output linked and the logging that this is no longer needed, then remove the skipping logic introduced via Provide a workaround for users that do not have... (!176195 - merged). -> **[Update - 11-7-25] **Draft MR to remove workaround
If we find there are still users encountering this, we need to figure out why and fix that, but I do not think that will be the case from the current postgres ai query