Redirect users not in onboarding to root_path

Doug Stullrequested to merge
508393-redirect-not-in-onboarding into master

What does this MR do and why?

Redirect users not in onboarding to root_path

  • we should not allow users to successfully visit routes that are for onboarding where we expect all users that visit the routes to be in onboarding.
  • this is causing unexpected failures when users somehow load this path and aren't in onboarding as seen in #508393 (comment 2296829270)
  • see #508393 (closed)
  • resolve some rubocop exceptions in specs while we modify a few other things there for this issue.

Changelog: fixed EE: true

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #508393 (closed)

Edited by Doug Stull

Merge request reports