FYI, if the group has more than 20k this feature won't work. Right now the behaviour is that the autocomplete won't work and GraphQL will return an error.
I suggest disabling this filter (grey it out) with a popover that clarifies why it's disabled. @wandering_person how hard it is to inject the total amount of variables on the page load for a given/project?
✓
1 of 1 checklist item completed
· Edited
Designs
Child items ...
Show closed items
Linked items 0
Link issues together to show that they're related or that one is blocking others.
Learn more.
Activity
Sort or filter
Newest first
Oldest first
Show all activity
Show comments only
Show history only
Savas Vedovachanged title from Follow-up from "Enable identifier filter for group level" to Disable identifier filter when group has more than 20k vulnerabilities
changed title from Follow-up from "Enable identifier filter for group level" to Disable identifier filter when group has more than 20k vulnerabilities
@wandering_person yes, but just for the identifier filter. Other filters are still supported we're not disabling the whole filtered search all together.
Should we control via separate frontend feature flag?
@nmccorrison Yes, if the frontend work requires a FF, we should make a new one. The backend flag is a derisk flag. The change involved adding an additional db query in the hot-path for all vulnerability-related graphql queries. The FF was there in case this additional query resulted in a noticiable performance regression.
Everything seems fine, so I will be putting up an MR soon to remove the flag