Move CI_PAGES_HOSTNAME to project.rb and reuse its pages_url_builder logic

These two actionables came as a result of this MR.

1. Since Gitlab::Pages::UrlBuilder.new logic was moved to project.rb, let's start using it as project.pages_url or project.pages_hostname instead of initializing it directly in a couple of places in codebase.
2. Let's move CI_PAGES_HOSTNAME variable assignment from build.rb to project.rb since this variable does not seem to be dynamic, so let's not re-assing it on every build job to save some resources.

added gitlab-org#14435 as parent epic

assigned to @afrnz

added Category:Pages KnowledgeP3 groupknowledge labels

added devopsplan sectiondev labels

added backend candidate17.9 ruby labels and removed devopsplan sectiondev labels

added devopsplan sectiondev labels

changed title from Move {--}CI_PAGES_HOSTNAME{--} to {--}project.rb{--} and reuse its {--}pages_url_builder{--} logic to Move CI_PAGES_HOSTNAME to project.rb and reuse its pages_url_builder logic

added maintenancerefactor typemaintenance labels

changed the description

@mmacfarlane @vshushlin @janis This issue is a follow up from this issue I am working on, it should be a small and quick (famous last worlds ) refactor. I would like to add it to this upcoming 17.9 milestone if that's ok by you?

can we schedule it for 17.10? I'd like to address #515560 (closed) first, as that one's blocking GA.

Sure! #515560 (closed) completely went off my radar even though I created it

Thank you, Alisa. Assigned this to 17.10

added candidate17.10 label and removed candidate17.9 label

changed milestone to %17.10

created branch 516166-move-ci_pages_hostname-to-project-rb-and-reuse-its-pages_url_builder-logic to address this issue

mentioned in merge request !181807 (merged)

added workflowready for development label

set weight to 1

added Deliverable label

unassigned @afrnz

assigned to @ngala

@ngala I have put together a draft MR yesterday, if you feel like taking a look !181807 (diffs), maybe it can save you some work if adding next changes on the top of that.

@afrnz oh wow, thank you. That doesn't look like a draft any more to me, do you want to continue to own it? I can write the description for you if you like.

@janis sure, I don't mind finishing it up. It seemed like a straightforward cleanup so I felt I can rather quickly have it done.

I can write the description for you if you like.

Yes, that will be a big help if you can do that, thank you!

And then I guess we can leave out moving the CI_PAGES_HOSTNAME variable from this MR, and it would be ready for the reviews?

@afrnz, fantastic, thank you! I've updated the description and approved, feel free to move it on at your own pace!

And then I guess we can leave out moving the CI_PAGES_HOSTNAME variable from this MR,

Yeah, that's somewhat unrelated anyway, so it makes sense to keep it separate.

@afrnz Thank you.

Amazing, thank you @janis

As a next step, I've asked for the backend maintainer and devopsverify reviews for this MR.

@janis @ngala the refactoring of Gitlab::Pages::UrlBuilder part of this issue is merged There is still the part of moving CI_PAGES_HOSTNAME to project.rb. Do you think it's still valuable to implement this? I don't think I will have time to focus on that soon, then what would you suggest I better do: move CI_PAGES_HOSTNAME to a separate issue and close this one, or keep this one open as someone of you would like to take over the CI_PAGES_HOSTNAME refactor?

@afrnz Thank you for working on the first part. I will take over the second part. It seems small change, so let's do it as a part of this issue only.

assigned to @afrnz and unassigned @ngala

Setting health status to on track as the milestone has just begun.

Issue participants are welcome to override this by setting the health status to another value.

changed health status to on track

added workflowin review label and removed workflowready for development label

added workflowverification label and removed workflowin review label

assigned to @ngala

added workflowin dev label and removed workflowverification label

mentioned in commit 8b0d96e0

mentioned in merge request !183671 (merged)

added workflowin review label and removed workflowin dev label

Async update

Opened MR Move CI_PAGES_HOSTNAME from build.rb to project.rb (!183671 - merged) for review.

/cc @mmacfarlane @vshushlin

mentioned in commit 05346c2f

Async update

• Current status: The MR !183671 (merged) is merged. Marking this issue as workflowcomplete

closed

added workflowcomplete label and removed workflowin review label