Govern: Security Policies 17.5 Planning Issue
Previous planning issue: Govern: Security Policies 17.4 Planning Issue (#478166 - closed)
Narrative
In %17.4, our team was working on delivering Add groups to security policy scope (Iteration 1) (&14149 - closed), Support suffix for jobs with name collisions in... (#473189 - closed) and Allow pipeline execution yaml files to be read ... (#469439 - closed).
Unfortunately, all three had to be postponed as related feature flags were not enabled by default before 2024-09-11: Hard Production Change Lock for Sep... (gitlab-com/gl-infra/production#18551 - closed). Thank you, everyone, for your work in trying to include it in this release!
Before %"17.5," we worked with Grant to do small reprioritization based on designs and requirement readiness of anticipated epics. You can see the results of that work at Update priorities for Security Policies before ... (gitlab-com/www-gitlab-com!136231 - merged).
In this milestone, we aim to:
- finalize work related to Use database read model for merge request appr... (&9971 - closed) and Manage scheduled scan execution pipeline concur... (&13997 - closed),
- continue working on improvements to Pipeline Execution Policies: Compliance handling of `needs` statements in pi... (#469256 - closed), Scheduled pipeline execution policies (&14147) and Enforce Custom Stages in Pipeline Execution Pol... (#475152 - closed),
- start working on Improve compatibility between security policies... (&14119),
- start working on Support multiple distinct approval actions in m... (&12319 - closed)
At the same time, we need to prepare implementation issues for work planned for future milestones:
- Support custom roles in merge request approval ... (&13550 - closed)
- Exclude packages from Merge Request Approval Po... (&10203 - closed)
- Scan Execution Policy Templates (&11919 - closed)
Additionally, in every release, we aim to continue solving bugs to improve the user experience of our Security Policy features and ensure that they work correctly. Our customers are showing increasing interest in using our features, so it's essential to ensure that Scan Execution and Merge Request Approval Policies are functioning as expected.
Spikes
TBD
Priorities
To release
- Add groups to security policy scope (Iteration 1) (&14149 - closed)
- Support suffix for jobs with name collisions in... (#473189 - closed)
- Allow pipeline execution yaml files to be read ... (#469439 - closed)
To finalize and close
Use database read model for merge request appr... (&9971 - closed)
DRI: @sashi_kumar
In %17.5, we want to release work related to read-model epic: deliver all services, models, and migrations and enable the feature flag by default. We will leave the feature flag for the following 2-3 milestones to observe this feature's impact on our overall performance.
-
Tasks:
- Use security policy read model for approval_rules (#464034 - closed) • Sashi Kumar Kumaresan • 17.7 • At risk
- Add migration to sync policies to read model (#464033 - closed) • Andy Schoenen, Sashi Kumar Kumaresan • 17.7 • Needs attention
- Add service to create and sync policy YAML into... (#416262 - closed) • Andy Schoenen • 17.5 • At risk
- [Feature flag] Rollout of `security_policies_sy... (#454828 - closed) • Sashi Kumar Kumaresan • 17.6 • On track
- [Feature flag] Rollout of `security_policies_sync` (#446102 - closed) • Sashi Kumar Kumaresan • 17.6 • On track
- [Feature flag] Rollout of `use_approval_policy_... (#474468 - closed) • Sashi Kumar Kumaresan • 18.1
Manage scheduled scan execution pipeline concur... (&13997 - closed)
DRI: @mc_rocha / @aturinske
In %17.5, we want to finalize the first iteration by delivering the Add dynamic concurrency limit for create pipeli... (!162339 - merged) and enabling the feature flag by default. Then we will wait for Scheduled pipeline execution policies (&14147), as we want to introduce similar configuration options to specify a time window when pipelines created from scheduled Scan Execution Policies will be evenly distributed (similar to previously introduced and reverted Distribute scheduled pipelines from Scan Execut... (!145993 - merged)).
- Tasks:
To start/continue working on
Compliance handling of `needs` statements in pi... (#469256 - closed)
Target release: %17.6
DRI: @Andyschoenen
In %17.5, we want to deliver changes needed to ensure that jobs enforced by Pipeline Execution Policies are running in proper order, preventing users from running jobs before the reserved stage when an empty needs: statement is used. We want to deliver the required changes, which might require collaboration with the Verify stage. While we would love to deliver this in %17.5, our aim is to enable the related feature flag by default and release it in %17.6.
Scheduled pipeline execution policies (&14147)
Target release: %17.9
DRI: @Andyschoenen / @aturinske
In %17.4, we already have started working on PoC (Add pipeline execution policy schedule run (!162554 - closed)), where we are collaborating to agree on the policy schema and limitations required to prevent us from having performance issues. In %17.5, we want to continue this discussion and deliver changes behind the feature flag. Then prepare implementation issues needed to deliver all aspects of the feature.
-
Tasks:
- Spike: Prepare PoC to introduce scheduled Pipel... (#472671 - closed) • Andy Schoenen • 17.6
- Spike: Permissions for security_policy_bot to a... (#479124) • Unassigned • Backlog
- prepare further implementation issues if needed
Enforce Custom Stages in Pipeline Execution Pol... (#475152 - closed)
Target release: %17.7
DRI: @mcavoj
Thanks to suggestions from @mcavoj and feedback received from customers we have decided to start working on this Epic earlier than we initially wanted. In %17.5, we want to initiate discussions related to this Epic, as we need to first collaborate with devopsverify on the schema for this new property. Most probably in this milestone our work will be limited only to this, perhaps followed by PoC to verify our decisions.
-
Tasks:
- Enforce Custom Stages in Pipeline Execution Pol... (#475152 - closed) • Andy Schoenen • 17.9 • At risk
- prepare further implementation issues if needed
Improve compatibility between security policies... (&14119)
DRI: @mcavoj
Target release: %17.6
In %17.5, we want to focus on two items: first, delivering changes to improve alignment between Merge Request Approval Policies and Scan Execution Policies, not to require approval when scan results are missing, but the scan was enforced with active Scan Execution Policy. Additionally, we want to investigate how we could improve compatibility between analyzers and policies by introducing a mechanism to communicate in the scope of Spike: Store analyzers results metadata to allo... (#471978 - closed). After this, we will decide with @g.hickman what would be our next steps.
- Tasks:
Support multiple distinct approval actions in m... (&12319 - closed)
DRI: @sashi_kumar / @arfedoro
Target release: %17.7
As the work related to Use database read model for merge request appr... (&9971 - closed) is nearly finished and should not block work associated with this one, we can start working on this feature. As there is no need to work on a new schema to support this, we can start working on frontend changes behind the feature flag, which we plan to deliver in this milestone and initiate work related to backend.
- Tasks:
To start planning and breakdown
- Support custom roles in merge request approval ... (&13550 - closed)
- Exclude packages from Merge Request Approval Po... (&10203 - closed)
- Scan Execution Policy Templates (&11919 - closed)
typefeature / typemaintenance backend focus
- Account for configured Scan Execution Policies ... (#490092 - closed) • Marcos Rocha • 17.6 • Needs attention (Deliverable)
- Add performance metrics for Scan Execution Poli... (#479218 - closed) • Andy Schoenen • 17.6 • At risk (Deliverable)
- Security Policy: Any fallback_behavior should a... (#474853 - closed) • Sashi Kumar Kumaresan • 17.6 • At risk (Deliverable)
- Compliance handling of `needs` statements in pi... (#469256 - closed) • Marcos Rocha • 17.7 • At risk (Deliverable)
- Include comparison pipelines for error cases (#467411 - closed) • Sashi Kumar Kumaresan • 17.5 • On track (Deliverable)
- Use security policy read model for approval_rules (#464034 - closed) • Sashi Kumar Kumaresan • 17.7 • At risk (Deliverable)
- Add migration to sync policies to read model (#464033 - closed) • Andy Schoenen, Sashi Kumar Kumaresan • 17.7 • Needs attention (Deliverable)
- Consider multiple pipelines for license approva... (#455760 - closed) • Andy Schoenen • 17.5 • On track (Deliverable)
- Add service to create and sync policy YAML into... (#416262 - closed) • Andy Schoenen • 17.5 • At risk (Deliverable)
- Add sharding key to software_licenses table (#480578 - closed) • Marcos Rocha • 17.7 • At risk (Deliverable)
- Don't disable RSpec/DuplicateSpecLocation inline (#482856 - closed) • Andy Schoenen • 17.5 (Stretch)
- Spike: Disable policies and cleanup records in ... (#472276 - closed) • Imam Hossain • 18.4 (Stretch)
- Metric - usage of scan execution policy (#480257 - closed) • Alan (Maciej) Paruszewski • 17.6 (Stretch)
- Optimise SEP performance (#472223 - closed) • Dominic Bauer • 18.3 (Stretch)
- Spike: Prepare PoC to introduce scheduled Pipel... (#472671 - closed) • Andy Schoenen • 17.6 (Stretch)
- Drop namespace_settings columns related to secu... (#477283 - closed) • Martin Cavoj • 17.5 (Stretch)
- Spike: Store analyzers results metadata to allo... (#471978 - closed) • Martin Cavoj • 17.7 • At risk (Stretch)
typefeature / typemaintenance frontend focus
- [Frontend] Add group/subgroup option in policy ... (#488378 - closed) • Artur Fedorov • 17.5 • On track (Deliverable)
- FE: Add suffix configuration for PEP policy editor (#484860 - closed) • Artur Fedorov • 17.5 • On track (~Deliverable)
- Add link to pipeline execution policy file (#478602 - closed) • Alexander Turinske • 17.6 • At risk (Stretch)
- Follow-up from "Add drawer for vulnerability ma... (#478539 - closed) • Artur Fedorov • 17.5 (Stretch)
- Consistent with error icons (#475021 - closed) • Artur Fedorov • 17.5 (Stretch)
- [Frontend integration] Add integration tests fo... (#470054 - closed) • Artur Fedorov • 17.5 (Stretch)
- Add fallback for to_yaml method (#458346) • Brian • Backlog (Stretch)
- Partially disable rule mode on parsing error fo... (#428693 - closed) • Alexander Turinske • 17.6 (Stretch)
- priority4 / severity4 Improve "New policy" title (#479966 - closed) • Alexander Turinske • 17.6 (Stretch)
typebug backend focus
- SEP variables incorrectly assigned for multiple... (#485051) • Unassigned • 18.7 • At risk (Deliverable)
- BUG: Scan and Pipeline Execution Policies do no... (#482863 - closed) • Andy Schoenen, Alan (Maciej) Paruszewski • 17.10 (Stretch)
- Admin user gets 403 when using the MR external ... (#478783 - closed) • Marcos Rocha • 17.5 (Stretch)
- priority2 / severity3 Move creation of security policy project to bac... (#464329 - closed) • Alexander Turinske • 17.5 • Needs attention (Stretch)
typebug frontend focus
- priority3 / severity3 For scan execution policies, when linking a pro... (#451320 - closed) • Alexander Turinske • 17.5 • On track (Deliverable)
- scan execution policy runner tags are not refre... (#472998 - closed) • Alexander Turinske • 17.5 • At risk (Deliverable)
- New `ignore_default_before_after_script` scan e... (#486637 - closed) • Alexander Turinske • 17.5 • On track (Deliverable)
- priority2 / severity3 Move creation of security policy project to bac... (#464329 - closed) • Alexander Turinske • 17.5 • Needs attention (Stretch)
- priority4 / severity4 Security Policy yaml validation does not work w... (#461252 - closed) • Alexander Turinske • 17.5 • At risk (Stretch)
- priority4 / severity4 Yaml preview does not preview yaml (#478628 - closed) • Artur Fedorov • 17.7 (Stretch)
- Policy editor - Page title description correction (#464764 - closed) • Alexander Turinske, Yonghyun Jin • 17.5 (Stretch)
- Status sections in the MR approval policy condi... (#465289 - closed) • Artur Fedorov • 17.5 (Stretch)
- UX bug: trash icon problem (#464699 - closed) • Artur Fedorov • 17.5 (Stretch)
Say/Do
Please check tasks that you are confident you will be able to deliver within next milestone. When you see a risk in delivering something, please write a comment in this planning issue or in the related Epic/Issue raising the risk. We will be using this to help us better communicate when something might slip and to help us with our predictability. Thanks!
@arfedoro (Planned: 13)
-
[Frontend] Add group/subgroup option in policy ... (#488378 - closed) • Artur Fedorov • 17.5 • On track (Deliverable) -
FE: Allow users to specify more than one requir... (#490098 - closed) • Artur Fedorov • 17.6 (Stretch) -
[Feature flag] Rollout of policy_group_scope_pr... (#488379 - closed) • Artur Fedorov • 17.5 (~) -
FE: Add suffix configuration for PEP policy editor (#484860 - closed) • Artur Fedorov • 17.5 • On track (Stretch) -
Follow-up from "Add drawer for vulnerability ma... (#478539 - closed) • Artur Fedorov • 17.5 (Stretch) -
Consistent with error icons (#475021 - closed) • Artur Fedorov • 17.5 (Stretch) -
Add warning to policy overview when an SEP exce... (#472229 - closed) • Artur Fedorov • 17.5 (Stretch) -
[Frontend integration] Add integration tests fo... (#470054 - closed) • Artur Fedorov • 17.5 (Stretch) -
[Feature flag] Rollout of 'policy_group_scope' (#470052 - closed) • Artur Fedorov • 17.5 (~) -
Status sections in the MR approval policy condi... (#465289 - closed) • Artur Fedorov • 17.5 (Stretch) -
FE: Update policy drawer to include information... (#490099 - closed) • Artur Fedorov • 17.6 (Stretch) -
UX bug: trash icon problem (#464699 - closed) • Artur Fedorov • 17.5 (Stretch) -
Improve handling of long policy summary for lic... (#415576 - closed) • Artur Fedorov • 17.5
@sashi_kumar (Planned: 7)
-
Add service to create and sync policy YAML into... (#416262 - closed) • Andy Schoenen • 17.5 • At risk (Deliverable) -
BE: Allow for multiple require approval actions... (#490097 - closed) • Artur Fedorov • 17.6 • At risk (Deliverable) -
Use security policy read model for approval_rules (#464034 - closed) • Sashi Kumar Kumaresan • 17.7 • At risk (Deliverable) -
Add migration to sync policies to read model (#464033 - closed) • Andy Schoenen, Sashi Kumar Kumaresan • 17.7 • Needs attention (Deliverable) -
Consider multiple pipelines for license approva... (#455760 - closed) • Andy Schoenen • 17.5 • On track (Deliverable) -
[Feature flag] Rollout of `security_policies_sy... (#454828 - closed) • Sashi Kumar Kumaresan • 17.6 • On track (Deliverable) -
[Feature flag] Rollout of `security_policies_sync` (#446102 - closed) • Sashi Kumar Kumaresan • 17.6 • On track (Deliverable) -
[Feature flag] Rollout of `use_approval_policy_... (#474468 - closed) • Sashi Kumar Kumaresan • 18.1 (~)
@mcavoj (Planned: 5)
-
Account for configured Scan Execution Policies ... (#490092 - closed) • Marcos Rocha • 17.6 • Needs attention (Deliverable) -
Security Policy: Any fallback_behavior should a... (#474853 - closed) • Sashi Kumar Kumaresan • 17.6 • At risk (Deliverable) -
Improve documentation for `spp_repository_pipel... (#487924 - closed) • Martin Cavoj • 17.5 (Stretch) -
Drop namespace_settings columns related to secu... (#477283 - closed) • Martin Cavoj • 17.5 (Stretch) -
Spike: Store analyzers results metadata to allo... (#471978 - closed) • Martin Cavoj • 17.7 • At risk (Stretch)
@alan
-
SEP variables incorrectly assigned for multiple... (#485051) • Unassigned • 18.7 • At risk (Deliverable) -
Govern: Security Policies 17.5 Planning Issue (#488661 - closed) • Alan (Maciej) Paruszewski • 17.5 (~) -
E2E Testing (#478111 - closed) • Unassigned • Backlog (~) -
[Feature flag] Enable `allow_restricted_variabl... (#442340 - closed) • Alan (Maciej) Paruszewski • 17.6 (~)
@aturinske (Planned: 6)
-
scan execution policy runner tags are not refre... (#472998 - closed) • Alexander Turinske • 17.5 • At risk (Deliverable) -
For scan execution policies, when linking a pro... (#451320 - closed) • Alexander Turinske • 17.5 • On track (Deliverable) -
New `ignore_default_before_after_script` scan e... (#486637 - closed) • Alexander Turinske • 17.5 • On track (Deliverable) -
Add link to pipeline execution policy file (#478602 - closed) • Alexander Turinske • 17.6 • At risk (Stretch) -
Move creation of security policy project to bac... (#464329 - closed) • Alexander Turinske • 17.5 • Needs attention (Stretch) -
Security Policy yaml validation does not work w... (#461252 - closed) • Alexander Turinske • 17.5 • At risk (Stretch) -
Add fallback for to_yaml method (#458346) • Brian • Backlog (Stretch) -
Partially disable rule mode on parsing error fo... (#428693 - closed) • Alexander Turinske • 17.6 (Stretch) -
[Feature flag] Enable `security_policies_projec... (#482525 - closed) • Alexander Turinske • 17.5 (~) -
Yaml preview does not preview yaml (#478628 - closed) • Artur Fedorov • 17.7 (Stretch)
@Andyschoenen (Planned: ?)
-
Compliance handling of `needs` statements in pi... (#469256 - closed) • Marcos Rocha • 17.7 • At risk (Deliverable) -
BUG: Scan and Pipeline Execution Policies do no... (#482863 - closed) • Andy Schoenen, Alan (Maciej) Paruszewski • 17.10 (Stretch) -
Don't disable RSpec/DuplicateSpecLocation inline (#482856 - closed) • Andy Schoenen • 17.5 (Stretch) -
Spike: Prepare PoC to introduce scheduled Pipel... (#472671 - closed) • Andy Schoenen • 17.6 (Stretch) -
Spike: Disable policies and cleanup records in ... (#472276 - closed) • Imam Hossain • 18.4 (Stretch)
@mc_rocha (Planned: 5)
-
Add performance metrics for Scan Execution Poli... (#479218 - closed) • Andy Schoenen • 17.6 • At risk (Deliverable) -
Update scan execution policy scheduled pipeline... (#467560 - closed) • Marcos Rocha • 17.6 • At risk (Deliverable) -
Include comparison pipelines for error cases (#467411 - closed) • Sashi Kumar Kumaresan • 17.5 • On track (Deliverable) -
Add sharding key to software_licenses table (#480578 - closed) • Marcos Rocha • 17.7 • At risk (Deliverable) -
[Feature flag] Enable custom_software_license (#465358 - closed) • Marcos Rocha • 18.0 (~) -
Metric - usage of scan execution policy (#480257 - closed) • Alan (Maciej) Paruszewski • 17.6 (Stretch) -
Admin user gets 403 when using the MR external ... (#478783 - closed) • Marcos Rocha • 17.5 (Stretch) -
[Feature flag] Enable security_policy_bot_share... (#475099 - closed) • Marcos Rocha • 17.5 (~)
@bauerdominic (Planned: 0)
Extra
- Kanban Board with additional more minor maintenance issues and bugs. (Prioritized from top to bottom)
- Group Priorities List
Metrics
Release post items
Release post items related to current work in the format Epic | Release post | Milestone.
| Epic | Release post | Milestone |
|---|---|---|
| &14149 (closed) | gitlab-com/www-gitlab-com!135589 (merged) | %17.5 |
| &13997 (closed) | gitlab-com/www-gitlab-com!135173 (merged) | %17.5 |