Designs
- Show closed items
Is blocked by
Relates to
- #511049Next 4-6 releases
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Naman Jagdish Gala added gitlab-org#15000 (closed) as parent epic
added gitlab-org#15000 (closed) as parent epic
- Naman Jagdish Gala changed the description
Compare with previous version changed the description
- Naman Jagdish Gala added Category:Pages label
added Category:Pages label
- 🤖 GitLab Bot 🤖 added devopsplan groupknowledge sectiondev labels
added devopsplan groupknowledge sectiondev labels
- Naman Jagdish Gala added typefeature label
added typefeature label
- Naman Jagdish Gala added frontend label
added frontend label
- Naman Jagdish Gala marked this issue as blocked by #481332 (closed)
marked this issue as blocked by #481332 (closed)
- Vladimir Shushlin changed milestone to %Backlog
changed milestone to %Backlog
- Vladimir Shushlin added KnowledgeP3 label
added KnowledgeP3 label
- Vladimir Shushlin added KnowledgeP2 label and removed KnowledgeP3 label
added KnowledgeP2 label and removed KnowledgeP3 label
- Matthew Macfarlane changed milestone to %17.7
changed milestone to %17.7
- Matthew Macfarlane changed the description
Compare with previous version changed the description
- Naman Jagdish Gala added KnowledgeP3 label and removed KnowledgeP2 label
added KnowledgeP3 label and removed KnowledgeP2 label
- Naman Jagdish Gala assigned to @ngala
assigned to @ngala
- Naman Jagdish Gala set weight to 2
set weight to 2
- Naman Jagdish Gala added workflowready for development label
added workflowready for development label
- Vladimir Shushlin added Stretch label
added Stretch label
added Technical Writing UI text documentation twtriaged labels
- Naman Jagdish Gala changed the description
Compare with previous version changed the description
- Author Developer
@afracazo Can you please review this UI proposal? Thank you.
Collapse replies - Developer
Hi @ngala could you explain to me a bit about this one? We don't currently have a Ui for redirect domains?
- Author Developer
@afracazo We are adding ability to redirect all pages calls to single domain. So here user will only select the default domain redirect and it will be saved in database.
In Pages application, we will use this default domain redirect.
We don't currently have a Ui for redirect domains?
No. It will be part of Deploy > Pages screen where other pages settings reside.
For more context: &15000 (closed)
Edited by Naman Jagdish Gala 1 - Author Developer
@afracazo Have you got a chance to review the UI proposal? Thank you.
- Developer
@ngala I'm wondering how might one add a new domain to the redirect domains.
- Author Developer
@afracazo Adding custom domain is an existing functionality: https://docs.gitlab.com/ee/user/project/pages/custom_domains_ssl_tls_certification/#steps
- Author Developer
- Developer
Thanks @ngala I will need more time to review this workflow and provide any improvements.
- Naman Jagdish Gala mentioned in commit 0a7f92de
mentioned in commit 0a7f92de
- Naman Jagdish Gala mentioned in merge request !174813 (merged)
mentioned in merge request !174813 (merged)
- Naman Jagdish Gala mentioned in commit 99398492
mentioned in commit 99398492
- Naman Jagdish Gala mentioned in commit 52091660
mentioned in commit 52091660
- Naman Jagdish Gala mentioned in commit e9e3d9b3
mentioned in commit e9e3d9b3
- Naman Jagdish Gala mentioned in commit 26be4ffd
mentioned in commit 26be4ffd
- Naman Jagdish Gala mentioned in commit 41b59add
mentioned in commit 41b59add
- Naman Jagdish Gala mentioned in commit a633b7c7
mentioned in commit a633b7c7
- Naman Jagdish Gala mentioned in commit 7d281554
mentioned in commit 7d281554
- Naman Jagdish Gala mentioned in commit f08b2224
mentioned in commit f08b2224
- Naman Jagdish Gala mentioned in commit d9fe71a1
mentioned in commit d9fe71a1
- Naman Jagdish Gala mentioned in merge request !175249 (closed)
mentioned in merge request !175249 (closed)
- Naman Jagdish Gala mentioned in commit 0d5819b7
mentioned in commit 0d5819b7
- Naman Jagdish Gala mentioned in commit ed9b5d92
mentioned in commit ed9b5d92
- Naman Jagdish Gala mentioned in commit 618e49d3
mentioned in commit 618e49d3
- Naman Jagdish Gala mentioned in commit 586a9811
mentioned in commit 586a9811
- Naman Jagdish Gala mentioned in commit 9c90dc40
mentioned in commit 9c90dc40
- Naman Jagdish Gala mentioned in commit 8e13f2be
mentioned in commit 8e13f2be
- Naman Jagdish Gala mentioned in commit 7e281165
mentioned in commit 7e281165
- Maintainer
It's not immediately clear to me what this setting does. How about labeling it "Default URL" with the help text "If selected, requests to other URLs will be redirected to your default URL"
Edited by Janis Altherr Collapse replies - Author Developer
I am open to suggestions.
/cc @afracazo
Edited by Naman Jagdish Gala - Developer
This still sounds a bit complex, can we ask for more help?
@msedlakjakubowski Could you have a look at this and help us figure out a better and easy to understand labels?
- Author Developer
@msedlakjakubowski Did you a get chance to share your thoughts here? Thank you.
- Developer
Hi @janis and @ngala I've been using this quiet holiday season to analyze competitors like Github pages and Netlify and rethink a lot about our
Pages
design. I'll create an issue later today and add all my thinking in there and tag both of you for feedback.For now, what I have identified is that we should use
Primary domain
instead ofDefault URL
, “Primary” is a common term in GitHub Pages, Netlify, etc... That conveys this domain is the one canonical location for a site. “Default URL
” might still sound ambiguous.Here is a proposition for the help text:
If selected, requests to your Pages site from any other domain (including the GitLab-provided domain) are redirected here. Use this to ensure all visitors (and search engines) see a single, consistent domain.
1 1 - Author Developer
@afracazo Thank you.
In the drop down list, what should be the text for the first option? Right now we have kept it as
Do not redirect
. - Developer
@ngala What about "
Don’t enforce a primary domain
" This clarifies that all domains will continue to serve the site without redirecting to a single “primary” location.Edited by Alex Fracazo - Author Developer
@afracazo One other option is to keep it blank. As we are already adding help text below.
- Developer
Let's use this text for now as with the improvement on the layout we will not need a dropdown.
1 - Author Developer
Okay. Updating it to
Don’t enforce a primary domain
. 1
- Naman Jagdish Gala mentioned in commit 17a105c4
mentioned in commit 17a105c4
- Naman Jagdish Gala added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Naman Jagdish Gala mentioned in commit 3b822535
mentioned in commit 3b822535
- Naman Jagdish Gala mentioned in commit 55ee6ba9
mentioned in commit 55ee6ba9
- Naman Jagdish Gala mentioned in commit 5c8ab33f
mentioned in commit 5c8ab33f
- Naman Jagdish Gala mentioned in commit f3723bb4
mentioned in commit f3723bb4
- Naman Jagdish Gala changed milestone to %17.8
changed milestone to %17.8
- Naman Jagdish Gala added candidate17.8 label
added candidate17.8 label
- Naman Jagdish Gala mentioned in commit 6a7a9f8c
mentioned in commit 6a7a9f8c
- Author Developer
@afracazo As requested, this is a quick demo on the feature:
1 1 Collapse replies - Developer
@ngala Any reason why we don't have "Redirect domain" grouped together with "Domain"? I'm finding it difficult to connect Access pages, Domains, and Redirect domains.
@mmacfarlane FYI
1 - Author Developer
Any reason why we don't have "Redirect domain" grouped together with "Domain"?
Redirect domain is part of Pages Project settings that is why we kept it along with other settings. Also user can select Pages default domain (i.e. gitlab.io) as redirect domain which will be not listed in Domains list.
I'm finding it difficult to connect Access pages, Domains, and Redirect domains.
- Access pages: list all links, user can access deployed pages website.
- Domains: User can assign custom domain to pages website.
- Redirect domains: User can default one URL for its pages website.
You can suggest, what will be best suitable option to put redirect domains.
- Developer
@ngala I'm reviewing this workflow and also comparing it with competitors to see if what we have here is following mental model standards.
1 1
- Naman Jagdish Gala added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Naman Jagdish Gala mentioned in commit 860a991e
mentioned in commit 860a991e
- Naman Jagdish Gala mentioned in merge request !176651 (merged)
mentioned in merge request !176651 (merged)
- Naman Jagdish Gala mentioned in commit a8c0ea0b
mentioned in commit a8c0ea0b
- Naman Jagdish Gala mentioned in commit 2345ea50
mentioned in commit 2345ea50
- Naman Jagdish Gala mentioned in commit 19ea36ee
mentioned in commit 19ea36ee
- Naman Jagdish Gala mentioned in commit 0cf346fb
mentioned in commit 0cf346fb
- Naman Jagdish Gala mentioned in commit 7de5d304
mentioned in commit 7de5d304
- Naman Jagdish Gala mentioned in commit 2a95ece4
mentioned in commit 2a95ece4
- Naman Jagdish Gala mentioned in merge request !176699 (merged)
mentioned in merge request !176699 (merged)
- Alex Fracazo marked this issue as related to #511049
marked this issue as related to #511049
- Naman Jagdish Gala mentioned in commit 3f6eb63e
mentioned in commit 3f6eb63e
- Naman Jagdish Gala mentioned in commit e079ae52
mentioned in commit e079ae52
- Naman Jagdish Gala mentioned in commit 62309a67
mentioned in commit 62309a67
- Naman Jagdish Gala mentioned in commit c8df0028
mentioned in commit c8df0028
- Naman Jagdish Gala mentioned in commit 8d457c6e
mentioned in commit 8d457c6e
- Naman Jagdish Gala mentioned in commit 14233940
mentioned in commit 14233940
- Naman Jagdish Gala mentioned in merge request gitlab-pages!1105 (merged)
mentioned in merge request gitlab-pages!1105 (merged)
- Naman Jagdish Gala changed the description
Compare with previous version changed the description
- Naman Jagdish Gala changed title from Add support in UI to select default redirect domain to Add support in UI to select primary domain
changed title from Add support in UI to select default redirect domain to Add support in UI to select primary domain
- Naman Jagdish Gala changed weight to 3 from 2
changed weight to 3 from 2
- Naman Jagdish Gala mentioned in commit db322758
mentioned in commit db322758
- Naman Jagdish Gala mentioned in commit 4088985b
mentioned in commit 4088985b
- Marcin Sedlak-Jakubowski mentioned in merge request !176550 (merged)
mentioned in merge request !176550 (merged)
- Naman Jagdish Gala mentioned in commit f45bed58
mentioned in commit f45bed58
- Naman Jagdish Gala mentioned in issue #511049
mentioned in issue #511049
- Author Developer
Async update
- Current status: Backend changes merged. UI changes under review.
- Progress since the last update: Primary domain renaming changes got merged. It was a huge MR.
- Next steps: UI changes and Pages changes MR to be merged soon. We are blocked by gitlab-com/gl-infra/production#19090 (closed)
Edited by Naman Jagdish Gala 1 2 - Naman Jagdish Gala changed health status to on track
changed health status to on track
- Naman Jagdish Gala mentioned in commit bf3cbb85
mentioned in commit bf3cbb85
- Naman Jagdish Gala marked this issue as blocked by gitlab-com/gl-infra/production#19090 (closed)
marked this issue as blocked by gitlab-com/gl-infra/production#19090 (closed)
- Naman Jagdish Gala changed the description
Compare with previous version changed the description
- Naman Jagdish Gala mentioned in commit 4a5e50af
mentioned in commit 4a5e50af
- Naman Jagdish Gala mentioned in commit d125231e
mentioned in commit d125231e
- Naman Jagdish Gala mentioned in commit b8eba5f9
mentioned in commit b8eba5f9
- Naman Jagdish Gala added workflowverification label and removed workflowin review label
added workflowverification label and removed workflowin review label
- Naman Jagdish Gala mentioned in issue #512382 (closed)
mentioned in issue #512382 (closed)
- Naman Jagdish Gala changed weight to 2 from 3
changed weight to 2 from 3
- Author Developer
Async update:
The feature has been merged and verified.
1 - Naman Jagdish Gala closed
closed
- Naman Jagdish Gala added workflowcomplete label and removed workflowverification label
added workflowcomplete label and removed workflowverification label
- Resolved by Naman Jagdish Gala
amazing! i'm already enabled
@ngala thank you for it 1 5 replies Last reply by Naman Jagdish Gala
@ngala (writing from my private account, because it's the weekend
). Thank you sooo much. I literally created this hack about a week ago which redirects the www domain to the canonical one. https://gitlab.com/leipert-projects/masuren-www-redirect/-/blob/main/public/_redirects?ref_type=headsDoes enabling this setting also change
CI_PAGES_URL
in CI? 1 1 2Collapse replies - Author Developer
@eiperteipert Thank you for your appreciation.
Does enabling this setting also change
CI_PAGES_URL
in CI?No. It will still be a subdomain of
CI_PAGES_DOMAIN
.Edited by Naman Jagdish Gala