[Feature flag] Cleanup `pipeline_security_dashboard_graphql`

Summary

This issue is to cleanup the pipeline_security_dashboard_graphql feature flag, after the feature flag has been enabled by default for an appropriate amount of time in production.

QA cleanup

• Done, see Remove pipeline security dashboard graphql ff (!166732 - merged)

1. 'vulnerability-info-content' selector in qa/qa/ee/page/component/secure_report.rb
2. 'security-report-content' selector in qa/qa/ee/page/project/pipeline/show.rb
3. deprecated views in qa/qa/ee/page/project/secure/pipeline_security.rb
4. create_issue_old_dashboard in qa/qa/ee/page/project/secure/pipeline_security.rb
5. logic related to old/new security dashboard in qa/qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb
6. look for other E2E tests where the old security dashboard is being tested and clean up

backend cleanup

• Done, see Remove pipeline security dashboard graphql ff (!166732 - merged)

1. Remove push feature flag in ee/app/controllers/ee/projects/pipelines_controller.rb

frontend cleanup

• Cleanup Api.pipelineJobs helper and spec - !168556 (merged)
• Cleanup ee/app/assets/javascripts/vue_shared/security_reports/components/helpers.js and spec - !168556 (merged)
  • Remove getDismissalTransitionForVulnerability - !168556 (merged)
  • Remove getCreatedIssueForVulnerability - !168556 (merged)
• Delete ee/spec/frontend/security_dashboard/helpers.js - !168552 (merged)
• Delete Security dashboard store ee/app/assets/javascripts/security_dashboard/store/index.js and spec - !168552 (merged)
  • Remove modules - !168552 (merged)
  • Remove plugins - !168552 (merged)
• Delete vulnerability_issue_link.vue and spec - !168499 (merged)
• Delete vulnerability_action_buttons.vue and spec - !168499 (merged)
• Delete security_dashboard_table_row.vue and spec - !168499 (merged)
• Delete selection_summary_vuex.vue and spec - !168499 (merged)
• Delete security_dashboard_table.vue and spec - !168498 (merged)
• Delete vulnerability_report_layout.vue and spec - !168498 (merged)
• Delete ee/app/assets/javascripts/security_dashboard/components/pipeline/filters.vue and spec - !168498 (merged)
• Delete loading_error.vue and spec - !168496 (merged)
• Delete security_dashboard_vuex.vue and spec - !168496 (merged)
• Delete vulnerability_modal_mixin.js - !168496 (merged)
• Cleanup pipeline_security_dashboard.vue - !167903 (merged)
  • Cleanup spec - !167903 (merged)
  • Cleanup injects - !167903 (merged)

Extra cleanup

Can the following things be cleaned up?

• pipeline_security_dashboard.vue contained a couple injects which we might be able to remove the provide or even go further - !168977 (merged)
  1. vulnerabilitiesEndpoint
  2. emptyStateSvgPath -> still in use
  3. projectId
  4. commitPathTemplate
• Remove emptyStateUnauthorizedSvgPath and emptyStateForbiddenSvgPath coming from backend - !168977 (merged)
• pipeline_security_dashboard.vue contains a dynamic import for pipeline_vulnerability_report.vue. Should we make this a static import? - test MR !169545 (merged)
• VULNERABILITY_MODAL_ID was included in a couple components that have been removed, but it's still in use in modal_open_name.vue and vulnerability_finding_modal.vue - !169575 (merged)

Owners

• Team: groupthreat insights Threat InsightsNavy
• Most appropriate slack channel to reach out to: #g_secure_threat_insights_navy
• Best individual to reach out to: @gitlab-org/secure/threat-insights-frontend-team
• PM: @abellucci

Stakeholders

Expectations

What might happen if this goes wrong?

Cleaning up the feature flag

• Specify in the issue description if this feature will be removed completely or will be productized as part of the Feature Flag cleanup
• Create a merge request to remove pipeline_security_dashboard_graphql feature flag. Ask for review and merge it.
  • Remove all references to the feature flag from the codebase.
  • Remove the YAML definitions for the feature from the repository.
  • Create a changelog entry.
• Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post.
  • /chatops run auto_deploy status <merge-commit-of-cleanup-mr>
• Close the feature issue to indicate the feature will be released in the current milestone.
• If not already done, clean up the feature flag from all environments by running these chatops command in #production channel: /chatops run feature delete pipeline_security_dashboard_graphql --dev --pre --staging --staging-ref --production
• Close this rollout issue.

added feature flag maintenanceremoval typemaintenance labels

mentioned in issue #328818 (closed)

mentioned in issue #438236 (closed)

@lorenzvanherwaarden, Please add a group or category label to identify issue ownership.

You can refer to the Features by Group handbook page for guidance.

If you are unsure about the correct group, please do not leave the issue without a group label, and refer to GitLab's shared responsibility functionality guidelines for more information on how to triage this kind of issue.

This message was generated automatically. You're welcome to improve it.

added Threat InsightsNavy devopsgovern groupthreat insights sectionsec labels

assigned to @lorenzvanherwaarden

added to epic &8054 (closed)

changed milestone to %16.10

mentioned in issue #300757 (closed)

marked this issue as related to #300757 (closed)

marked this issue as related to #328818 (closed)

mentioned in merge request !143797 (merged)

changed the description

removed the relation with #328818 (closed)

marked this issue as blocked by #328818 (closed)

Moving to %16.11 because the blocker issue has also been moved to that milestone.

changed milestone to %16.11

added missed:16.10 label

Moving this back to backlog because we're uncertain when we'll roll out the feature flag: [Feature flag] Rollout of `pipeline_security_da... (#328818 - closed)

changed milestone to %Backlog