[Feature flag] Cleanup `pipeline_security_dashboard_graphql`
Summary
This issue is to cleanup the pipeline_security_dashboard_graphql feature flag, after the feature flag has been enabled by default for an appropriate amount of time in production.
QA cleanup
- 'vulnerability-info-content' selector in
qa/qa/ee/page/component/secure_report.rb - 'security-report-content' selector in
qa/qa/ee/page/project/pipeline/show.rb - deprecated views in
qa/qa/ee/page/project/secure/pipeline_security.rb -
create_issue_old_dashboardinqa/qa/ee/page/project/secure/pipeline_security.rb - logic related to old/new security dashboard in
qa/qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb - look for other E2E tests where the old security dashboard is being tested and clean up
backend cleanup
- Remove push feature flag in
ee/app/controllers/ee/projects/pipelines_controller.rb
frontend cleanup
-
Cleanup Api.pipelineJobshelper and spec - !168556 (merged) -
Cleanup ee/app/assets/javascripts/vue_shared/security_reports/components/helpers.js and spec - !168556 (merged) -
Remove getDismissalTransitionForVulnerability - !168556 (merged) -
Remove getCreatedIssueForVulnerability - !168556 (merged)
-
-
Delete ee/spec/frontend/security_dashboard/helpers.js - !168552 (merged) -
Delete Security dashboard store ee/app/assets/javascripts/security_dashboard/store/index.js and spec - !168552 (merged) -
Remove modules - !168552 (merged) -
Remove plugins - !168552 (merged)
-
-
Delete vulnerability_issue_link.vue and spec - !168499 (merged) -
Delete vulnerability_action_buttons.vue and spec - !168499 (merged) -
Delete security_dashboard_table_row.vue and spec - !168499 (merged) -
Delete selection_summary_vuex.vue and spec - !168499 (merged) -
Delete security_dashboard_table.vue and spec - !168498 (merged) -
Delete vulnerability_report_layout.vue and spec - !168498 (merged) -
Delete ee/app/assets/javascripts/security_dashboard/components/pipeline/filters.vue and spec - !168498 (merged) -
Delete loading_error.vue and spec - !168496 (merged) -
Delete security_dashboard_vuex.vue and spec - !168496 (merged) -
Delete vulnerability_modal_mixin.js - !168496 (merged) -
Cleanup pipeline_security_dashboard.vue - !167903 (merged) -
Cleanup spec - !167903 (merged) -
Cleanup injects - !167903 (merged)
-
Extra cleanup
Can the following things be cleaned up?
-
pipeline_security_dashboard.vuecontained a couple injects which we might be able to remove theprovideor even go further - !168977 (merged)-
✅ vulnerabilitiesEndpoint -
❌ emptyStateSvgPath-> still in use -
✅ projectId -
✅ commitPathTemplate
-
-
✅ RemoveemptyStateUnauthorizedSvgPathandemptyStateForbiddenSvgPathcoming from backend - !168977 (merged) -
✅ pipeline_security_dashboard.vuecontains a dynamic import forpipeline_vulnerability_report.vue. Should we make this a static import? - test MR !169545 (merged) -
✅ VULNERABILITY_MODAL_IDwas included in a couple components that have been removed, but it's still in use inmodal_open_name.vueandvulnerability_finding_modal.vue- !169575 (merged)
Owners
- Team: groupthreat insights Threat InsightsNavy
- Most appropriate slack channel to reach out to:
#g_secure_threat_insights_navy - Best individual to reach out to: @gitlab-org/secure/threat-insights-frontend-team
- PM: @abellucci
Stakeholders
Expectations
What might happen if this goes wrong?
Cleaning up the feature flag
-
Specify in the issue description if this feature will be removed completely or will be productized as part of the Feature Flag cleanup -
Create a merge request to remove pipeline_security_dashboard_graphqlfeature flag. Ask for review and merge it.-
Remove all references to the feature flag from the codebase. -
Remove the YAML definitions for the feature from the repository. -
Create a changelog entry.
-
-
Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post. -
/chatops run auto_deploy status <merge-commit-of-cleanup-mr>
-
-
Close the feature issue to indicate the feature will be released in the current milestone. -
If not already done, clean up the feature flag from all environments by running these chatops command in #productionchannel:/chatops run feature delete pipeline_security_dashboard_graphql --dev --pre --staging --staging-ref --production -
Close this rollout issue.
Edited by Lorenz van Herwaarden