[Feature flag] Cleanup `pipeline_security_dashboard_graphql`

Summary

This issue is to cleanup the pipeline_security_dashboard_graphql feature flag, after the feature flag has been enabled by default for an appropriate amount of time in production.

QA cleanup

  1. 'vulnerability-info-content' selector in qa/qa/ee/page/component/secure_report.rb
  2. 'security-report-content' selector in qa/qa/ee/page/project/pipeline/show.rb
  3. deprecated views in qa/qa/ee/page/project/secure/pipeline_security.rb
  4. create_issue_old_dashboard in qa/qa/ee/page/project/secure/pipeline_security.rb
  5. logic related to old/new security dashboard in qa/qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb
  6. look for other E2E tests where the old security dashboard is being tested and clean up

backend cleanup

  1. Remove push feature flag in ee/app/controllers/ee/projects/pipelines_controller.rb

frontend cleanup

Extra cleanup

Can the following things be cleaned up?

  • pipeline_security_dashboard.vue contained a couple injects which we might be able to remove the provide or even go further - !168977 (merged)
    1. vulnerabilitiesEndpoint
    2. emptyStateSvgPath -> still in use
    3. projectId
    4. commitPathTemplate
  • Remove emptyStateUnauthorizedSvgPath and emptyStateForbiddenSvgPath coming from backend - !168977 (merged)
  • pipeline_security_dashboard.vue contains a dynamic import for pipeline_vulnerability_report.vue. Should we make this a static import? - test MR !169545 (merged)
  • VULNERABILITY_MODAL_ID was included in a couple components that have been removed, but it's still in use in modal_open_name.vue and vulnerability_finding_modal.vue - !169575 (merged)

Owners

Stakeholders

Expectations

What might happen if this goes wrong?

Cleaning up the feature flag

  • Specify in the issue description if this feature will be removed completely or will be productized as part of the Feature Flag cleanup
  • Create a merge request to remove pipeline_security_dashboard_graphql feature flag. Ask for review and merge it.
    • Remove all references to the feature flag from the codebase.
    • Remove the YAML definitions for the feature from the repository.
    • Create a changelog entry.
  • Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post.
    • /chatops run auto_deploy status <merge-commit-of-cleanup-mr>
  • Close the feature issue to indicate the feature will be released in the current milestone.
  • If not already done, clean up the feature flag from all environments by running these chatops command in #production channel: /chatops run feature delete pipeline_security_dashboard_graphql --dev --pre --staging --staging-ref --production
  • Close this rollout issue.
Edited by Lorenz van Herwaarden