Remove security_dashboard from pipeline_security_dashboard
What does this MR do and why?
Related #438235 (closed)
Remove security_dashboard from pipeline_security_dashboard
This is an initial frontend cleanup for the
pipeline_security_dashboard_graphql
feature flag. It removes the feature flag and the old security_dashboard component from the pipeline_security_dashboard component.
This will be followed by an MR to cleanup the backend and E2E part of the feature flag: !166732 (merged). Followed by one or multiple MRs to cleanup the rest of the frontend (which will be a couple thousand LOC removal).
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Merge request reports
Activity
changed milestone to %17.5
assigned to @lorenzvanherwaarden
added pipelinetier-1 label
removed workflowin dev label
added 1 commit
- eb569dc0 - Remove security_dashboard from pipeline_security_dashboard
mentioned in issue #438235 (closed)
- A deleted user
added frontend label
1 Warning This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
testid
selectorsThe following changed lines in this MR contain
testid
selectors:ee/app/assets/javascripts/security_dashboard/components/pipeline/pipeline_security_dashboard.vue
- <pipeline-vulnerability-report v-else data-testid="pipeline-vulnerability-report" /> + <pipeline-vulnerability-report data-testid="pipeline-vulnerability-report" />
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @obaiye
(UTC-4, 6 hours behind author)
@afontaine
(UTC-4, 6 hours behind author)
test for spec/features/*
@hmuralidhar
(UTC+10, 8 hours ahead of author)
Maintainer review is optional for test for spec/features/*
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits cce0dfb0 and c52412ad
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent mainChunk 3.3 MB 3.3 MB - -0.0 % average 4.37 MB 4.37 MB - -0.0 %
Note: We do not have exact data for cce0dfb0. So we have used data from: 2d04b418.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost User- Resolved by Savas Vedova
@dpisek can you do the initial review? If there are no blockers, please pass along to
@svedova
.
requested review from @dpisek
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
- Resolved by Savas Vedova
@svedova - Could you maintainzerize?