Remove `external` field in GraphQL ReleaseAssetLink type
Overview
We started to treat all release links as external in %15.9. See #333967 (closed).
As such, the external
field in ReleaseAssetLink type is no longer needed, and was deprecated in %15.9.
This issue tracks the removal of external
field in GraphQL
.
Proposal
- Remove the
external
field in GraphQL ReleaseAssetLink type. - Remove any references to
external
field in the GraphQL documentation.
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Ahmed Hemdan changed milestone to %15.9
changed milestone to %15.9
- Ahmed Hemdan set weight to 1
set weight to 1
- Ahmed Hemdan marked this issue as related to #388979 (closed)
marked this issue as related to #388979 (closed)
- Ahmed Hemdan added workflowready for development label and removed workflowin dev label
added workflowready for development label and removed workflowin dev label
- Maintainer
@ahmed.hemdan, thanks for adding the workflowready for development label.
This issue has been sent back to workflowrefinement because it's missing the work type classification.
Please add a
type::
label and try again.This message was generated automatically. You're welcome to improve it.
- 🤖 GitLab Bot 🤖 added workflowrefinement label and removed workflowready for development label
added workflowrefinement label and removed workflowready for development label
- Ahmed Hemdan added typefeature + 1 deleted label
added typefeature + 1 deleted label
- Ahmed Hemdan added workflowready for development label and removed workflowrefinement label
added workflowready for development label and removed workflowrefinement label
- Ahmed Hemdan changed milestone to %16.0
changed milestone to %16.0
- Ahmed Hemdan changed the description
Compare with previous version changed the description
- Ahmed Hemdan mentioned in issue #333967 (closed)
mentioned in issue #333967 (closed)
- Ahmed Hemdan mentioned in issue gitlab-org/ci-cd/release-group/release#181 (closed)
mentioned in issue gitlab-org/ci-cd/release-group/release#181 (closed)
- Ahmed Hemdan mentioned in merge request !109900 (merged)
mentioned in merge request !109900 (merged)
- Contributor
Hi there, it doesn't look like anyone else has picked up this issue, can I take over?@vshushlin :) Does this make sense as a next good issue for me to work on in your opinion? I think you have the most context of what I've done so far. If there's something more helpful, do let me know! I picked this one from the list of release team backend issues.
Edited by Missy Davies Collapse replies - Author Maintainer
Thanks for reaching out about this issue. It is, however, scheduled for %16.0 as part of the
external
field deprecation, to be announced in %15.9. So if you pick it up now, I'm afraid it will remain unmerged until then.That's said, I think it's a ~"good for new contributors" issue, so if @vshushlin agrees, feel free to pick it up.
Edited by Ahmed Hemdan - Developer
Thanks for your interest, @missy-davies!
Glad to see you want to contribute more!As @ahmed.hemdan said, you can work on it if you want, but we won't be able to merge it for a couple more months because it's a breaking change.
@ahmed.hemdan thanks for jumping in
If you and Missy decide to work on this, please help her to guide these MRs through review 1 - Author Maintainer
If you and Missy decide to work on this, please help her to guide these MRs through review
@vshushlin sure!
@missy-davies feel free to ping me in any MRs you submit if you decide to pick this up.
1 1
- Ahmed Hemdan changed the description
Compare with previous version changed the description
- Missy Davies mentioned in merge request !111750 (merged)
mentioned in merge request !111750 (merged)
- Ahmed Hemdan changed the description
Compare with previous version changed the description
- Ahmed Hemdan added workflowin review label and removed workflowready for development label
added workflowin review label and removed workflowready for development label
- Missy Davies mentioned in issue #388984 (closed)
mentioned in issue #388984 (closed)
- Vladimir Shushlin added to epic &7924 (closed)
added to epic &7924 (closed)
- Vladimir Shushlin added groupconfigure [DEPRECATED] label and removed grouprelease [DEPRECATED] label
added groupconfigure [DEPRECATED] label and removed grouprelease [DEPRECATED] label
- 🤖 GitLab Bot 🤖 added devopsconfigure [DEPRECATED] label and removed devopsrelease [DEPRECATED] label
added devopsconfigure [DEPRECATED] label and removed devopsrelease [DEPRECATED] label
- Missy Davies mentioned in merge request !113548 (merged)
mentioned in merge request !113548 (merged)
- Ahmed Hemdan mentioned in epic &7924 (closed)
mentioned in epic &7924 (closed)
- Vladimir Shushlin assigned to @missy-davies
assigned to @missy-davies
- 🤖 GitLab Bot 🤖 added groupenvironments label and removed groupconfigure [DEPRECATED] label
added groupenvironments label and removed groupconfigure [DEPRECATED] label
- 🤖 GitLab Bot 🤖 added devopsdeploy label and removed devopsconfigure [DEPRECATED] label
added devopsdeploy label and removed devopsconfigure [DEPRECATED] label
- Lyle Kozloff mentioned in epic gitlab-com/support&269
mentioned in epic gitlab-com/support&269
- Maintainer
I think all the work on this has been done! I'll go along and close this issue! Thank you so much @missy-davies!
1 - Nicolò Maria Mezzopera closed
closed
mentioned in issue gitlab-org/ci-cd/deploy-stage/environments-group/info#59 (closed)