Remove Feature Flag Stubs if the flag does not exist
Summary
In !101112 (closed) we raise an error if a flag is not defined but is stubbed via stub_feature_flags
.
There are a variety of flags that are no longer used but are stubbed. This issue is to keep track of removal of that stubbing.
How to contribute
Create an MR to remove usages like stub_feature_flag(some_flag_name_below: true)
or stub_feature_flag(some_flag_name_below: false)
. Update the list below with the MR link.
Add your Merge Requests here:
-
stricter_mr_branch_name
- !101252 (merged) -
check_maven_path_first
- !101247 (merged) -
graphql
- !101261 (merged) -
new_environments_table
- !101262 (merged) -
merge_request_reviewer
- !101266 (merged) -
container_registry_phase_2_deny_list
- !101268 (merged) -
track_resource_iteration_change_events
- !101270 (merged) -
store_security_reports
- !101273 (merged) -
maintenance_mode
- !101275 (merged) -
merge_trains
- !101341 (merged) -
merge_pipelines
- !101341 (merged) -
incident_resource_links_widget
- !101343 (merged) -
devops_adoption
- !102187 (merged) -
bootstrap_confirmation_modals
- !102181 (merged) -
sandboxed_mermaid
- !102181 (merged) -
wiki_list_page_with_normal_repository_rpcs
- !101940 (merged) -
use_primary_and_secondary_stores_for_test_store
- !101945 (merged) -
my_feature_flag
- usesskip_feature_flags_yaml_validation
-
webhooks_gitlab_instance_header
- !101947 (merged) -
test_hll_redis_counter_ff_check
- usesskip_feature_flags_yaml_validation
-
credentials_inventory_revocation_emails
- !101934 (merged) -
thing
- !102187 (merged) -
usage_data_users_clicking_license_testing_visiting_external_website
- !101938 (merged) -
usage_data_users_visiting_testing_license_compliance_full_report
- !101938 (merged) -
unfiltered_epic_aggregates
- !101936 (merged) -
ci_pending_builds_queue_source
- !101935 (merged) -
ff_external_status_checks
- !101963 (merged) -
issue_rebalancing_with_retry
- !102736 (merged) -
pbkdf2_password_encryption
- !102737 (merged) -
usage_data_instrumentation
- !102738 (merged) -
approval_rule
- !102740 (merged) -
identity_verification
- !105438 (closed) -
force_no_sharing_primary_model
- !103499 (merged) -
ci_partitioning_use_test_routing_table
- @mbobin this flag is used only for tests, the models that include the concern pass their own feature flag name as a parameter, like https://gitlab.com/gitlab-org/gitlab/-/blob/46e0100b86d5539b422e56f92d9cf7256fd60435/app/models/ci/build_metadata.rb#L19-22 This flag doesn’t need a definition because it will never be rolled out, so we stub it at https://gitlab.com/gitlab-org/gitlab/-/blob/46e0100b86d5539b422e56f92d9cf7256fd60435/spec/models/concerns/ci/partitionable/switch_spec.rb#L70-76 -
prometheus_metrics_method_instrumentation
- !103505 (merged)
The below flags are likely intentionally not defined (can be solved in the main MR)
-
some_metric_feature
-
some_feature_flag
- usesskip_feature_flags_yaml_validation
-
test_feature_flag
TODO: Open a merge request to improve the docs around enabling for an actor because the examples could be better and this one was cargo culted from the docs:
-
thing
- !102187 (merged)
Edited by Lee Tickett