Remove pbkdf2_password_encryption FF stub
What does this MR do and why?
The pbkdf2_password_encryption
feature flag was removed without removing all stubs in specs, this MR removes the remaining instance
This was found by adding some code here to throw an error if the stubbed flag wasn't defined anywhere:
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.6
added backend grouputilization typemaintenance workflowin review labels
assigned to @vij
added devopsfulfillment sectionfulfillment labels
mentioned in issue #378182 (closed)
1 Warning ⚠ Please add a merge request subtype to this merge request. 1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Rajendra Kadam (
@rkadam3
) (UTC+5.5, 5.5 hours ahead of@vij
)Aleksei Lipniagov (
@alipniagov
) (UTC+1, 1 hour ahead of@vij
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Danger- Resolved by James Fargher
@abdwdd would you mind performing the initial review for this small cleanup when you have a chance?
requested review from @abdwdd
requested review from @proglottis and removed review request for @abdwdd
👋 @abdwdd
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
mentioned in issue gitlab-com/www-gitlab-com#13444 (closed)
enabled an automatic merge when the pipeline for 58e518e1 succeeds
mentioned in commit 0c6bff7a
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added maintenancerefactor label