Gitlab Merge Request Default Approval Rule Cannot Be Deleted by Admin/Sudo user in gitlab-ee:12.4.2-ee.0

curl -i --request GET --header "PRIVATE-TOKEN: $token" http://localhost:8880/api/v4/projects/1/merge_requests/57/approval_rules ; echo

HTTP/1.1 200 OK
Server: nginx
Date: Mon, 11 Nov 2019 00:56:51 GMT
Content-Type: application/json
Content-Length: 179
Connection: keep-alive
Cache-Control: max-age=0, private, must-revalidate
Etag: W/"cfd444a42e44afbf08db9e004c82b6ec"
Vary: Origin
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Request-Id: Eme1hN2Prx7
X-Runtime: 0.071417
Strict-Transport-Security: max-age=31536000
Referrer-Policy: strict-origin-when-cross-origin

[{"id":89,"name":"All Members","rule_type":"any_approver","eligible_approvers":[],"approvals_required":0,"users":[],"groups":[],"contains_hidden_groups":false,"source_rule":null}]

curl -i --request DELETE --header "PRIVATE-TOKEN: $token" http://localhost:8880/api/v4/projects/1/merge_requests/57/approval_rules/89 ; echo

HTTP/1.1 403 Forbidden
Server: nginx
Date: Mon, 11 Nov 2019 00:58:19 GMT
Content-Type: application/json
Content-Length: 26
Connection: keep-alive
Cache-Control: no-cache
Vary: Origin
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Request-Id: tBeCzV3P4Va
X-Runtime: 0.049123

{"message":["Prohibited"]}

changed title from Gitlab Merge Request Default Approval Rule Cannot Be Deleted by Admin/Sudo user to Gitlab Merge Request Default Approval Rule Cannot Be Deleted by Admin/Sudo user in gitlab-ee:12.4.2-ee.0

mentioned in issue #36094 (closed)

mentioned in issue #36177 (closed)

mentioned in issue #36698 (closed)

mentioned in issue #36791 (closed)

Merge Request approvals are made at the Project level, not the Merge Request level.

It looks like you're trying a DELETE on /projects/:id/merge_requests/:mr_id/approval_rules/:approval_rule_id when it should be /projects/:id/approval_rules/:approval_rule_id

Try DELETE /projects/1/approval_rules/89

Let me know if that clarifies things!

@ddavison I think there is also an API at the MR level: https://docs.gitlab.com/ee/api/merge_request_approvals.html#delete-merge-request-level-rule

@alexmnyc Are you sure the token is associated with a user that has sufficient rights? You can check the user associated with token by doing curl -i --request GET --header "PRIVATE-TOKEN: $token" http://localhost:8880/api/v4/user

Yes. The token has SUDO and the account is ADMIN in Gitlab

We do not want to delete project-wide rules. But only the rules that are scoped to that MR (such as a release MR). We create a custom rule when a release MR is detected and only then.

added awaiting feedback label

added approvals devopscreate groupsource code merge requests labels

Same issue.

We want to change default "any_approver" rule to "regular" per MR.

For example, GET https://gitlab.city-srv.ru/api/v4/projects/334/merge_requests/10/approval_rules

Response

[
  {
    "id": 7610,
    "name": "All Members",
    "rule_type": "any_approver",
    "eligible_approvers": [],
    "approvals_required": 0,
    "users": [],
    "groups": [],
    "contains_hidden_groups": false,
    "source_rule": null
  }
]

I want to change, PUT /api/v4/projects/334/merge_requests/10/approval_rules/7610

{
  "name": "test 1",
  "rule_type": "regular",
  "approvals_required": 3,
  "user_ids": [40],
  "group_ids": []
}

Response

{
  "message": [
    "Prohibited"
  ]
}

If my default rule in project is "regular", all working OK. So quick fix for now is change project rule from "Any eligible user" to specific user.

mentioned in issue #195793 (closed)

added sectiondev label

Setting label(s) Category:Source Code Management based on groupsource code.

added Category:Source Code Management label

added Category:Code Review Workflow groupcode review labels and removed Category:Source Code Management groupsource code labels