@anna_vovchenko Would it make sense to schedule this together with #340882 (closed) only because both change the Agent listing UI or you'd prefer to tackle them totally independently?
@anna_vovchenko Yes (on both tabs) and No (it should not be dismissible). Thanks for asking! We will remove it in a few months. On the other hand, it might be nice to have a feature flag (on by default) so self-managed users can switch it off.
@ericschurter Following your pattern at the wiki editor, I'd like to add a request for feedback banner for the GitLab Agent for Kubernetes. I wanted to ask you about how you approached feature flags and self-managed GitLab instances in your case.
Is your banner dismissable?
Is it available on self-managed installations?
Can it be switched off on self-managed installations?
That's great @nagyv-gitlab! It's been very helpful for me to get feedback on the new editor. To answer your questions:
Is your banner dismissable?
It is not, but in retrospect, this would have been a good idea. I've also considered moving it to below the editor so it's not taking up so much vertical space before getting to the feature itself. But as it stands today, the banner is a static element on the page.
Is it available on self-managed installations?
The feature is available on both SaaS and Self-managed, yes.
Can it be switched off on self-managed installations?
No, it can't be turned off. But our approach was to create an opt-in experience to this new editor while we matured the feature set. We just recently removed that opt-in step and there is a development feature flag still lingering that could be used to revert to the old behavior. But it was never meant to be a persistent setting or configurable experience.
Here's how I handled the rollout in more detail:
The new editor was introduced in 14.0 and to get to it you had to start editing a Wiki page and click a link to "Try out the new editor". This was our opt in step, something we used instead of a feature flagged rollout.
Once the link is clicked, you were redirected to edit the page in the new WYSIWYG editor. If there were any unsaved changes, those were lost (which we would alert you to before switching).
If you tried out the new editor but found it wasn't to your liking, there was a link to switch back to the "old" editor – again, we warned about losing unsaved data. It was in this view we also had the feedback link.
As we gathered feedback and rounded out the editor's feature set, we left this experience in place
In 14.6 we removed the opt-in flow and now you can toggle freely between editors without losing data.