Due to backend data not yet being available some of the columns in the end-state design vision had to be left out of the MVC build. This issue will keep track of the updates that need to be completed/built once the data becomes available.
Release notes
The GitLab Agent for Kubernetes requires the agentk component to be installed in the Kubernetes cluster connected to GitLab. While we documented the compatibility between the GitLab installation and agentk versions until now it was not very intuitive to figure out compatibility issues. To support Agent users in their upgrades, GitLab now shows the agentk version installed on the agent listing page.
@anna_vovchenko@ash2k Thanks! I created #340936 and added both dependencies as blockers here. We can treat this issue as the frontend issue, and the other issues should provide the backend.
@nagyv-gitlab From a process perspective, this issue's purpose was just to act as a reminder or placeholder for the work that was getting left out of the original design. So it didn't get forgotten about. After that, it's up to the team to figure out how to best manage it or decide what to do with it... such as your final solution above this comment 😄
For this issue, we do have agentk version in GraphQL. But the Kubernetes version surface is blocked by gitlab-org/cluster-integration/gitlab-agent#100 (closed), and I didn't find the issue for adding the namespace. Could we prioritize that issues as well? Otherwise, I can work only on the agentk version column for the %14.7
@anna_vovchenko The agentk version is the most important as it should be aligned with the GitLab version. I don't mind having only the agentk version added if we miss the backend for the other elements.
@jmandell Sure, sorry for not giving this info earlier!
We call the GitLab versions 14.0, 14.6, etc. In reality, they follow what's called semantic versioning and 14.3 is 14.3.0. (There are a bunch of examples on this page.) Semantic versioning defines (at least) 3 version levels major, minor and patch. In 14.3.1, 14 is the major version, 3 is the minor, and 1 is the patch. This is the standard notation; major.minor.patch ~ 14.3.1.
Both GitLab and the Agent follow this notation, and while KAS is installed together with GitLab, agentk is installed independently as it runs in a user cluster. Thus, we have to discuss the compatibility between a GitLab/KAS version and the agentk versions.
This is described in the version compatibility policy. Basically, we should warn the user if their current GitLab and agentk versions are more than 1 minor version apart.
@nagyv-gitlab Riiiight! I do actually know what semantic versioning is, but it totally didn't register when you said: "Agent minor version" for some reason 😝
OK, so right now the design is showing Version and K8s Version. I assume "Version" is GL/KAS and if so you're saying that when the "Version" is 14.6.1 and the K8s is 14.5.1 we need to show a warning + tooltip next to the K8s Agent that says something like:
Your Agent version is out of sync with your GitLab version which can cause problems. Update the Agent version to the latest. View documentation
when the "Version" is 14.6.1 and the K8s is 14.5.1 we need to show a warning + tooltip next to the K8s Agent that says something
Almost. The K8s version column on the design does not matter. The Version column shows the agentk version, and that should be compared to the GitLab version (not shown in the design). Otherwise, the copy is fine.
@nagyv-gitlab I kind of thought you might say that... so, should we add a GitLab version col so the warning + tooltip has a visual item for comparison? I actually don't know where to go on GL to find the version, it's not on this page that I can see for instance.
Along with that question, do users have an awareness of what KAS is and how it relates to GL's versioning? I'm thinking about the column label if we do end up adding it, for instance:
@jmandell I'd refrain from adding a column that has the same value in every row. We can write out the GitLab version in the tooltip. (Btw, it's not surprising that you failed to find it. You should click on the ❓ icon beside your profile image at the top, and select "Help" to get to the GitLab version. How could you miss this! ⛔ )
Along with that question, do users have an awareness of what KAS is and how it relates to GL's versioning?
Probably they don't, but I'd not add such a column, as I already wrote.
(Btw, it's not surprising that you failed to find it. You should click on the ❓ icon beside your profile image at the top, and select "Help" to get to the GitLab version. How could you miss this! ⛔ )
Oh yeah, that makes perfect sense 😝
Ok, so how about this for the tooltip:
Your Agent version is out of sync with your GitLab version (v14.6.1) which can cause problems. Update the Agent version to the latest. View documentation
@nagyv-gitlab@jmandell@anna_vovchenko I've created #352233 to follow up on this work, so that we can go on and close this issue, the issue I've created is a clone of this so no lost metadata and designs.