Geo Status Page 2.0 - UI Backstage Followups
What/Why
This issue is to track the varying reviews throughout the MR split out that causes some of the technical implementations of the predecessor MRs to get out of sync. This issue will track all the javascript follow ups to keep the code style consistent throughout this scope geo_nodes_beta.
Implementation
| Category | Feedback | MR |
|---|---|---|
| Test Optimization |
1. Remove `wrapper = null` usages: !55546 (comment 526492295) 2. Use `findComponent` in all spec files: !55904 (comment 529228489) 3. Use `findByTestId` in all spec files: !55904 (comment 529228491) 4. Use kebab-case for `data-testid`: !55546 (comment 526492274) 5. Don't use negation for the `does/does not` render specs: !55904 (comment 531695094) 6. Remove `toBeTruthy()` usage: !55695 (comment 534357564) |
!60167 (merged) |
| i18n |
1. Use `$options.i18n` for all template translations: !55546 (comment 526492283) 2. Use `$options.i18n` for all script translations: !56154 (comment 538534351) 3. Scope Geo translations to `s__('Geo|...')`: !54857 (comment 518990929) |
!60163 (merged) |
| helpPagePath |
1. Use `helpPagePath` to build `constants.js` urls: !54857 (comment 518990921) 2. Use `anchor` property on `helpPagePath` where applicable: !55695 (comment 534353020) |
!60164 (merged) |
| Vuex in Specs |
1. Remove `localVue` from specs: !55904 (comment 531695081) 2. Remove `Vuex.Store` from specs that do not need it: !55904 (comment 531695081) |
!60151 (merged) |
| GitLab UI |
1. Remove `"tabindex=0"` from `GlIcon` popovers as it is not needed to trigger the focus event: !55695 (comment 534351480) 2. Adjust popover text sizes to `gl-font-base`: !55695 (comment 534352570) 3. Use `GlSprintf` for inline translations w/ links: !55695 (comment 534352570) 4. Stub `GlCard` instead of `mount`: !56412 (comment 542439436) |
!60421 (merged) |
| Time Ago | 1. Use `time-ago` component instead of mixin: !56154 (comment 538534363) | !60434 (merged) |
Edited by Zack Cuddy