Geo Node Status 2.0 - Tests Cleanup

Why

Work towards: #325182 (closed)

Over the past few months we have been implementing the new Geo Node Status UI (ee/geo_nodes_beta). More can be read on this epic: &4712 (closed) Throughout the iterations lots of feedback has been received. The above issue tracks the backstage inconsistencies created by different reviews and perspectives. This is part of a series of MRs to clean up all these backstage inconsistencies.

What does this MR do?

This MR addresses the following feedback:

Category

Feedback

Test Optimization

1. Remove `wrapper = null` usages: !55546 (comment 526492295) 2. Use `findComponent` in all spec files: !55904 (comment 529228489) 3. Use `findByTestId` in all spec files: !55904 (comment 529228491) 4. Use kebab-case for `data-testid`: !55546 (comment 526492274) 5. Don't use negation for the `does/does not` render specs: !55904 (comment 531695094) 6. Remove `toBeTruthy()` usage: !55695 (comment 534357564)

To further describe the changes. There are a lot of specs in the geo_nodes_beta namespace that is not using the preferred finders findComponent and findByTestId. This change adds those as well as just some general best practices clean ups including removing wrapper = null.

This change is also behind a feature flag (:geo_nodes:beta)

How to test

1. Set up a Geo Primary/Secondary GDK
2. Fetch the current branch
3. Activate the Feature Flag on your Primary GDK (:geo_nodes_beta)
4. Navigate to http://127.0.0.1:3000/admin/geo/nodes_beta
5. View UI

Screenshots (strongly suggested)

Tests only changed. No visible changes.

Does this MR meet the acceptance criteria?

Conformity

• 📋 Does this MR need a changelog?
  • I have included a changelog entry.
  • I have not included a changelog entry because change is behind a feature flag.
• [-] Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• [-] Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• [-] Label as security and @ mention @gitlab-com/gl-security/appsec
• [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• [-] Security reports checked/validated by a reviewer from the AppSec team