Skip to content
Snippets Groups Projects

Geo Node Status 2.0 - Secondary Details

Merged Geo Node Status 2.0 - Secondary Details
287978_06-geo-node-beta-secondary-details into master
All threads resolved!
Merged Zack Cuddy requested to merge 287978_06-geo-node-beta-secondary-details into master
All threads resolved!

What does this MR do?

This MR breaks off from the UI mega MR: !53090 (closed)
Work towards #287978 (closed)

This MR replaces the placeholder text for the Secondary Node details with actual components.
This MR still leaves a placeholder in the secondary replication summary and overview for future MRs.

How to test

  1. Set up a Geo Primary/Secondary GDK
  2. Fetch the current branch
  3. Activate the Feature Flag on your Primary GDK (:geo_nodes_beta)
  4. Navigate to http://127.0.0.1:3000/admin/geo/nodes_beta
  5. View UI

Screenshots (strongly suggested)

Desktop Mobile
Screenshots Screen_Shot_2021-03-11_at_1.20.11_PM Mobile

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
    • Zack Cuddy
      Zack Cuddy @zcuddy ·
      Author Maintainer
      Resolved by Mike Greiling

      Hey @rob.hunt! Do you have capacity for a frontend review? This change is an attempt at MVC by breaking down a large beta UI, full MR can be found here: !53090 (closed)

      This change replaces the placeholder text for the Geo Secondary Node Details with Replication Summary and Other Info cards.

      The Replication Summary card is full of just placeholder text as there is quite a bit of information that goes in there. The placeholder text for that is replaced in the following MR: !56412 (merged)

      The full plan for implementing this new UI can be found here: #287978 (closed)

      Please let me know if you have any questions 🙇

      This change is behind a feature flag and I also left instructions on how to test locally if you would like to: !56154 (merged)

  • Zack Cuddy requested review from @rob.hunt

    requested review from @rob.hunt

  • Zack Cuddy assigned to @rob.hunt and unassigned @zcuddy

    assigned to @rob.hunt and unassigned @zcuddy

  • 🤖 GitLab Bot 🤖
    🤖 GitLab Bot 🤖 @gitlab-bot ·
    Maintainer

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 4c4ba45a and 042a8c43

    ✨ Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.04 MB 3.04 MB - 0.0 %
    mainChunk 1.87 MB 1.87 MB - 0.0 %

    😨 Significant Growth: 1

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.admin.geo.nodes_beta 358.42 KB 369.3 KB +10.89 KB 3.0 %

    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@dmishunov, @justin_ho, @mikegreiling or @nmezzopera) for review, if you are unsure about the size increase.

    Note: We do not have exact data for 4c4ba45a. So we have used data from: 8d8c1e2e.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details

    Read more about how this report works.

    Generated by 🚫 Danger

    Edited by 🤖 GitLab Bot 🤖
  • Robert Hunt
  • Robert Hunt
  • Robert Hunt
  • Robert Hunt
  • Robert Hunt
  • Robert Hunt assigned to @zcuddy and unassigned @rob.hunt

    assigned to @zcuddy and unassigned @rob.hunt

  • Zack Cuddy mentioned in issue #325182 (closed)

    mentioned in issue #325182 (closed)

  • Zack Cuddy added 142 commits

    added 142 commits

    Compare with previous version

  • Zack Cuddy assigned to @rob.hunt and unassigned @zcuddy

    assigned to @rob.hunt and unassigned @zcuddy

  • Robert Hunt approved this merge request

    approved this merge request

  • Robert Hunt unassigned @rob.hunt

    unassigned @rob.hunt

  • Robert Hunt removed review request for @rob.hunt

    removed review request for @rob.hunt

  • Robert Hunt requested review from @mikegreiling

    requested review from @mikegreiling

  • Robert Hunt mentioned in issue gitlab-com/www-gitlab-com#10293 (closed)

    mentioned in issue gitlab-com/www-gitlab-com#10293 (closed)

  • Zack Cuddy assigned to @zcuddy

    assigned to @zcuddy

  • Mike Greiling approved this merge request

    approved this merge request

  • Mike Greiling resolved all threads

    resolved all threads

  • Mike Greiling merged

    merged

  • Mike Greiling mentioned in commit bf208a35

    mentioned in commit bf208a35

  • GitLab Release Tools Bot added workflowstaging label

    added workflowstaging label

  • GitLab Release Tools Bot added workflowcanary label and removed workflowstaging label

    added workflowcanary label and removed workflowstaging label

  • Yorick Peterse added workflowproduction label and removed workflowcanary label

    added workflowproduction label and removed workflowcanary label

  • GitLab Release Tools Bot added releasedcandidate label

    added releasedcandidate label

  • Zack Cuddy mentioned in merge request !60163 (merged)

    mentioned in merge request !60163 (merged)

  • Zack Cuddy mentioned in merge request !60434 (merged)

    mentioned in merge request !60434 (merged)

    • Please register or sign in to reply