Geo Node Status 2.0 - Vuex Spec Cleanup
Why
Work towards: #325182 (closed)
Over the past few months we have been implementing the new Geo Node Status UI (ee/geo_nodes_beta). More can be read on this epic: &4712 (closed) Throughout the iterations lots of feedback has been received. The above issue tracks the backstage inconsistencies created by different reviews and perspectives. This is part of a series of MRs to clean up all these backstage inconsistencies.
What does this MR do?
This MR addresses the following feedback:
| Category | Feedback |
|---|---|
| Vuex in Specs |
1. Remove `localVue` from specs: !55904 (comment 531695081) 2. Remove `Vuex.Store` from specs that do not need it: !55904 (comment 531695081) |
To further describe the changes. There are quite a few specs that are mocking stores that don't actually need them. The ones that do need the store, are using localVue which is no longer recommended. This change cleans up both.
This change is also behind a feature flag (:geo_nodes:beta)
How to test
- Set up a Geo Primary/Secondary GDK
- Fetch the current branch
- Activate the Feature Flag on your Primary GDK (
:geo_nodes_beta) - Navigate to
http://127.0.0.1:3000/admin/geo/nodes_beta - View UI
Screenshots (strongly suggested)
Tests only changed. No visible changes.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because change is behind a feature flag.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team