Add option to skip LFS integrity check
Although we've improved LFS integrity check performance https://gitlab.com/gitlab-org/gitlab-ce/issues/45062, there will always be limits to how much can be validated before the timeout is reached. We should provide an escape hatch to prevent users getting stuck.
Proposal
Consider supporting an -o skip-lfs-integrity-check
push option (https://gitlab.com/gitlab-org/gitlab-ce/issues/50609#note_101135872)
Links / references
Designs
- Show closed items
Relates to
- gitlab-foss #60591
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- James Ramsay (ex-GitLab) added backend label
added backend label
- James Ramsay (ex-GitLab) changed milestone to %11.7
changed milestone to %11.7
- Maintainer
- 🤖 GitLab Bot 🤖 changed milestone to %11.8
changed milestone to %11.8
- Mek Stittri changed milestone to %11.9
changed milestone to %11.9
- Maintainer
- 🤖 GitLab Bot 🤖 changed milestone to %11.11
changed milestone to %11.11
- 🤖 GitLab Bot 🤖 added missed:11.9 label
added missed:11.9 label
- James Ramsay (ex-GitLab) changed milestone to %Backlog
changed milestone to %Backlog
- James Ramsay (ex-GitLab) removed missed:11.9 label
removed missed:11.9 label
- 🤖 GitLab Bot 🤖 added groupsource code label
added groupsource code label
- 🤖 GitLab Bot 🤖 changed milestone to %Backlog
changed milestone to %Backlog
- 🤖 GitLab Bot 🤖 added sectiondev label
added sectiondev label
- Developer
@tlinz
- one of the issues I found while troubleshooting a problem doing agit push --mirror
on a large project.There's a separate issue for that, which you've already seen - #384325 (and I've just added a comment with a workaround to it)
The related issue linked in the description ended up in groupgitaly and got resolved in %13.12 so it's possible this is mostly redundant now.
We don't want to repos to get pushed and not have all their LFS objects, so this might cause more issues than it fixes.
When the push fails, there's not much information - how many LFS objects are missing, which ones are missing etc.
Maybe this is best tackled by documentation as well
Edited by Ben Prescott_ Collapse replies - Developer
See also #363732 (comment 1207520877)
For now, I will add these two issues to &302 (closed)
- Torsten Linz mentioned in issue #363732
mentioned in issue #363732
- Torsten Linz added to epic &302 (closed)
added to epic &302 (closed)
- 🤖 GitLab Bot 🤖 added Category:Source Code Management label and removed 1 deleted label
added Category:Source Code Management label and removed 1 deleted label
- Jennifer Li mentioned in merge request gitlab-org/quality/triage-ops!1853 (closed)
mentioned in merge request gitlab-org/quality/triage-ops!1853 (closed)
- Jennifer Li added Git-LFS label
added Git-LFS label
- Igor Drozdov mentioned in issue #233550 (closed)
mentioned in issue #233550 (closed)
- Sean Carroll removed from epic &302 (closed)
removed from epic &302 (closed)
- Ash McKenzie added to epic &12895
added to epic &12895
- Derek Ferguson mentioned in issue create-stage#13220 (closed)
mentioned in issue create-stage#13220 (closed)
- Susmikshatha Devi Poosarla changed milestone to %17.5
changed milestone to %17.5
- Ash McKenzie set weight to 2
set weight to 2
- Susmikshatha Devi Poosarla changed milestone to %17.6
changed milestone to %17.6
- Susmikshatha Devi Poosarla removed milestone %17.6
removed milestone %17.6
- Developer
Since skipping the LFS integrity check is not recommended and we have not had any customer issues around this in a long time, I'm closing this for now. If we run into any customers that have issues here, we can reopen and investigate.
- Derek Ferguson closed
closed