Add feature flag to disable LFS pointer check instance wide
Problem to solve
The LFS pointer check is expensive and is even worse when there are IO performance penalties caused by NFS.
We should provide a way to turn this off across the whole instance.
Further details
Proposal
Add a feature flag to disable the LFS pointer check for the entire GitLab instance
Links / references
Designs
- Show closed items
Relates to
- gitlab #241672
- gitlab #27841Backlog3
- gitlab #28100Backlog
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- James Ramsay (ex-GitLab) added Create [DEPRECATED] backend customer devopscreate priority1 + 1 deleted label
added Create [DEPRECATED] backend customer devopscreate priority1 + 1 deleted label
- James Ramsay (ex-GitLab) added severity2 label
added severity2 label
- James Ramsay (ex-GitLab) marked this issue as related to #51480 (moved)
marked this issue as related to #51480 (moved)
- Author Contributor
- James Ramsay (ex-GitLab) changed milestone to %11.11
changed milestone to %11.11
- James Ramsay (ex-GitLab) added Deliverable label
added Deliverable label
- James Ramsay (ex-GitLab) marked this issue as related to #60590 (moved)
marked this issue as related to #60590 (moved)
- James Ramsay (ex-GitLab) marked this issue as related to #60591 (closed)
marked this issue as related to #60591 (closed)
- Contributor
This would come down to adding a new check to
Gitlab::Checks::LfsCheck#validate!
. - Douwe Maan changed weight to 1
changed weight to 1
- Douwe Maan assigned to @igor.drozdov
assigned to @igor.drozdov
- Igor Drozdov mentioned in merge request !27451 (merged)
mentioned in merge request !27451 (merged)
- James Ramsay (ex-GitLab) added groupsource code label
added groupsource code label
- Mek Stittri added to epic &1181
added to epic &1181
- Mek Stittri mentioned in issue #60591 (closed)
mentioned in issue #60591 (closed)
The reasons I didn't suggest a feature flag:
- They are supposed to be temporary/short-lived.
- It's not always obvious to users/customers how to enable it.
- If this is supposed to be an option, we should treat it as a configuration option (e.g. selectable in the admin settings).
- It goes against our convention over configuration principle.
Edited by Stan HuCollapse replies - Contributor
@stanhu See https://gitlab.com/gitlab-org/gitlab-ce/issues/60591#note_162059296; we intend this to be a temporary, stop-gap solution!
Hello,
I'm sorry if this isn't the right place to post a comment, let me know if I should open a new ticket. I really don't understand the state of this issue.
I'm trying to move a git project with git LFS from GitHub to GitLab but I'm facing this issue and I'm stuck. I'm navigating through many issues about this on GitLab and I don't understand the end of the story. Why are all the tickets closed (including this one)? Because what I can see is that this issue still remains.
Could you tell me what is the workaround please?
I'd like to push my project's files including some large ones Thank you
- Douwe Maan added workflowin review label
added workflowin review label
- James Ramsay (ex-GitLab) mentioned in epic &1190 (closed)
mentioned in epic &1190 (closed)
- Mek Stittri marked #60591 (closed) as a duplicate of this issue
marked #60591 (closed) as a duplicate of this issue
- Douwe Maan closed via merge request !27451 (merged)
closed via merge request !27451 (merged)
- Douwe Maan mentioned in commit 6c913f2c
mentioned in commit 6c913f2c
- James Ramsay (ex-GitLab) marked this issue as related to #60028 (moved)
marked this issue as related to #60028 (moved)
- Douwe Maan mentioned in commit 5b5cc74c
mentioned in commit 5b5cc74c
- 🤖 GitLab Bot 🤖 mentioned in issue gl-retrospectives/create-team#12 (closed)
mentioned in issue gl-retrospectives/create-team#12 (closed)
- Stan Hu mentioned in issue gitlab#233550 (closed)
mentioned in issue gitlab#233550 (closed)
We are hosting our own GitLab instance and we just migrated a large project to a new Linux server, and we hit this issue.
This issue was supposed to be a workaround for something that pretty much corrupts a large project.
Is there another workaround?
We just found the option to disable LFS in the configuration of the GitLab instance. We turned it off and things are back to normal.
Sorry about that comment, we should have looked in the configuration before coming to this site!
- 🤖 GitLab Bot 🤖 added Category:Source Code Management label and removed 1 deleted label
added Category:Source Code Management label and removed 1 deleted label
- Jennifer Li mentioned in merge request gitlab-org/quality/triage-ops!1853 (closed)
mentioned in merge request gitlab-org/quality/triage-ops!1853 (closed)