Skip to content

Review App links are not shown in the merge request widget for non-members

Summary

Review App links are not shown in the merge request widget for users that are not members of the project.

Steps to reproduce

  1. Go to a project which you are not a member of, and which has review apps enabled
  2. Find a merge request which has passed in CI and deployed a Review App
  3. Look at the merge request widget, and note that there is no review app linked in the widget.

Alternatively, you can reproduce this by logging out and looking at the MR page, no review app link will be displayed in that case either. e.g. for GitLab team members, look at a merge request in https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests and compare it between an incognito window vs. when logged in.

Example Project

You should be able to reproduce it by looking at a merge request in the www-gitlab-com repo (you'll need an account that's not a member of the gitlab-com group): https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests

You can also see the issue on GNOME's instance with Nautilis: https://gitlab.gnome.org/GNOME/nautilus/merge_requests/205

What is the current bug behavior?

I look at a merge request with a deployed review app, when I'm not a member of the project, and I don't see the review app link.

What is the expected correct behavior?

I should see the review app link for merge requests in any public project, regardless of my membership status.

Relevant logs and/or screenshots

What a member of the Nautilis project sees:

image

What I see, as someone who is not a member:

image

Output of checks

This bug happens on GitLab.com as well as GNOME's instance running CE 10.7.1.

Possible fixes

I assume there's a check for project membership somewhere in the merge request widget that should be removed?