Skip to content

Backup restore SKIP option (omnibus)

Description

Hi there!

I'm trying to restore backup and sometimes it fails due to my mistakes (I choose wrong filesystem for, or give it too small fs to restore to). And it's ok, but it fails on some step like restoring artifacts (when db, repositories and other steps are passed normaly). And so, when I see it fails, for example because of no space left on device - I want resize my filesystem and run backup from the step it failed (artifacts) without restoring other parts that were already restored succsessfuly. I saw in documentation that there is SKIP option during create operation, but it seems like it doesn't work with restore, when I try gitlab-rake gitlab:backup:restore SKIP=db,repositories,lfs BACKUP=$BACKUP_NAME it doesn't take any effect, it starts to unpack whole backup (which is painfully with big installations and slow disk subsystem) and ask me if I want to restore my database again.

Proposal

SKIP option should also work with gitlab-rake gitlab:backup:restore. Also, as I remember it's possible to untar only those files from archive that you need, it would be nice if restore will unpack only those files and directories that is not SKIP'ed

Documentation blurb

https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/raketasks/backup_restore.md#excluding-specific-directories-from-the-backup

Overview

It would be useful when you have corrupted your gitlab data and need to restore it ASAP but you meet some problems during restoration like no space left on device, or read-only fs, or something like "unreachable remote block device" (if you use remote storage) at one of the last steps and start restoring again after fixing some underlying infrastructure problems.

Feature checklist

Make sure these are completed before closing the issue, with a link to the relevant commit.