Fix backup creation and restore for specific Rake tasks
Running gitlab-rake gitlab:backup:create
works, but running gitlab-rake gitlab:backup:repos:create
fails due to:
NoMethodError: private method puts' called for nil:NilClass
Closes #40617 (closed)
Merge request reports
Activity
changed milestone to %11.0
added Category:Backup/Restore of GitLab instances label
assigned to @rymai
added typebug label
mentioned in issue #956 (closed)
mentioned in issue #37312 (moved)
added 1 commit
- 7a13cbf2 - Remove unnecessary configure_cron_mode lines
added 1 commit
- 1cf19032 - Fix backup creation and restore for specific Rake tasks
assigned to @stanhu
added 1 commit
- f0f6d756 - Fix backup creation and restore for specific Rake tasks
- Resolved by Stan Hu
added 1 commit
- bbb9c9ec - Get rid of use of global $progress to improve testability
added 1 commit
- fb1e8670 - Get rid of global $progress to improve testability
assigned to @rymai
- Resolved by Stan Hu
@stanhu Thank you, looks good to me!
Looks like we have some offenses:
lib/backup/manager.rb:109:5: C: Metrics/AbcSize: Assignment Branch Condition size for unpack is too high. [66.51/54.28] def unpack ... ^^^^^^^^^^
and failures: https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/70163572 and https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/70163559
assigned to @stanhu
assigned to @rymai
- Resolved by Stan Hu
mentioned in commit c4a8179f
mentioned in merge request gitlab-org/build/CNG!81 (merged)
mentioned in issue gitlab-org/release/tasks#247 (closed)
mentioned in issue #29180 (closed)