Skip to content
Snippets Groups Projects

Fix backup creation and restore for specific Rake tasks

Merged Stan Hu requested to merge sh-fix-backup-specific-rake-task into master
All threads resolved!

Running gitlab-rake gitlab:backup:create works, but running gitlab-rake gitlab:backup:repos:create fails due to:

NoMethodError: private method puts' called for nil:NilClass

Closes #40617 (closed)

Edited by Stan Hu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Stan Hu added 1 commit

    added 1 commit

    • bbb9c9ec - Get rid of use of global $progress to improve testability

    Compare with previous version

  • Stan Hu added 1 commit

    added 1 commit

    • fb1e8670 - Get rid of global $progress to improve testability

    Compare with previous version

  • assigned to @rymai

  • Stan Hu
  • Stan Hu added 1 commit

    added 1 commit

    • 11a806a9 - Avoid memoization of global variables

    Compare with previous version

  • @stanhu Thank you, looks good to me! :heart: :yellow_heart: :green_heart: :rocket:

  • Looks like we have some offenses:

    lib/backup/manager.rb:109:5: C: Metrics/AbcSize: Assignment Branch Condition size for unpack is too high. [66.51/54.28]
        def unpack ...
        ^^^^^^^^^^

    and failures: https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/70163572 and https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/70163559

  • assigned to @stanhu

  • Stan Hu added 1 commit

    added 1 commit

    Compare with previous version

  • Stan Hu resolved all discussions

    resolved all discussions

  • assigned to @rymai

  • Stan Hu
  • Stan Hu resolved all discussions

    resolved all discussions

  • Rémy Coutable approved this merge request

    approved this merge request

  • Rémy Coutable mentioned in commit c4a8179f

    mentioned in commit c4a8179f

  • mentioned in merge request gitlab-org/build/CNG!81 (merged)

  • Stan Hu mentioned in issue #29180 (closed)

    mentioned in issue #29180 (closed)

  • Please register or sign in to reply
    Loading