Resolve "Pages in project's permissions settings should be named Pages access control"
requested to merge 54142-pages-in-project-s-permission-should-be-named-pages-access-control into master
What does this MR do?
In https://gitlab.com/gitlab-org/gitlab-ce/issues/33422, we added Pages access control and that introduced a change in the project's permissions
Like it's written now, I'd expect the toggle to completely disable Pages, whereas this only toggles the access control status. If you disable the rest of the other features, they disappear from the menu, which is not the case with Pages.
This MR changes the description so that it is clear what this toggle is about.
| before | after |
|---|---|
 |
 |
What are the relevant issue numbers?
- https://gitlab.com/gitlab-org/gitlab-ce/issues/33422
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18589
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
~~Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.~~
Closes #54142 (closed)
Edited by Achilleas Pipinellis